bulk_indexer: Follow convention and add to waitgroup before creating routines (#891)

HaraldNordgren · web-flow · commit dd25a1136962 · 2024-08-02T18:12:23.000+02:00
diff --git a/esutil/bulk_indexer.go b/esutil/bulk_indexer.go
@@ -370,6 +370,7 @@ func (bi *bulkIndexer) init() {
 	bi.queue = make(chan BulkIndexerItem, bi.config.NumWorkers)
 
 	for i := 1; i <= bi.config.NumWorkers; i++ {
+		bi.wg.Add(1)
 		w := worker{
 			id:     i,
 			ch:     bi.queue,
@@ -380,7 +381,6 @@ func (bi *bulkIndexer) init() {
 		w.run()
 		bi.workers = append(bi.workers, &w)
 	}
-	bi.wg.Add(bi.config.NumWorkers)
 }
 
 // worker represents an indexer worker.

Original file line number	Diff line number	Diff line change
`@@ -370,6 +370,7 @@ func (bi *bulkIndexer) init() {`
`370`	`370`	`bi.queue = make(chan BulkIndexerItem, bi.config.NumWorkers)`
`371`	`371`
`372`	`372`	`for i := 1; i <= bi.config.NumWorkers; i++ {`
	`373`	`+ bi.wg.Add(1)`
`373`	`374`	`w := worker{`
`374`	`375`	`id: i,`
`375`	`376`	`ch: bi.queue,`
`@@ -380,7 +381,6 @@ func (bi *bulkIndexer) init() {`
`380`	`381`	`w.run()`
`381`	`382`	`bi.workers = append(bi.workers, &w)`
`382`	`383`	`}`
`383`		`- bi.wg.Add(bi.config.NumWorkers)`
`384`	`384`	`}`
`385`	`385`
`386`	`386`	`// worker represents an indexer worker.`