[8.19] [ES|QL] Tuples followup cleanup (#224650) (#224888)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[ES|QL] Tuples followup cleanup
(#224650)](#224650)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Vadim
Kibana","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-06-23T14:44:12Z","message":"[ES|QL]
Tuples followup cleanup (#224650)\n\n## Summary\n\nMinor followup
cleanup after\nhttps://github.com//pull/224530\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"cb918fcfb9bad3e519724deea62ef48ee4a2d8df","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
Tuples followup
cleanup","number":224650,"url":"https://github.com/elastic/kibana/pull/224650","mergeCommit":{"message":"[ES|QL]
Tuples followup cleanup (#224650)\n\n## Summary\n\nMinor followup
cleanup after\nhttps://github.com//pull/224530\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"cb918fcfb9bad3e519724deea62ef48ee4a2d8df"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224650","number":224650,"mergeCommit":{"message":"[ES|QL]
Tuples followup cleanup (#224650)\n\n## Summary\n\nMinor followup
cleanup after\nhttps://github.com//pull/224530\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"cb918fcfb9bad3e519724deea62ef48ee4a2d8df"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Vadim Kibana <[email protected]>

Author: kibanamachine

src/platform/packages/shared/kbn-esql-ast/src/ast/helpers.ts

@@ -123,9 +123,9 @@ export const binaryExpressionGroup = (node: ESQLAstNode): BinaryExpressionGroup
       case '>=':
         return BinaryExpressionGroup.comparison;
       case 'like':
-      case 'not_like':
+      case 'not like':
       case 'rlike':
-      case 'not_rlike':
+      case 'not rlike':
         return BinaryExpressionGroup.regex;
     }
   }

src/platform/packages/shared/kbn-esql-ast/src/pretty_print/__tests__/basic_pretty_printer.comments.test.ts

@@ -109,10 +109,14 @@ describe('list expressions', () => {
   describe('tuple list', () => {
     test('can print comments around the tuple', () => {
       assertPrint('FROM a | WHERE b IN /* 1 */ /* 2 */ (1, 2, 3) /* 3 */');
+      assertPrint('FROM a | WHERE b NOT IN /* 1 */ /* 2 */ (1, 2, 3) /* 3 */');
     });
 
     test('can print comments inside the tuple', () => {
       assertPrint('FROM a | WHERE b IN (/* 1 */ 1 /* 2 */, /* 3 */ 2 /* 4 */, /* 5 */ 3 /* 6 */)');
+      assertPrint(
+        'FROM a | WHERE b NOT IN (/* 1 */ 1 /* 2 */, /* 3 */ 2 /* 4 */, /* 5 */ 3 /* 6 */)'
+      );
       assertPrint(
         'FROM a | WHERE b IN /* 0 */ (/* 1 */ 1 /* 2 */, /* 3 */ 2 /* 4 */, /* 5 */ 3 /* 6 */) /* 7 */'
       );

src/platform/packages/shared/kbn-esql-ast/src/pretty_print/__tests__/basic_pretty_printer.test.ts

@@ -691,10 +691,12 @@ describe('single line query', () => {
       describe('tuple lists', () => {
         test('empty list', () => {
           expect(reprint('FROM a | WHERE b IN ()').text).toBe('FROM a | WHERE b IN ()');
+          expect(reprint('FROM a | WHERE b NOT IN ()').text).toBe('FROM a | WHERE b NOT IN ()');
         });
 
         test('one element list', () => {
           expect(reprint('FROM a | WHERE b IN (1)').text).toBe('FROM a | WHERE b IN (1)');
+          expect(reprint('FROM a | WHERE b NOT IN (1)').text).toBe('FROM a | WHERE b NOT IN (1)');
         });
 
         test('three element list', () => {

src/platform/packages/shared/kbn-esql-ast/src/pretty_print/__tests__/wrapping_pretty_printer.comments.test.ts

@@ -447,7 +447,7 @@ ROW
   describe('list tuple expressions', () => {
     test('numeric list literal, surrounded from three sides', () => {
       assertReprint(`FROM a | WHERE b IN ()`);
-      assertReprint(`FROM a | WHERE b IN (/* 1 */ 123456789 /* 2 */)`);
+      assertReprint(`FROM a | WHERE b NOT IN (/* 1 */ 123456789 /* 2 */)`);
       assertReprint(`FROM a
   | WHERE
       b IN

src/platform/packages/shared/kbn-esql-ast/src/pretty_print/__tests__/wrapping_pretty_printer.test.ts

@@ -1038,13 +1038,13 @@ FROM a
 
     test('breaks lists with long items', () => {
       const query =
-        'FROM a | WHERE b in ("abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz", "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz", "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz")';
+        'FROM a | WHERE b not in ("abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz", "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz", "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz")';
       const text = reprint(query).text;
 
       expect('\n' + text).toBe(`
 FROM a
   | WHERE
-      b IN
+      b NOT IN
         (
           "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz",
           "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz",

src/platform/packages/shared/kbn-esql-ast/src/types.ts

@@ -230,11 +230,11 @@ export type BinaryExpressionOperator =
 export type BinaryExpressionArithmeticOperator = '+' | '-' | '*' | '/' | '%';
 export type BinaryExpressionAssignmentOperator = '=';
 export type BinaryExpressionComparisonOperator = '==' | '=~' | '!=' | '<' | '<=' | '>' | '>=';
-export type BinaryExpressionRegexOperator = 'like' | 'not_like' | 'rlike' | 'not_rlike';
+export type BinaryExpressionRegexOperator = 'like' | 'not like' | 'rlike' | 'not rlike';
 export type BinaryExpressionRenameOperator = 'as';
 export type BinaryExpressionWhereOperator = 'where';
 export type BinaryExpressionMatchOperator = ':';
-export type BinaryExpressionIn = 'in' | 'not_in';
+export type BinaryExpressionIn = 'in' | 'not in';
 
 // from https://github.com/elastic/elasticsearch/blob/122e7288200ee03e9087c98dff6cebbc94e774aa/docs/reference/esql/functions/kibana/inline_cast.json
 export type InlineCastingType =

src/platform/packages/shared/kbn-esql-validation-autocomplete/src/validation/function_validation.ts

@@ -38,7 +38,6 @@ import {
   unwrapArrayOneLevel,
   isArrayType,
   isParametrized,
-  // isParam,
 } from '../shared/helpers';
 import { getMessageFromId, errors } from './errors';
 import { getMaxMinNumberOfParams, collapseWrongArgumentTypeMessages } from './helpers';