[9.2] [Discover] Cherry pick a new test for the histogram request and total hits counter (#240803) (#241344)

kibanamachine · jughosta · web-flow · commit 07b7b92f693c · 2025-10-30T20:52:02.000+01:00
# Backport This will backport the following commits from `main` to `9.2`: - [[Discover] Cherry pick a new test for the histogram request and total hits counter (#240803)](#240803)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
diff --git a/src/platform/test/functional/apps/discover/group10/_lens_vis.ts b/src/platform/test/functional/apps/discover/group10/_lens_vis.ts
@@ -17,6 +17,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const monacoEditor = getService('monacoEditor');
   const browser = getService('browser');
   const dataViews = getService('dataViews');
+  const filterBar = getService('filterBar');
+  const retry = getService('retry');
   const { common, discover, header, timePicker } = getPageObjects([
     'common',
     'discover',
@@ -666,5 +668,55 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await testSubjects.existOrFail('partitionVisChart');
       expect(await discover.getVisContextSuggestionType()).to.be('lensSuggestion');
     });
+
+    it('should be able to recover after an aborted request', async () => {
+      const reducedTimeRange = {
+        from: 'Sep 20, 2015 @ 00:00:00.000',
+        to: 'Sep 20, 2015 @ 23:50:13.253',
+      };
+      const reducedTimeSpan = `${reducedTimeRange.from} - ${reducedTimeRange.to} (interval: Auto - 30 minutes)`;
+      const reducedTotalCount = '4,756';
+
+      // add a shorter time range to the recently used list in the time picker
+      await timePicker.setAbsoluteRange(reducedTimeRange.from, reducedTimeRange.to);
+      await discover.waitUntilTabIsLoaded();
+
+      // go back to default time range
+      await timePicker.setDefaultAbsoluteRange();
+      await checkHistogramVis(defaultTimespan, defaultTotalCount);
+
+      // trigger the first request
+      await filterBar.addDslFilter(
+        JSON.stringify({
+          error_query: {
+            indices: [
+              {
+                error_type: 'warning',
+                message: "'Fake slow request'",
+                name: '*',
+                stall_time_seconds: 15,
+              },
+            ],
+          },
+        }),
+        false
+      );
+
+      // wait a moment to ensure the request is in flight
+      await retry.waitFor('loading state', async () => {
+        return (
+          (await header.isGlobalLoadingIndicatorVisible()) && (await discover.isDataGridUpdating())
+        );
+      });
+
+      // by changing the time range it should abort the previous request, fire a new one and recover from the aborted state
+      await timePicker.setRecentlyUsedTime(`${reducedTimeRange.from} to ${reducedTimeRange.to}`);
+
+      await retry.try(async () => {
+        // check that the histogram is showing data for the new time range
+        // and the reported total hits count got updated too
+        await checkHistogramVis(reducedTimeSpan, reducedTotalCount);
+      });
+    });
   });
 }
diff --git a/src/platform/test/functional/page_objects/discover_page.ts b/src/platform/test/functional/page_objects/discover_page.ts
@@ -112,10 +112,15 @@ export class DiscoverPageObject extends FtrService {
     await this.testSubjects.click('addFilter');
   }
 
+  public async isDataGridUpdating() {
+    return await this.testSubjects.exists('discoverDataGridUpdating');
+  }
+
   public async waitUntilSearchingHasFinished() {
     await this.testSubjects.missingOrFail('loadingSpinner', {
       timeout: this.defaultFindTimeout * 10,
     });
+    // TODO: Should we add a check for `discoverDataGridUpdating` too?
   }
 
   public async waitUntilTabIsLoaded() {
diff --git a/src/platform/test/functional/page_objects/time_picker.ts b/src/platform/test/functional/page_objects/time_picker.ts
@@ -100,6 +100,18 @@ export class TimePickerPageObject extends FtrService {
     await this.testSubjects.click(`superDatePickerCommonlyUsed_${option}`);
   }
 
+  /**
+   * Sets recently used time (including custom ranges)
+   * @param option a custom recently used time range (example: "Sep 20, 2015 @ 00:00:00.000 to Sep 20, 2015 @ 23:50:13.253")
+   */
+  async setRecentlyUsedTime(option: string) {
+    await this.testSubjects.exists('superDatePickerToggleQuickMenuButton', { timeout: 5000 });
+    await this.testSubjects.click('superDatePickerToggleQuickMenuButton');
+    const panel = await this.testSubjects.find('superDatePickerQuickMenu');
+    const buttonByOptionText = await panel.findByXpath(`.//button[text()='${option}']`);
+    await buttonByOptionText?.click();
+  }
+
   public async inputValue(dataTestSubj: string, value: string) {
     if (this.browser.isFirefox) {
       const input = await this.testSubjects.find(dataTestSubj);

Original file line number	Diff line number	Diff line change
`@@ -112,10 +112,15 @@ export class DiscoverPageObject extends FtrService {`
`112`	`112`	`await this.testSubjects.click('addFilter');`
`113`	`113`	`}`
`114`	`114`
	`115`	`+ public async isDataGridUpdating() {`
	`116`	`+ return await this.testSubjects.exists('discoverDataGridUpdating');`
	`117`	`+ }`
	`118`	`+`
`115`	`119`	`public async waitUntilSearchingHasFinished() {`
`116`	`120`	`await this.testSubjects.missingOrFail('loadingSpinner', {`
`117`	`121`	`timeout: this.defaultFindTimeout * 10,`
`118`	`122`	`});`
	`123`	+ // TODO: Should we add a check for `discoverDataGridUpdating` too?
`119`	`124`	`}`
`120`	`125`
`121`	`126`	`public async waitUntilTabIsLoaded() {`