Fix flakes in footer tests

Author: seialkali

x-pack/solutions/search/test/functional_search/tests/search_getting_started.ts

@@ -174,22 +174,19 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
 
         describe('Footer content', function () {
           it('renders Search Labs callout and navigates correctly', async () => {
-            await pageObjects.searchGettingStarted.expectFooterCallout(
-              'gettingStartedSearchLabs',
-              'search-labs'
-            );
+            const href = await testSubjects.getAttribute('gettingStartedSearchLabs-btn', 'href');
+            expect(href).to.contain('search-labs');
           });
           it('renders Python Notebooks callout and navigates correctly', async () => {
-            await pageObjects.searchGettingStarted.expectFooterCallout(
-              'gettingStartedOpenNotebooks',
-              'search-labs/tutorials/examples'
-            );
+            const href = await testSubjects.getAttribute('gettingStartedOpenNotebooks-btn', 'href');
+            expect(href).to.contain('search-labs/tutorials/examples');
           });
           it('renders Elasticsearch Documentation callout and navigates correctly', async () => {
-            await pageObjects.searchGettingStarted.expectFooterCallout(
-              'gettingStartedViewDocumentation',
-              'docs/solutions/search/get-started'
+            const href = await testSubjects.getAttribute(
+              'gettingStartedViewDocumentation-btn',
+              'href'
             );
+            expect(href).to.contain('docs/solutions/search/get-started');
           });
         });
       });

x-pack/solutions/search/test/page_objects/search_getting_started_page.ts

@@ -41,17 +41,5 @@ export function SearchGettingStartedProvider({ getService }: FtrProviderContext)
       await testSubjects.existOrFail(tstSubjId);
       expect(await testSubjects.getVisibleText(tstSubjId)).contain(value);
     },
-    async expectFooterCallout(calloutDataTestSubj: string, calloutUrl: string) {
-      await testSubjects.existOrFail(calloutDataTestSubj);
-      await testSubjects.existOrFail(`${calloutDataTestSubj}-btn`);
-      await testSubjects.click(`${calloutDataTestSubj}-btn`);
-      await retry.tryWithRetries(
-        'wait for URL to change',
-        async () => {
-          expect(await browser.getCurrentUrl()).to.contain(calloutUrl);
-        },
-        { initialDelay: 200, retryCount: 5, retryDelay: 500 }
-      );
-    },
   };
 }

x-pack/solutions/search/test/serverless/functional/test_suites/search_getting_started.ts

@@ -92,11 +92,9 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
         });
 
         describe('Footer content', function () {
-          it('renders Search Labs callout and navigates correctly', async () => {
-            await pageObjects.searchGettingStarted.expectFooterCallout(
-              'gettingStartedSearchLabs',
-              'search-labs'
-            );
+          it('renders Python Notebooks callout and navigates correctly', async () => {
+            const href = await testSubjects.getAttribute('gettingStartedOpenNotebooks-btn', 'href');
+            expect(href).to.contain('search-labs/tutorials/examples');
           });
         });
       });
@@ -219,22 +217,19 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
 
         describe('Footer content', function () {
           it('renders Search Labs callout and navigates correctly', async () => {
-            await pageObjects.searchGettingStarted.expectFooterCallout(
-              'gettingStartedSearchLabs',
-              'search-labs'
-            );
+            const href = await testSubjects.getAttribute('gettingStartedSearchLabs-btn', 'href');
+            expect(href).to.contain('search-labs');
           });
           it('renders Python Notebooks callout and navigates correctly', async () => {
-            await pageObjects.searchGettingStarted.expectFooterCallout(
-              'gettingStartedOpenNotebooks',
-              'search-labs/tutorials/examples'
-            );
+            const href = await testSubjects.getAttribute('gettingStartedOpenNotebooks-btn', 'href');
+            expect(href).to.contain('search-labs/tutorials/examples');
           });
           it('renders Elasticsearch Documentation callout and navigates correctly', async () => {
-            await pageObjects.searchGettingStarted.expectFooterCallout(
-              'gettingStartedViewDocumentation',
-              'docs/solutions/search/get-started'
+            const href = await testSubjects.getAttribute(
+              'gettingStartedViewDocumentation-btn',
+              'href'
             );
+            expect(href).to.contain('docs/solutions/search/get-started');
           });
         });
       });