- 
                Notifications
    
You must be signed in to change notification settings  - Fork 8.5k
 
Commit 11bb923
[SecuritySolution][Endpoint][ResponseActions] Response actions telemetry tests for third party agents (#225916)
## Summary
This is a follow up of #221518. 
- [x] Adds missing tests for action creation and action response events
for third party agents.
- [x] Adds telemetry events for completed action responses for
crowdstrike agents.
**Note:** The action creation tests in each agent type is redundant as
the action creation telemetry event is sent from a method in the base
action client class, but tests are added here just to ensure that
telemetry events are not broken by any changes in the future for third
party agents.
### Checklist
Check the PR satisfies following conditions. 
Reviewers should verify this PR satisfies this list as well.
- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.
### Identify risks
Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.
- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...
---------
Co-authored-by: kibanamachine <[email protected]>1 parent 1214180 commit 11bb923Copy full SHA for 11bb923
File tree
Expand file treeCollapse file tree
4 files changed
+704
-6
lines changedOpen diff view settings
Filter options
- x-pack/solutions/security/plugins/security_solution/server/endpoint/services/actions/clients
- crowdstrike
 - microsoft/defender/endpoint
 - sentinelone
 
 
Expand file treeCollapse file tree
4 files changed
+704
-6
lines changedOpen diff view settings
0 commit comments