Skip to content

Commit 216aac3

Browse files
authored
[7.17] Remove github-checks-reporter (#228507)
We've mostly moved over to fewer checks in favor of PR comments to reduce the number of API calls. This is already removed on other branches and the application will be shutdown after.
1 parent a7fd4ec commit 216aac3

File tree

72 files changed

+183
-453
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

72 files changed

+183
-453
lines changed

.buildkite/scripts/common/env.sh

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,6 @@ if is_pr; then
6161
export ELASTIC_APM_ACTIVE=false
6262
fi
6363

64-
if [[ "${GITHUB_STEP_COMMIT_STATUS_ENABLED:-}" != "true" ]]; then
65-
export CHECKS_REPORTER_ACTIVE=true
66-
else
67-
export CHECKS_REPORTER_ACTIVE=false
68-
fi
69-
7064
# These can be removed once we're not supporting Jenkins and Buildkite at the same time
7165
# These are primarily used by github checks reporter and can be configured via /github_checks_api.json
7266
export ghprbGhRepository="elastic/kibana"

.buildkite/scripts/common/util.sh

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,6 @@
22

33
source "$(dirname "${BASH_SOURCE[0]}")/vault_fns.sh"
44

5-
checks-reporter-with-killswitch() {
6-
if [ "$CHECKS_REPORTER_ACTIVE" == "true" ] ; then
7-
yarn run github-checks-reporter "$@"
8-
else
9-
arguments=("$@");
10-
"${arguments[@]:1}";
11-
fi
12-
}
13-
145
is_pr() {
156
[[ "${GITHUB_PR_NUMBER-}" ]] && return
167
false

.buildkite/scripts/saved_object_field_metrics.sh

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ source .buildkite/scripts/common/util.sh
66

77
echo '--- Default Saved Object Field Metrics'
88
cd "$XPACK_DIR"
9-
checks-reporter-with-killswitch "Capture Kibana Saved Objects field count metrics" \
10-
node scripts/functional_tests \
11-
--debug --bail \
12-
--kibana-install-dir "$KIBANA_BUILD_LOCATION" \
13-
--config test/saved_objects_field_count/config.ts
9+
node scripts/functional_tests \
10+
--debug --bail \
11+
--kibana-install-dir "$KIBANA_BUILD_LOCATION" \
12+
--config test/saved_objects_field_count/config.ts

.buildkite/scripts/steps/check_types.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,4 @@ source .buildkite/scripts/common/util.sh
77
.buildkite/scripts/bootstrap.sh
88

99
echo --- Check Types
10-
checks-reporter-with-killswitch "Check Types" \
11-
node scripts/type_check
10+
node scripts/type_check

.buildkite/scripts/steps/checks/bundle_limits.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,4 @@ set -euo pipefail
55
source .buildkite/scripts/common/util.sh
66

77
echo --- Check Bundle Limits
8-
9-
checks-reporter-with-killswitch "Check Bundle Limits" \
10-
node scripts/build_kibana_platform_plugins --validate-limits
8+
node scripts/build_kibana_platform_plugins --validate-limits

.buildkite/scripts/steps/checks/commit/commit.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,4 @@ source .buildkite/scripts/common/util.sh
1010
# If files are more than 200 we will skip it and just use
1111
# the further ci steps that already check linting and file casing for the entire repo.
1212
echo --- Quick commit checks
13-
checks-reporter-with-killswitch "Quick commit checks" \
14-
"$(dirname "${0}")/commit_check_runner.sh"
13+
"$(dirname "${0}")/commit_check_runner.sh"

.buildkite/scripts/steps/checks/doc_api_changes.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,4 @@ set -euo pipefail
55
source .buildkite/scripts/common/util.sh
66

77
echo --- Check Doc API Changes
8-
checks-reporter-with-killswitch "Check Doc API Changes" \
9-
node scripts/check_published_api_changes
8+
node scripts/check_published_api_changes

.buildkite/scripts/steps/checks/file_casing.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,4 @@ set -euo pipefail
55
source .buildkite/scripts/common/util.sh
66

77
echo --- Check File Casing
8-
checks-reporter-with-killswitch "Check File Casing" \
9-
node scripts/check_file_casing --quiet
8+
node scripts/check_file_casing --quiet

.buildkite/scripts/steps/checks/i18n.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,4 @@ set -euo pipefail
55
source .buildkite/scripts/common/util.sh
66

77
echo --- Check i18n
8-
checks-reporter-with-killswitch "Check i18n" \
9-
node scripts/i18n_check --ignore-missing
8+
node scripts/i18n_check --ignore-missing

.buildkite/scripts/steps/checks/jest_configs.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,4 @@ set -euo pipefail
55
source .buildkite/scripts/common/util.sh
66

77
echo --- Check Jest Configs
8-
checks-reporter-with-killswitch "Check Jest Configs" \
9-
node scripts/check_jest_configs
8+
node scripts/check_jest_configs

0 commit comments

Comments
 (0)