Skip to content

Commit 223f372

Browse files
🌊 [Group streams] Allow Group streams without Wired streams being enabled (#234060)
## Summary This PR changes the feature flag checks in the Group streams APIs to allow creation of Group streams even if Wired streams aren't enabled. The UI (Streams and Group streams) can be enabled with an Advanced Setting, but since the API still expected Wired streams to be enabled it caused some confusion. Since Group streams can work with only Classic streams, rather than binding the UI to the `_enable` status, I'm instead removing the checks from the APIs.
1 parent 8bdad09 commit 223f372

File tree

2 files changed

+2
-6
lines changed
  • x-pack/platform/plugins/shared/streams/server/routes/streams

2 files changed

+2
-6
lines changed

‎x-pack/platform/plugins/shared/streams/server/routes/streams/crud/route.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,10 +106,10 @@ export const editStreamRoute = createServerRoute({
106106
const { streamsClient } = await getScopedClients({ request });
107107

108108
if (
109-
!Streams.ClassicStream.UpsertRequest.is(params.body) &&
109+
Streams.WiredStream.UpsertRequest.is(params.body) &&
110110
!(await streamsClient.isStreamsEnabled())
111111
) {
112-
throw badData('Streams are not enabled for Wired and Group streams.');
112+
throw badData('Streams are not enabled for Wired streams.');
113113
}
114114

115115
const core = await context.core;

‎x-pack/platform/plugins/shared/streams/server/routes/streams/group/route.ts‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,6 @@ const upsertGroupRoute = createServerRoute({
8181
request,
8282
});
8383

84-
if (!(await streamsClient.isStreamsEnabled())) {
85-
throw badData('Streams are not enabled for Group streams.');
86-
}
87-
8884
const core = await context.core;
8985
const groupStreamsEnabled = await core.uiSettings.client.get(
9086
OBSERVABILITY_STREAMS_ENABLE_GROUP_STREAMS

0 commit comments

Comments
 (0)