Skip to content

Commit 2654b8c

Browse files
authored
[A11y][APM] Add aria-label to popover service in service overview (#215640)
## Summary Fixes #210258 This PR adds an `aria-label` with the same content as the title to solve the "Button must have a discernible text" A11y critical issue. ## How to test 1. Download the [axe devtools](https://chromewebstore.google.com/detail/axe-devtools-web-accessib/lhdoppojpmngadmnindnejefpokejbdd) 2. Go into a service overview and run the scanner from axe devtools 3. You should see a critical error 4. Checkout this branch 5. Error should be solved
1 parent 6665dd3 commit 2654b8c

File tree

1 file changed

+1
-0
lines changed
  • x-pack/solutions/observability/plugins/apm/public/components/shared/service_icons

1 file changed

+1
-0
lines changed

x-pack/solutions/observability/plugins/apm/public/components/shared/service_icons/icon_popover.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ export function IconPopover({
4343
color="text"
4444
onClick={onClick}
4545
iconType={icon.type}
46+
aria-label={title}
4647
iconSize={icon.size ?? 'l'}
4748
className="serviceIcon_button"
4849
data-test-subj={`popover_${title}`}

0 commit comments

Comments
 (0)