[8.19] [Data Streams] Fix displayed index mode (#215683) (#221182)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Data Streams] Fix displayed index mode
(#215683)](#215683)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Elena
Stoeva","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-16T13:09:33Z","message":"[Data
Streams] Fix displayed index mode (#215683)\n\nFixes
https://github.com/elastic/kibana/issues/208671\n\n## Summary\n\nBefore
this PR, the displayed index mode of the data streams was\ndetermined
based on the index mode of the associated index template.\nHowever, the
index mode can also be set through the component template,\nso that
logic is not reliable and can cause incorrectly displayed index\nmode
like described in https://github.com/elastic/kibana/issues/208671.\n\nIn
this PR, we replace this logic with the recently added
`index_mode`\nfield to the Es Get Data Streams API
(see\nhttps://github.com/elastic/elasticsearch/pull/122486).\n\n**How to
test:**\n1. Create a component template with a LogsDB index mode (you
can also\ntest with other index modes):\n```\nPUT
_component_template/my-component-template\n{\n \"template\": {\n
\"settings\": {\n \"index\": {\n \"mode\": \"logsdb\"\n }\n }\n
}\n}\n```\n2. Create an index template that is composed of the component
template\nabove:\n```\nPUT _index_template/my-index-template\n{\n
\"index_patterns\": [\n \"my-ds-*\"\n ],\n \"data_stream\": {},\n
\"composed_of\": [\n \"my-component-template\"\n ]\n}\n```\n3. Create a
data stream that matched the index pattern from the index\ntemplate
above:\n```\nPUT _data_stream/my-ds-1\n```\n4. Go to the data streams
table and verify that the index mode is\ndisplayed correctly in the
table.\n\n<img width=\"1165\" alt=\"Screenshot 2025-03-24 at 18 12
04\"\nsrc=\"https://github.com/user-attachments/assets/ea211c14-3d03-49c7-ace7-88b15e294d1f\"\n/>\n\n\n5.
Click on the created data stream and verify that the displayed
index\nmode in the details panel is correct:\n\n<img width=\"1165\"
alt=\"Screenshot 2025-03-06 at 14 36
12\"\nsrc=\"https://github.com/user-attachments/assets/954864e2-ae2a-4cb8-9eef-2c5f8b417f52\"\n/>\n\n---------\n\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"dec6a17ec02ffea5669ffcf8431009aef1e99cfa","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index
Management","Team:Kibana
Management","release_note:skip","backport:version","v9.1.0","v8.19.0"],"title":"[Data
Streams] Fix displayed index
mode","number":215683,"url":"https://github.com/elastic/kibana/pull/215683","mergeCommit":{"message":"[Data
Streams] Fix displayed index mode (#215683)\n\nFixes
https://github.com/elastic/kibana/issues/208671\n\n## Summary\n\nBefore
this PR, the displayed index mode of the data streams was\ndetermined
based on the index mode of the associated index template.\nHowever, the
index mode can also be set through the component template,\nso that
logic is not reliable and can cause incorrectly displayed index\nmode
like described in https://github.com/elastic/kibana/issues/208671.\n\nIn
this PR, we replace this logic with the recently added
`index_mode`\nfield to the Es Get Data Streams API
(see\nhttps://github.com/elastic/elasticsearch/pull/122486).\n\n**How to
test:**\n1. Create a component template with a LogsDB index mode (you
can also\ntest with other index modes):\n```\nPUT
_component_template/my-component-template\n{\n \"template\": {\n
\"settings\": {\n \"index\": {\n \"mode\": \"logsdb\"\n }\n }\n
}\n}\n```\n2. Create an index template that is composed of the component
template\nabove:\n```\nPUT _index_template/my-index-template\n{\n
\"index_patterns\": [\n \"my-ds-*\"\n ],\n \"data_stream\": {},\n
\"composed_of\": [\n \"my-component-template\"\n ]\n}\n```\n3. Create a
data stream that matched the index pattern from the index\ntemplate
above:\n```\nPUT _data_stream/my-ds-1\n```\n4. Go to the data streams
table and verify that the index mode is\ndisplayed correctly in the
table.\n\n<img width=\"1165\" alt=\"Screenshot 2025-03-24 at 18 12
04\"\nsrc=\"https://github.com/user-attachments/assets/ea211c14-3d03-49c7-ace7-88b15e294d1f\"\n/>\n\n\n5.
Click on the created data stream and verify that the displayed
index\nmode in the details panel is correct:\n\n<img width=\"1165\"
alt=\"Screenshot 2025-03-06 at 14 36
12\"\nsrc=\"https://github.com/user-attachments/assets/954864e2-ae2a-4cb8-9eef-2c5f8b417f52\"\n/>\n\n---------\n\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"dec6a17ec02ffea5669ffcf8431009aef1e99cfa"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215683","number":215683,"mergeCommit":{"message":"[Data
Streams] Fix displayed index mode (#215683)\n\nFixes
https://github.com/elastic/kibana/issues/208671\n\n## Summary\n\nBefore
this PR, the displayed index mode of the data streams was\ndetermined
based on the index mode of the associated index template.\nHowever, the
index mode can also be set through the component template,\nso that
logic is not reliable and can cause incorrectly displayed index\nmode
like described in https://github.com/elastic/kibana/issues/208671.\n\nIn
this PR, we replace this logic with the recently added
`index_mode`\nfield to the Es Get Data Streams API
(see\nhttps://github.com/elastic/elasticsearch/pull/122486).\n\n**How to
test:**\n1. Create a component template with a LogsDB index mode (you
can also\ntest with other index modes):\n```\nPUT
_component_template/my-component-template\n{\n \"template\": {\n
\"settings\": {\n \"index\": {\n \"mode\": \"logsdb\"\n }\n }\n
}\n}\n```\n2. Create an index template that is composed of the component
template\nabove:\n```\nPUT _index_template/my-index-template\n{\n
\"index_patterns\": [\n \"my-ds-*\"\n ],\n \"data_stream\": {},\n
\"composed_of\": [\n \"my-component-template\"\n ]\n}\n```\n3. Create a
data stream that matched the index pattern from the index\ntemplate
above:\n```\nPUT _data_stream/my-ds-1\n```\n4. Go to the data streams
table and verify that the index mode is\ndisplayed correctly in the
table.\n\n<img width=\"1165\" alt=\"Screenshot 2025-03-24 at 18 12
04\"\nsrc=\"https://github.com/user-attachments/assets/ea211c14-3d03-49c7-ace7-88b15e294d1f\"\n/>\n\n\n5.
Click on the created data stream and verify that the displayed
index\nmode in the details panel is correct:\n\n<img width=\"1165\"
alt=\"Screenshot 2025-03-06 at 14 36
12\"\nsrc=\"https://github.com/user-attachments/assets/954864e2-ae2a-4cb8-9eef-2c5f8b417f52\"\n/>\n\n---------\n\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"dec6a17ec02ffea5669ffcf8431009aef1e99cfa"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Elena Stoeva <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>

Author: 3 people

x-pack/platform/plugins/shared/index_management/server/routes/api/data_streams/register_get_route.ts

@@ -11,7 +11,6 @@ import { IScopedClusterClient } from '@kbn/core/server';
 import {
   IndicesDataStream,
   IndicesDataStreamsStatsDataStreamsStatsItem,
-  IndicesGetIndexTemplateIndexTemplateItem,
   SecurityHasPrivilegesResponse,
 } from '@elastic/elasticsearch/lib/api/types';
 import type { MeteringStats } from '../../../lib/types';
@@ -32,14 +31,12 @@ const enhanceDataStreams = ({
   meteringStats,
   dataStreamsPrivileges,
   globalMaxRetention,
-  indexTemplates,
 }: {
   dataStreams: IndicesDataStream[];
   dataStreamsStats?: IndicesDataStreamsStatsDataStreamsStatsItem[];
   meteringStats?: MeteringStats[];
   dataStreamsPrivileges?: SecurityHasPrivilegesResponse;
   globalMaxRetention?: string;
-  indexTemplates?: IndicesGetIndexTemplateIndexTemplateItem[];
 }): EnhancedDataStreamFromEs[] => {
   return dataStreams.map((dataStream) => {
     const enhancedDataStream: EnhancedDataStreamFromEs = {
@@ -74,16 +71,6 @@ const enhanceDataStreams = ({
       }
     }
 
-    if (indexTemplates) {
-      const indexTemplate = indexTemplates.find(
-        (template) => template.name === dataStream.template
-      );
-      if (indexTemplate) {
-        enhancedDataStream.index_mode =
-          indexTemplate.index_template?.template?.settings?.index?.mode;
-      }
-    }
-
     return enhancedDataStream;
   });
 };
@@ -174,9 +161,6 @@ export function registerGetAllRoute({ router, lib: { handleEsError }, config }:
           );
         }
 
-        const { index_templates: indexTemplates } =
-          await client.asCurrentUser.indices.getIndexTemplate();
-
         const { persistent, defaults } = await client.asInternalUser.cluster.getSettings({
           include_defaults: true,
         });
@@ -194,7 +178,6 @@ export function registerGetAllRoute({ router, lib: { handleEsError }, config }:
           meteringStats,
           dataStreamsPrivileges,
           globalMaxRetention,
-          indexTemplates,
         });
 
         return response.ok({
@@ -245,30 +228,17 @@ export function registerGetOneRoute({ router, lib: { handleEsError }, config }:
 
         if (dataStreams[0]) {
           let dataStreamsPrivileges;
-          let indexTemplates;
 
           if (config.isSecurityEnabled()) {
             dataStreamsPrivileges = await getDataStreamsPrivileges(client, [dataStreams[0].name]);
           }
 
-          if (dataStreams[0].template) {
-            const { index_templates: templates } =
-              await client.asCurrentUser.indices.getIndexTemplate({
-                name: dataStreams[0].template,
-              });
-
-            if (templates) {
-              indexTemplates = templates;
-            }
-          }
-
           const enhancedDataStreams = enhanceDataStreams({
             dataStreams,
             dataStreamsStats,
             meteringStats,
             dataStreamsPrivileges,
             globalMaxRetention,
-            indexTemplates,
           });
 
           const { persistent, defaults } = await client.asInternalUser.cluster.getSettings({

x-pack/test/functional/apps/index_management/data_streams_tab/data_streams_tab.ts

@@ -287,6 +287,11 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
         expect(await testSubjects.getVisibleText('indexModeValue')).to.be(indexModeName);
         await testSubjects.click('closeDetailsButton');
 
+        // Perform rollover so that index mode of data stream is updated
+        await es.indices.rollover({
+          alias: TEST_DS_NAME,
+        });
+
         // Navigate to the data streams tab
         await pageObjects.indexManagement.changeTabs('data_streamsTab');
         await pageObjects.header.waitUntilLoadingHasFinished();
@@ -342,7 +347,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
         await verifyModeHasBeenChanged(INDEX_MODE.STANDARD);
       });
 
-      it('allows to upgrade data stream from time series to logsdb index mode', async () => {
+      // Fails because of https://github.com/elastic/elasticsearch/issues/126473
+      it.skip('allows to upgrade data stream from time series to logsdb index mode', async () => {
         await setIndexModeTemplate({
           mode: 'time_series',
           routing_path: 'test',
@@ -364,7 +370,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
         await verifyModeHasBeenChanged(INDEX_MODE.LOGSDB);
       });
 
-      it('allows to downgrade data stream from logsdb to time series index mode', async () => {
+      // Fails because of https://github.com/elastic/elasticsearch/issues/126473
+      it.skip('allows to downgrade data stream from logsdb to time series index mode', async () => {
         await setIndexModeTemplate({
           mode: 'logsdb',
         });

x-pack/test_serverless/functional/test_suites/common/management/index_management/data_streams.ts

@@ -204,6 +204,11 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
         expect(await testSubjects.getVisibleText('indexModeValue')).to.be(indexModeName);
         await testSubjects.click('closeDetailsButton');
 
+        // Perform rollover so that index mode of data stream is updated
+        await es.indices.rollover({
+          alias: TEST_DS_NAME_INDEX_MODE,
+        });
+
         // Navigate to the data streams tab
         await pageObjects.indexManagement.changeTabs('data_streamsTab');
         await pageObjects.header.waitUntilLoadingHasFinished();
@@ -266,7 +271,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
         await verifyModeHasBeenChanged(INDEX_MODE.STANDARD);
       });
 
-      it('allows to upgrade data stream from time series to logsdb index mode', async () => {
+      // Fails because of https://github.com/elastic/elasticsearch/issues/126473
+      it.skip('allows to upgrade data stream from time series to logsdb index mode', async () => {
         await setIndexModeTemplate({
           mode: 'time_series',
           routing_path: 'test',
@@ -287,7 +293,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
         await verifyModeHasBeenChanged(INDEX_MODE.LOGSDB);
       });
 
-      it('allows to downgrade data stream from logsdb to time series index mode', async () => {
+      // Fails because of https://github.com/elastic/elasticsearch/issues/126473
+      it.skip('allows to downgrade data stream from logsdb to time series index mode', async () => {
         await setIndexModeTemplate({
           mode: 'logsdb',
         });