Skip to content

Commit 396abe3

Browse files
[9.2] [dataset quality] Fix breakdown doc trend charts for wired streams (#239147) (#239177)
# Backport This will backport the following commits from `main` to `9.2`: - [[dataset quality] Fix breakdown doc trend charts for wired streams (#239147)](#239147) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Yngrid Coello","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-10-15T15:16:40Z","message":"[dataset quality] Fix breakdown doc trend charts for wired streams (#239147)\n\nCloses https://github.com/elastic/kibana/issues/239138.\n\nWhen we were sending the telemetry events we were relying on the dataset\nbeing in the shape of `${type}-${name}-${namespace}`, however this is\nnot true anymore now that we support streams.\n\nInstead of saving a wrong value for `type`, we now send an empty value,\nwe still can get the whole dataset name by looking into `index_name`.\nFor the other values (`name`, `namespace`) we are also sending an empty\nvalue now.\n\n### 🎥 Demo\n\n#### Before\n\n\nhttps://github.com/user-attachments/assets/e99adb3c-7e51-45fe-a9f3-1f88462ac573\n\n#### After\n\n\nhttps://github.com/user-attachments/assets/ea1e0046-5b3f-4f86-83be-46e1b81f84c1","sha":"ba7ba8707d9df7f39469b653a2b28893302b7335","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.2.0","v9.3.0"],"title":"[dataset quality] Fix breakdown doc trend charts for wired streams","number":239147,"url":"https://github.com/elastic/kibana/pull/239147","mergeCommit":{"message":"[dataset quality] Fix breakdown doc trend charts for wired streams (#239147)\n\nCloses https://github.com/elastic/kibana/issues/239138.\n\nWhen we were sending the telemetry events we were relying on the dataset\nbeing in the shape of `${type}-${name}-${namespace}`, however this is\nnot true anymore now that we support streams.\n\nInstead of saving a wrong value for `type`, we now send an empty value,\nwe still can get the whole dataset name by looking into `index_name`.\nFor the other values (`name`, `namespace`) we are also sending an empty\nvalue now.\n\n### 🎥 Demo\n\n#### Before\n\n\nhttps://github.com/user-attachments/assets/e99adb3c-7e51-45fe-a9f3-1f88462ac573\n\n#### After\n\n\nhttps://github.com/user-attachments/assets/ea1e0046-5b3f-4f86-83be-46e1b81f84c1","sha":"ba7ba8707d9df7f39469b653a2b28893302b7335"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/239147","number":239147,"mergeCommit":{"message":"[dataset quality] Fix breakdown doc trend charts for wired streams (#239147)\n\nCloses https://github.com/elastic/kibana/issues/239138.\n\nWhen we were sending the telemetry events we were relying on the dataset\nbeing in the shape of `${type}-${name}-${namespace}`, however this is\nnot true anymore now that we support streams.\n\nInstead of saving a wrong value for `type`, we now send an empty value,\nwe still can get the whole dataset name by looking into `index_name`.\nFor the other values (`name`, `namespace`) we are also sending an empty\nvalue now.\n\n### 🎥 Demo\n\n#### Before\n\n\nhttps://github.com/user-attachments/assets/e99adb3c-7e51-45fe-a9f3-1f88462ac573\n\n#### After\n\n\nhttps://github.com/user-attachments/assets/ea1e0046-5b3f-4f86-83be-46e1b81f84c1","sha":"ba7ba8707d9df7f39469b653a2b28893302b7335"}}]}] BACKPORT--> Co-authored-by: Yngrid Coello <[email protected]>
1 parent 52a1373 commit 396abe3

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

x-pack/platform/plugins/shared/dataset_quality/public/hooks/use_dataset_details_telemetry.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,9 @@ function getDatasetDetailsEbtProps({
170170
}): DatasetDetailsEbtProps {
171171
const indexName = datasetDetails.rawName;
172172
const dataStream = {
173-
dataset: datasetDetails.name,
174-
namespace: datasetDetails.namespace,
175-
type: datasetDetails.type,
173+
dataset: datasetDetails.name ?? '',
174+
namespace: datasetDetails.namespace ?? '',
175+
type: datasetDetails.name && datasetDetails.namespace ? datasetDetails.type : '',
176176
};
177177
const degradedDocs = dataStreamDetails?.degradedDocsCount ?? 0;
178178
const failedDocs = dataStreamDetails?.failedDocsCount ?? 0;

0 commit comments

Comments
 (0)