Skip to content

Commit 3c50c00

Browse files
[9.1] [Bug] Fixed content connector sync rules non interactive save button (#231555) (#231727)
# Backport This will backport the following commits from `main` to `9.1`: - [[Bug] Fixed content connector sync rules non interactive save button (#231555)](#231555) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Yuliia Naumenko","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-08-14T03:35:02Z","message":"[Bug] Fixed content connector sync rules non interactive save button (#231555)\n\n## Summary\n\nThis PR fixes the bug with saving sync rules.\n\nBefore:\n\n\nhttps://github.com/user-attachments/assets/037f72c1-e570-4c79-a16a-a88d503aa08b\n\n\n\nAfter:\n\n\nhttps://github.com/user-attachments/assets/de937570-cc2c-4370-8c80-e7f1550465b6","sha":"fa4eed64b91724d01e3a78e24b1c360c269b7d09","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","backport:version","v9.2.0","v9.1.3"],"title":"[Bug] Fixed content connector sync rules non interactive save button","number":231555,"url":"https://github.com/elastic/kibana/pull/231555","mergeCommit":{"message":"[Bug] Fixed content connector sync rules non interactive save button (#231555)\n\n## Summary\n\nThis PR fixes the bug with saving sync rules.\n\nBefore:\n\n\nhttps://github.com/user-attachments/assets/037f72c1-e570-4c79-a16a-a88d503aa08b\n\n\n\nAfter:\n\n\nhttps://github.com/user-attachments/assets/de937570-cc2c-4370-8c80-e7f1550465b6","sha":"fa4eed64b91724d01e3a78e24b1c360c269b7d09"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/231555","number":231555,"mergeCommit":{"message":"[Bug] Fixed content connector sync rules non interactive save button (#231555)\n\n## Summary\n\nThis PR fixes the bug with saving sync rules.\n\nBefore:\n\n\nhttps://github.com/user-attachments/assets/037f72c1-e570-4c79-a16a-a88d503aa08b\n\n\n\nAfter:\n\n\nhttps://github.com/user-attachments/assets/de937570-cc2c-4370-8c80-e7f1550465b6","sha":"fa4eed64b91724d01e3a78e24b1c360c269b7d09"}},{"branch":"9.1","label":"v9.1.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Yuliia Naumenko <[email protected]>
1 parent a963caf commit 3c50c00

File tree

2 files changed

+24
-27
lines changed

2 files changed

+24
-27
lines changed

x-pack/platform/plugins/shared/content_connectors/public/components/connector_detail/connector_detail.tsx

Lines changed: 23 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -162,32 +162,29 @@ export const ConnectorDetail: React.FC = () => {
162162
];
163163

164164
const CONNECTOR_TABS = [
165-
...(hasFilteringFeature
166-
? [
167-
{
168-
content: <ConnectorSyncRules />,
169-
disabled: !index,
170-
id: ConnectorDetailTabId.SYNC_RULES,
171-
isSelected: tabId === ConnectorDetailTabId.SYNC_RULES,
172-
label: i18n.translate(
173-
'xpack.contentConnectors.connectors.connectorDetail.syncRulesTabLabel',
174-
{
175-
defaultMessage: 'Sync rules',
176-
}
177-
),
178-
onClick: () =>
179-
application?.navigateToUrl(
180-
generateEncodedPath(
181-
`/app/management/data/content_connectors${CONNECTOR_DETAIL_TAB_PATH}`,
182-
{
183-
connectorId,
184-
tabId: ConnectorDetailTabId.SYNC_RULES,
185-
}
186-
)
187-
),
188-
},
189-
]
190-
: []),
165+
{
166+
content: <ConnectorSyncRules />,
167+
disabled: !index || !hasFilteringFeature,
168+
id: ConnectorDetailTabId.SYNC_RULES,
169+
isSelected: tabId === ConnectorDetailTabId.SYNC_RULES,
170+
label: i18n.translate(
171+
'xpack.contentConnectors.connectors.connectorDetail.syncRulesTabLabel',
172+
{
173+
defaultMessage: 'Sync rules',
174+
}
175+
),
176+
onClick: () =>
177+
application?.navigateToUrl(
178+
generateEncodedPath(
179+
`/app/management/data/content_connectors${CONNECTOR_DETAIL_TAB_PATH}`,
180+
{
181+
connectorId,
182+
tabId: ConnectorDetailTabId.SYNC_RULES,
183+
}
184+
)
185+
),
186+
},
187+
191188
{
192189
content: <ConnectorScheduling />,
193190
disabled: !connector?.index_name,

x-pack/platform/plugins/shared/content_connectors/server/routes/connectors.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1188,7 +1188,7 @@ export function registerConnectorRoutes({
11881188
try {
11891189
const index = await fetchIndex(client.asCurrentUser, indexName);
11901190
return response.ok({
1191-
body: index,
1191+
body: index?.index,
11921192
headers: { 'content-type': 'application/json' },
11931193
});
11941194
} catch (error) {

0 commit comments

Comments
 (0)