Skip to content

Commit 47a652a

Browse files
kibanamachinepaulinashakirovaelasticmachine
authored
[9.1] [a11y][ml] fix trained model spaces button screenreader (#225980) (#226382)
# Backport This will backport the following commits from `main` to `9.1`: - [[a11y][ml] fix trained model spaces button screenreader (#225980)](#225980) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Paulina Shakirova","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-07-03T10:33:19Z","message":"[a11y][ml] fix trained model spaces button screenreader (#225980)\n\n## Summary\nThis PR resolves [[ML] Trained Models: Hidden space buttons in models\nlist are missing discernible\ntext](#216678) issue.\n\n\n<img width=\"1481\" alt=\"Screenshot 2025-07-01 at 13 11 35\"\nsrc=\"https://github.com/user-attachments/assets/5a4ba796-2610-4880-b798-1a01cff337bc\"\n/>\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"2ca700ab74545de98bb9df845c722d3ebe474573","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","backport:prev-minor","backport:prev-major","a11y","v9.2.0"],"title":"[a11y][ml] fix trained model spaces button screenreader","number":225980,"url":"https://github.com/elastic/kibana/pull/225980","mergeCommit":{"message":"[a11y][ml] fix trained model spaces button screenreader (#225980)\n\n## Summary\nThis PR resolves [[ML] Trained Models: Hidden space buttons in models\nlist are missing discernible\ntext](#216678) issue.\n\n\n<img width=\"1481\" alt=\"Screenshot 2025-07-01 at 13 11 35\"\nsrc=\"https://github.com/user-attachments/assets/5a4ba796-2610-4880-b798-1a01cff337bc\"\n/>\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"2ca700ab74545de98bb9df845c722d3ebe474573"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225980","number":225980,"mergeCommit":{"message":"[a11y][ml] fix trained model spaces button screenreader (#225980)\n\n## Summary\nThis PR resolves [[ML] Trained Models: Hidden space buttons in models\nlist are missing discernible\ntext](#216678) issue.\n\n\n<img width=\"1481\" alt=\"Screenshot 2025-07-01 at 13 11 35\"\nsrc=\"https://github.com/user-attachments/assets/5a4ba796-2610-4880-b798-1a01cff337bc\"\n/>\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"2ca700ab74545de98bb9df845c722d3ebe474573"}}]}] BACKPORT--> Co-authored-by: Paulina Shakirova <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
1 parent 39d5d5d commit 47a652a

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

x-pack/platform/plugins/shared/ml/public/application/components/ml_saved_objects_spaces_list/ml_saved_objects_spaces_list.tsx

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,14 @@ export const MLSavedObjectsSpacesList: FC<Props> = ({
114114
onClick={() => setShowFlyout(true)}
115115
style={{ height: 'auto' }}
116116
data-test-subj="mlJobListRowManageSpacesButton"
117+
aria-label={i18n.translate(
118+
'xpack.ml.management.jobsSpacesList.manageSpacesButtonAriaLabel',
119+
{
120+
defaultMessage: 'Manage spaces for this {mlSavedObjectType}',
121+
values: { mlSavedObjectType },
122+
}
123+
)}
124+
tabIndex={spaceIds.length > 0 ? 0 : -1}
117125
>
118126
<LazySpaceList namespaces={spaceIds} displayLimit={0} behaviorContext="outside-space" />
119127
</EuiButtonEmpty>

0 commit comments

Comments
 (0)