[8.19] [Visualization-utils] Fix getTimezone default value (#220658) (#221170)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Visualization-utils] Fix getTimezone default value
(#220658)](#220658)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Marco
Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-05-21T18:12:13Z","message":"[Visualization-utils]
Fix getTimezone default value (#220658)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/220644\n\nThis PR fixes the
mentioned issue by defaulting any non-valid IANA\ntimezone to the
current browser client timezone.\n\nI'm also calling
`moment.tz.guess(true)` with the true value because if\nnot moment will
cache the first timezone guessed and will not be updated\nif the
customer change it manually.\n>By default Moment Timezone caches the
detected timezone. This means\nthat subsequent calls to
moment.tz.guess() will always return the same\nvalue.\nYou can call
moment.tz.guess() with an optional boolean argument\n\"ignoreCache\". If
set to true, the cache will be ignored and overwritten\nwith the new
value.\n\n\n## Release note \n\nThe default timezone is now correctly
applied in TSVB if the user\nchanges and resets to the default the
Advanced Setting
timezone\nparameter.","sha":"28cc698f043df75265632fa0def65e1121fa0c04","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Visualizations","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Visualization-utils]
Fix getTimezone default
value","number":220658,"url":"https://github.com/elastic/kibana/pull/220658","mergeCommit":{"message":"[Visualization-utils]
Fix getTimezone default value (#220658)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/220644\n\nThis PR fixes the
mentioned issue by defaulting any non-valid IANA\ntimezone to the
current browser client timezone.\n\nI'm also calling
`moment.tz.guess(true)` with the true value because if\nnot moment will
cache the first timezone guessed and will not be updated\nif the
customer change it manually.\n>By default Moment Timezone caches the
detected timezone. This means\nthat subsequent calls to
moment.tz.guess() will always return the same\nvalue.\nYou can call
moment.tz.guess() with an optional boolean argument\n\"ignoreCache\". If
set to true, the cache will be ignored and overwritten\nwith the new
value.\n\n\n## Release note \n\nThe default timezone is now correctly
applied in TSVB if the user\nchanges and resets to the default the
Advanced Setting
timezone\nparameter.","sha":"28cc698f043df75265632fa0def65e1121fa0c04"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220658","number":220658,"mergeCommit":{"message":"[Visualization-utils]
Fix getTimezone default value (#220658)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/220644\n\nThis PR fixes the
mentioned issue by defaulting any non-valid IANA\ntimezone to the
current browser client timezone.\n\nI'm also calling
`moment.tz.guess(true)` with the true value because if\nnot moment will
cache the first timezone guessed and will not be updated\nif the
customer change it manually.\n>By default Moment Timezone caches the
detected timezone. This means\nthat subsequent calls to
moment.tz.guess() will always return the same\nvalue.\nYou can call
moment.tz.guess() with an optional boolean argument\n\"ignoreCache\". If
set to true, the cache will be ignored and overwritten\nwith the new
value.\n\n\n## Release note \n\nThe default timezone is now correctly
applied in TSVB if the user\nchanges and resets to the default the
Advanced Setting
timezone\nparameter.","sha":"28cc698f043df75265632fa0def65e1121fa0c04"}}]}]
BACKPORT-->

Co-authored-by: Marco Vettorello <[email protected]>

Author: kibanamachine

src/platform/packages/shared/kbn-visualization-utils/src/get_timezone.test.ts

@@ -28,7 +28,6 @@ describe('getTimeZone', () => {
     expect(
       getTimeZone({
         get: () => 'Browser',
-        isDefault: () => true,
       } as unknown as IUiSettingsClient)
     ).toEqual('America/New_York');
   });
@@ -38,7 +37,6 @@ describe('getTimeZone', () => {
     expect(
       getTimeZone({
         get: () => timezone,
-        isDefault: () => false,
       } as unknown as IUiSettingsClient)
     ).toEqual(timezone);
   });

src/platform/packages/shared/kbn-visualization-utils/src/get_timezone.ts

@@ -14,10 +14,6 @@ import type { IUiSettingsClient } from '@kbn/core/public';
  * Get timeZone from uiSettings
  */
 export function getTimeZone(uiSettings: IUiSettingsClient) {
-  if (uiSettings.isDefault('dateFormat:tz')) {
-    const detectedTimeZone = moment.tz.guess();
-    return detectedTimeZone || moment().format('Z');
-  } else {
-    return uiSettings.get('dateFormat:tz', 'Browser');
-  }
+  const timeZone = uiSettings.get('dateFormat:tz');
+  return moment.tz.zone(timeZone)?.name ?? moment.tz.guess(true);
 }

src/platform/plugins/private/vis_types/timeseries/public/application/components/vis_types/timeseries/vis.test.js

@@ -53,7 +53,9 @@ describe('TimeseriesVisualization', () => {
     });
 
     setUISettings({
-      get: () => ({}),
+      get: (key) => {
+        key === 'dateFormat:tz' ? 'Browser' : {};
+      },
       isDefault: () => true,
     });