Skip to content

Commit 4c1a45c

Browse files
[8.19] [ObsUX][Profiling] Don't render missing symbols callout when frame type is root (#209978) (#219964)
# Backport This will backport the following commits from `main` to `8.19`: - [[ObsUX][Profiling] Don't render missing symbols callout when frame type is root (#209978)](#209978) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Miriam","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-08T08:31:25Z","message":"[ObsUX][Profiling] Don't render missing symbols callout when frame type is root (#209978)\n\nCloses https://github.com/elastic/prodfiler/issues/4386\r\n\r\n### Summary\r\n\r\nThe flyout for the root block always contains the hint \"Missing symbols\r\nerror\" because there are no symbols for the root block. We should not\r\nshow it here.\r\n\r\n### What was done\r\n\r\nAdded a condition to not render the callout when frameType is root\r\n\r\nBefore\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/4856bf40-6753-46bd-a20d-74eebf27533f)\r\n\r\nAfter\r\n\r\nWaiting for [this\r\nPR](elastic/elasticsearch#119115) to be merged\r\nfor the condition to work","sha":"9e65d7a18398877f2721b9b86c69e5fd205e190b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","backport:skip","Team:obs-ux-infra_services","v9.1.0"],"title":"[ObsUX][Profiling] Don't render missing symbols callout when frame type is root","number":209978,"url":"https://github.com/elastic/kibana/pull/209978","mergeCommit":{"message":"[ObsUX][Profiling] Don't render missing symbols callout when frame type is root (#209978)\n\nCloses https://github.com/elastic/prodfiler/issues/4386\r\n\r\n### Summary\r\n\r\nThe flyout for the root block always contains the hint \"Missing symbols\r\nerror\" because there are no symbols for the root block. We should not\r\nshow it here.\r\n\r\n### What was done\r\n\r\nAdded a condition to not render the callout when frameType is root\r\n\r\nBefore\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/4856bf40-6753-46bd-a20d-74eebf27533f)\r\n\r\nAfter\r\n\r\nWaiting for [this\r\nPR](elastic/elasticsearch#119115) to be merged\r\nfor the condition to work","sha":"9e65d7a18398877f2721b9b86c69e5fd205e190b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209978","number":209978,"mergeCommit":{"message":"[ObsUX][Profiling] Don't render missing symbols callout when frame type is root (#209978)\n\nCloses https://github.com/elastic/prodfiler/issues/4386\r\n\r\n### Summary\r\n\r\nThe flyout for the root block always contains the hint \"Missing symbols\r\nerror\" because there are no symbols for the root block. We should not\r\nshow it here.\r\n\r\n### What was done\r\n\r\nAdded a condition to not render the callout when frameType is root\r\n\r\nBefore\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/4856bf40-6753-46bd-a20d-74eebf27533f)\r\n\r\nAfter\r\n\r\nWaiting for [this\r\nPR](elastic/elasticsearch#119115) to be merged\r\nfor the condition to work","sha":"9e65d7a18398877f2721b9b86c69e5fd205e190b"}}]}] BACKPORT--> Co-authored-by: Miriam <[email protected]>
1 parent 5cf6504 commit 4c1a45c

File tree

1 file changed

+4
-2
lines changed
  • x-pack/solutions/observability/plugins/profiling/public/components/frame_information_window

1 file changed

+4
-2
lines changed

x-pack/solutions/observability/plugins/profiling/public/components/frame_information_window/index.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import {
1616
EuiTitle,
1717
} from '@elastic/eui';
1818
import { i18n } from '@kbn/i18n';
19-
import { FrameSymbolStatus, getFrameSymbolStatus } from '@kbn/profiling-utils';
19+
import { FrameSymbolStatus, FrameType, getFrameSymbolStatus } from '@kbn/profiling-utils';
2020
import { isEmpty } from 'lodash';
2121
import React, { useState } from 'react';
2222
import { useCalculateImpactEstimate } from '../../hooks/use_calculate_impact_estimates';
@@ -159,7 +159,9 @@ export function FrameInformationWindow({
159159
</EuiFlexGroup>
160160
</EuiFlexItem>
161161
<FrameInformationAIAssistant frame={frame} />
162-
{showSymbolsStatus && symbolStatus !== FrameSymbolStatus.SYMBOLIZED ? (
162+
{showSymbolsStatus &&
163+
symbolStatus !== FrameSymbolStatus.SYMBOLIZED &&
164+
frame.frameType < FrameType.Root ? (
163165
<EuiFlexItem>
164166
<MissingSymbolsCallout frameType={frame.frameType} />
165167
</EuiFlexItem>

0 commit comments

Comments
 (0)