Format top-level object values in data table (7.17) (#234964)

## Summary

Applies changes from #234228 to
7.17.

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

Author: lukasolson

src/plugins/discover/public/application/apps/main/components/doc_table/lib/row_formatter.test.ts

@@ -14,6 +14,7 @@ import { setServices } from '../../../../../../kibana_services';
 import { DiscoverServices } from '../../../../../../build_services';
 import { stubbedSavedObjectIndexPattern } from '../../../../../../../../data/common/stubs';
 
+let mockConvert = jest.fn();
 describe('Row formatter', () => {
   const hit = {
     _id: 'a',
@@ -49,12 +50,13 @@ describe('Row formatter', () => {
   const fieldsToShow = indexPattern.fields.getAll().map((fld) => fld.name);
 
   beforeEach(() => {
+    mockConvert = jest.fn((value) => value);
     setServices({
       uiSettings: {
         get: () => 100,
       },
       fieldFormats: {
-        getDefaultInstance: jest.fn(() => ({ convert: (value: unknown) => value })),
+        getDefaultInstance: jest.fn(() => ({ convert: (value: unknown) => mockConvert(value) })),
         getFormatterForField: jest.fn(() => ({ convert: (value: unknown) => value })),
       },
     } as unknown as DiscoverServices);
@@ -197,6 +199,8 @@ describe('Row formatter', () => {
     expect(
       formatTopLevelObject(
         {
+          _id: '1',
+          _index: 'test',
           fields: {
             'object.value': [5, 10],
           },
@@ -230,7 +234,11 @@ describe('Row formatter', () => {
     });
     const formatted = ReactDOM.renderToStaticMarkup(
       formatTopLevelObject(
-        { fields: { 'a.zzz': [100], 'a.ccc': [50] } },
+        {
+          _id: '1',
+          _index: 'test',
+          fields: { 'a.zzz': [100], 'a.ccc': [50] },
+        },
         { 'a.zzz': [100], 'a.ccc': [50], getByName: jest.fn() },
         indexPattern
       )
@@ -248,12 +256,14 @@ describe('Row formatter', () => {
     expect(
       formatTopLevelObject(
         {
+          _id: '1',
+          _index: 'test',
           fields: {
             'object.value': [5, 10],
             'object.keys': ['a', 'b'],
           },
           highlight: {
-            'object.keys': 'a',
+            'object.keys': ['a'],
           },
         },
         {
@@ -287,6 +297,8 @@ describe('Row formatter', () => {
     expect(
       formatTopLevelObject(
         {
+          _id: '1',
+          _index: 'test',
           fields: {
             'object.value': [5, 10],
           },
@@ -310,4 +322,35 @@ describe('Row formatter', () => {
       />
     `);
   });
+
+  it('passes values through default formatter for unmapped objects', () => {
+    mockConvert = jest.fn((value: unknown) => `${value}`.replaceAll('foo', 'bar'));
+    indexPattern.getFieldByName = jest.fn().mockReturnValue(undefined);
+    setServices({
+      uiSettings: {
+        get: () => 100,
+      },
+      fieldFormats: {
+        getDefaultInstance: jest.fn(() => ({ convert: (value: unknown) => mockConvert(value) })),
+        getFormatterForField: jest.fn(() => ({ convert: (value: unknown) => mockConvert(value) })),
+      },
+    } as unknown as DiscoverServices);
+
+    const formatted = formatTopLevelObject(
+      {
+        _id: '1',
+        _index: 'test',
+        fields: {
+          'foo.data': ['my foo value'],
+        },
+      },
+      {
+        'foo.data': ['my foo value'],
+        getByName: jest.fn(),
+      },
+      indexPattern
+    );
+    expect(mockConvert).toHaveBeenCalled();
+    expect(ReactDOM.renderToStaticMarkup(formatted)).toContain('my bar value');
+  });
 });

src/plugins/discover/public/application/apps/main/components/doc_table/lib/row_formatter.tsx

@@ -14,6 +14,7 @@ import { getServices } from '../../../../../../kibana_services';
 import { formatHit } from '../../../../../helpers/format_hit';
 
 import './row_formatter.scss';
+import { formatFieldValue } from '../../../../../helpers/format_value';
 
 interface Props {
   defPairs: Array<[string, string]>;
@@ -45,8 +46,7 @@ export const formatRow = (
 };
 
 export const formatTopLevelObject = (
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  row: Record<string, any>,
+  row: estypes.SearchHit,
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   fields: Record<string, any>,
   indexPattern: IndexPattern
@@ -58,18 +58,9 @@ export const formatTopLevelObject = (
   sorted.forEach(([key, values]) => {
     const field = indexPattern.getFieldByName(key);
     const displayKey = fields.getByName ? fields.getByName(key)?.displayName : undefined;
-    const formatter = field
-      ? indexPattern.getFormatterForField(field)
-      : { convert: (v: unknown, ...rest: unknown[]) => String(v) };
     if (!values.map) return;
     const formatted = values
-      .map((val: unknown) =>
-        formatter.convert(val, 'html', {
-          field,
-          hit: row,
-          indexPattern,
-        })
-      )
+      .map((val: unknown) => formatFieldValue(val, row, indexPattern, field))
       .join(', ');
     const pairs = highlights[key] ? highlightPairs : sourcePairs;
     pairs.push([displayKey ? displayKey : key, formatted]);

src/plugins/discover/public/application/components/discover_grid/get_render_cell_value.test.tsx

@@ -20,13 +20,14 @@ jest.mock('../../../../../kibana_react/public', () => ({
   },
 }));
 
+let mockConvert = jest.fn();
 jest.mock('../../../kibana_services', () => ({
   getServices: () => ({
     uiSettings: {
       get: jest.fn(),
     },
     fieldFormats: {
-      getDefaultInstance: jest.fn(() => ({ convert: (value: unknown) => (value ? value : '-') })),
+      getDefaultInstance: jest.fn(() => ({ convert: (value: unknown) => mockConvert(value) })),
     },
   }),
 }));
@@ -77,6 +78,10 @@ const flatten = (hit: ElasticSearchHit): Record<string, unknown> => {
 };
 
 describe('Discover grid cell rendering', function () {
+  beforeEach(() => {
+    mockConvert = jest.fn((value) => (value ? value : '-'));
+  });
+
   it('renders bytes column correctly', () => {
     const DiscoverGridCellValue = getRenderCellValueFn(
       indexPatternMock,
@@ -665,4 +670,40 @@ describe('Discover grid cell rendering', function () {
       />
     `);
   });
+
+  it('passes values through default formatter for unmapped objects', () => {
+    mockConvert = jest.fn((value: unknown) => `${value}`.replaceAll('foo', 'bar'));
+    (indexPatternMock.getFieldByName as jest.Mock).mockReturnValueOnce(undefined);
+    const rowsFieldsUnmapped: ElasticSearchHit[] = [
+      {
+        _id: '1',
+        _index: 'test',
+        _score: 1,
+        _source: undefined,
+        fields: {
+          'foo.data': ['my foo value'],
+        },
+      },
+    ];
+    const DiscoverGridCellValue = getRenderCellValueFn(
+      indexPatternMock,
+      rowsFieldsUnmapped,
+      rowsFieldsUnmapped.map(flatten),
+      true,
+      ['unmapped'],
+      100
+    );
+    const component = shallow(
+      <DiscoverGridCellValue
+        rowIndex={0}
+        columnId="foo"
+        isDetails={false}
+        isExpanded={false}
+        isExpandable={true}
+        setCellProps={jest.fn()}
+      />
+    );
+    expect(mockConvert).toHaveBeenCalled();
+    expect(component.html()).toContain('my bar value');
+  });
 });

src/plugins/discover/public/application/components/discover_grid/get_render_cell_value.tsx

@@ -93,17 +93,8 @@ export const getRenderCellValueFn =
         const displayKey = indexPattern.fields.getByName
           ? indexPattern.fields.getByName(key)?.displayName
           : undefined;
-        const formatter = subField
-          ? indexPattern.getFormatterForField(subField)
-          : { convert: (v: unknown, ...rest: unknown[]) => String(v) };
         const formatted = (values as unknown[])
-          .map((val: unknown) =>
-            formatter.convert(val, 'html', {
-              field: subField,
-              hit: row,
-              indexPattern,
-            })
-          )
+          .map((val: unknown) => formatFieldValue(val, row, indexPattern, subField))
           .join(', ');
         const pairs = highlights[key] ? highlightPairs : sourcePairs;
         if (displayKey) {