Skip to content

Commit 55a4861

Browse files
[Security Solution] remove donutChartEmbeddablesEnabled feature flag and related code (#240393)
## Summary This PR removes the `donutChartEmbeddablesEnabled` feature flag and its related code. This feature flag was last touched mid 2023 and hasn't seen any traction since. > [!IMPORTANT] > As the feature flag has been `false` for the last couple of years, no UI or behavior changes should be introduced by this PR! ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
1 parent 276694c commit 55a4861

File tree

12 files changed

+57
-533
lines changed

12 files changed

+57
-533
lines changed

x-pack/platform/plugins/private/translations/translations/de-DE.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36668,7 +36668,6 @@
3666836668
"xpack.securitySolution.entityAnalytics.riskDashboard.viewAllLabel": "Alle anzeigen",
3666936669
"xpack.securitySolution.entityAnalytics.riskEngine.missingIndexPrivilege": "Fehlende Indexberechtigungen für den Index \"{indexName}\": {privileges}.",
3667036670
"xpack.securitySolution.entityAnalytics.riskEngine.unauthorized": "Dem Nutzer fehlen die Berechtigungen für die Risiko-Engine.",
36671-
"xpack.securitySolution.entityAnalytics.riskScore.chart.totalLabel": "Gesamt",
3667236671
"xpack.securitySolution.entityAnalytics.riskScore.donut_chart.totalLabel": "Gesamt",
3667336672
"xpack.securitySolution.entityAnalytics.usersRiskDashboard.title": "{entityType} Risiko-Scores",
3667436673
"xpack.securitySolution.entityDetails.userPanel.error": "Bei der Berechnung des Risiko-Score für {entity} ist ein Problem aufgetreten",

x-pack/platform/plugins/private/translations/translations/fr-FR.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36887,7 +36887,6 @@
3688736887
"xpack.securitySolution.entityAnalytics.riskDashboard.viewAllLabel": "Afficher tout",
3688836888
"xpack.securitySolution.entityAnalytics.riskEngine.missingIndexPrivilege": "Privilèges d'index manquants pour l'index \"{indexName}\" : {privileges}.",
3688936889
"xpack.securitySolution.entityAnalytics.riskEngine.unauthorized": "L'utilisateur ne dispose pas des privilèges requis pour modifier le moteur de risque.",
36890-
"xpack.securitySolution.entityAnalytics.riskScore.chart.totalLabel": "Total",
3689136890
"xpack.securitySolution.entityAnalytics.riskScore.donut_chart.totalLabel": "Total",
3689236891
"xpack.securitySolution.entityAnalytics.usersRiskDashboard.title": "Scores de risque de {entityType}",
3689336892
"xpack.securitySolution.entityDetails.userPanel.error": "Une erreur a été rencontrée lors du calcul du score de risque de {entity}",

x-pack/platform/plugins/private/translations/translations/ja-JP.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36927,7 +36927,6 @@
3692736927
"xpack.securitySolution.entityAnalytics.riskDashboard.viewAllLabel": "すべて表示",
3692836928
"xpack.securitySolution.entityAnalytics.riskEngine.missingIndexPrivilege": "インデックス\"{indexName}\"のインデックス権限が不足しています:{privileges}。",
3692936929
"xpack.securitySolution.entityAnalytics.riskEngine.unauthorized": "ユーザーにはリスクエンジン権限がありません。",
36930-
"xpack.securitySolution.entityAnalytics.riskScore.chart.totalLabel": "合計",
3693136930
"xpack.securitySolution.entityAnalytics.riskScore.donut_chart.totalLabel": "合計",
3693236931
"xpack.securitySolution.entityAnalytics.usersRiskDashboard.title": "{entityType}リスクスコア",
3693336932
"xpack.securitySolution.entityDetails.userPanel.error": "{entity}リスクスコアの計算中に問題が発生しました",

x-pack/platform/plugins/private/translations/translations/zh-CN.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36911,7 +36911,6 @@
3691136911
"xpack.securitySolution.entityAnalytics.riskDashboard.viewAllLabel": "查看全部",
3691236912
"xpack.securitySolution.entityAnalytics.riskEngine.missingIndexPrivilege": "缺少索引“{indexName}”的索引权限:{privileges}。",
3691336913
"xpack.securitySolution.entityAnalytics.riskEngine.unauthorized": "用户缺少风险引擎权限。",
36914-
"xpack.securitySolution.entityAnalytics.riskScore.chart.totalLabel": "合计",
3691536914
"xpack.securitySolution.entityAnalytics.riskScore.donut_chart.totalLabel": "合计",
3691636915
"xpack.securitySolution.entityAnalytics.usersRiskDashboard.title": "{entityType} 风险分数",
3691736916
"xpack.securitySolution.entityDetails.userPanel.error": "计算 {entity} 风险分数时出现问题",

x-pack/solutions/security/plugins/security_solution/common/experimental_features.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ export type ExperimentalFeatures = { [K in keyof typeof allowedExperimentalValue
1212
* This object is then used to validate and parse the value entered.
1313
*/
1414
export const allowedExperimentalValues = Object.freeze({
15-
donutChartEmbeddablesEnabled: false, // Depends on https://github.com/elastic/kibana/issues/136409 item 2 - 6
16-
1715
/**
1816
* This is used for enabling the end-to-end tests for the security_solution telemetry.
1917
* We disable the telemetry since we don't have specific roles or permissions around it and

x-pack/solutions/security/plugins/security_solution/public/entity_analytics/components/entity_analytics_risk_score/chart_content.test.tsx

Lines changed: 0 additions & 95 deletions
This file was deleted.

x-pack/solutions/security/plugins/security_solution/public/entity_analytics/components/entity_analytics_risk_score/chart_content.tsx

Lines changed: 0 additions & 78 deletions
This file was deleted.

x-pack/solutions/security/plugins/security_solution/public/entity_analytics/components/entity_analytics_risk_score/index.tsx

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import { EuiFlexGroup, EuiFlexItem, EuiPanel } from '@elastic/eui';
99

1010
import { useExpandableFlyoutApi } from '@kbn/expandable-flyout';
1111
import type { RiskSeverity } from '../../../../common/search_strategy';
12+
import { EMPTY_SEVERITY_COUNT } from '../../../../common/search_strategy';
1213
import { useQueryInspector } from '../../../common/components/page/manage_query';
1314
import {
1415
EntityPanelKeyByType,
@@ -31,7 +32,6 @@ import { Loader } from '../../../common/components/loader';
3132
import { Panel } from '../../../common/components/panel';
3233
import { useEntityInfo } from './use_entity';
3334
import { RiskScoreHeaderContent } from './header_content';
34-
import { ChartContent } from './chart_content';
3535
import { useNavigateToAlertsPageWithFilters } from '../../../common/hooks/use_navigate_to_alerts_page_with_filters';
3636
import { getRiskEntityTranslation } from './translations';
3737
import { useKibana } from '../../../common/lib/kibana';
@@ -43,6 +43,7 @@ import { useMissingRiskEnginePrivileges } from '../../hooks/use_missing_risk_eng
4343
import { EntityEventTypes } from '../../../common/lib/telemetry';
4444
import { RiskScoresNoDataDetected } from '../risk_score_no_data_detected';
4545
import { RiskScoreHeaderTitle } from '../risk_score_header_title';
46+
import { RiskScoreDonutChart } from '../risk_score_donut_chart';
4647

4748
export const ENTITY_RISK_SCORE_TABLE_ID = 'entity-risk-score-table';
4849

@@ -220,14 +221,7 @@ const EntityAnalyticsRiskScoresComponent = <T extends EntityType>({
220221
{toggleStatus && (
221222
<EuiFlexGroup data-test-subj="entity_analytics_content">
222223
<EuiFlexItem grow={false}>
223-
<ChartContent
224-
dataExists={data && data.length > 0}
225-
kpiQueryId={entity.kpiQueryId ?? ''}
226-
riskEntity={riskEntity}
227-
severityCount={severityCount}
228-
timerange={timerange}
229-
selectedSeverity={selectedSeverity}
230-
/>
224+
<RiskScoreDonutChart severityCount={severityCount ?? EMPTY_SEVERITY_COUNT} />
231225
</EuiFlexItem>
232226
<EuiFlexItem>
233227
<StyledBasicTable

0 commit comments

Comments
 (0)