[ML] Making update space APIs public (#241109)

The `ml/saved_objects/update_jobs_spaces` and
`ml/saved_objects/update_trained_models_spaces` APIs can be made public
to allow users to change the spaces for a trained model or AD and DFA
job.

To avoid issues with rolling upgrades, this PR creates a new copy of
each endpoint server side. The original internal endpoints can be remove
once we're happy serverless users have all upgraded both server and
client side.

Author: jgowdyelastic

x-pack/platform/plugins/shared/ml/public/application/services/ml_api_service/saved_objects.ts

@@ -42,7 +42,7 @@ export const savedObjectsApiProvider = (httpService: HttpService) => ({
   ) {
     const body = JSON.stringify({ jobType, jobIds, spacesToAdd, spacesToRemove });
     return httpService.http<SavedObjectResult>({
-      path: `${ML_INTERNAL_BASE_PATH}/saved_objects/update_jobs_spaces`,
+      path: `${ML_EXTERNAL_BASE_PATH}/saved_objects/update_jobs_spaces`,
       method: 'POST',
       body,
       version: '1',
@@ -110,7 +110,7 @@ export const savedObjectsApiProvider = (httpService: HttpService) => ({
   updateModelsSpaces(modelIds: string[], spacesToAdd: string[], spacesToRemove: string[]) {
     const body = JSON.stringify({ modelIds, spacesToAdd, spacesToRemove });
     return httpService.http<SavedObjectResult>({
-      path: `${ML_INTERNAL_BASE_PATH}/saved_objects/update_trained_models_spaces`,
+      path: `${ML_EXTERNAL_BASE_PATH}/saved_objects/update_trained_models_spaces`,
       method: 'POST',
       body,
       version: '1',

x-pack/platform/plugins/shared/ml/server/routes/saved_objects.ts

@@ -232,6 +232,47 @@ export function savedObjectsRoutes(
       })
     );
 
+  router.versioned
+    .post({
+      path: `${ML_EXTERNAL_BASE_PATH}/saved_objects/update_jobs_spaces`,
+      access: 'internal',
+      security: {
+        authz: {
+          requiredPrivileges: ['ml:canCreateJob', 'ml:canCreateDataFrameAnalytics'],
+        },
+      },
+      summary: 'Update what spaces jobs are assigned to',
+      description: 'Update a list of jobs to add and/or remove them from given spaces.',
+    })
+    .addVersion(
+      {
+        version: '1',
+        validate: {
+          request: {
+            body: updateJobsSpaces,
+          },
+        },
+      },
+      routeGuard.fullLicenseAPIGuard(async ({ request, response, mlSavedObjectService }) => {
+        try {
+          const { jobType, jobIds, spacesToAdd, spacesToRemove } = request.body;
+
+          const body = await mlSavedObjectService.updateJobsSpaces(
+            jobType,
+            jobIds,
+            spacesToAdd,
+            spacesToRemove
+          );
+
+          return response.ok({
+            body,
+          });
+        } catch (e) {
+          return response.customError(wrapError(e));
+        }
+      })
+    );
+
   router.versioned
     .post({
       path: `${ML_INTERNAL_BASE_PATH}/saved_objects/update_trained_models_spaces`,
@@ -272,6 +313,46 @@ export function savedObjectsRoutes(
       })
     );
 
+  router.versioned
+    .post({
+      path: `${ML_EXTERNAL_BASE_PATH}/saved_objects/update_trained_models_spaces`,
+      access: 'internal',
+      security: {
+        authz: {
+          requiredPrivileges: ['ml:canCreateTrainedModels'],
+        },
+      },
+      summary: 'Update what spaces trained models are assigned to',
+      description: 'Update a list of trained models to add and/or remove them from given spaces.',
+    })
+    .addVersion(
+      {
+        version: '1',
+        validate: {
+          request: {
+            body: updateTrainedModelsSpaces,
+          },
+        },
+      },
+      routeGuard.fullLicenseAPIGuard(async ({ request, response, mlSavedObjectService }) => {
+        try {
+          const { modelIds, spacesToAdd, spacesToRemove } = request.body;
+
+          const body = await mlSavedObjectService.updateTrainedModelsSpaces(
+            modelIds,
+            spacesToAdd,
+            spacesToRemove
+          );
+
+          return response.ok({
+            body,
+          });
+        } catch (e) {
+          return response.customError(wrapError(e));
+        }
+      })
+    );
+
   router.versioned
     .post({
       path: `${ML_INTERNAL_BASE_PATH}/saved_objects/remove_item_from_current_space`,

x-pack/platform/test/api_integration/apis/ml/saved_objects/update_jobs_spaces.ts

@@ -34,7 +34,7 @@ export default ({ getService }: FtrProviderContext) => {
     user: USER
   ) {
     const { body, status } = await supertest
-      .post(`/internal/ml/saved_objects/update_jobs_spaces`)
+      .post(`/api/ml/saved_objects/update_jobs_spaces`)
       .auth(user, ml.securityCommon.getPasswordForUser(user))
       .set(getCommonRequestHeader('1'))
       .send(requestBody);

x-pack/platform/test/api_integration/apis/ml/saved_objects/update_trained_model_spaces.ts

@@ -30,7 +30,7 @@ export default ({ getService }: FtrProviderContext) => {
     user: USER
   ) {
     const { body, status } = await supertest
-      .post(`/internal/ml/saved_objects/update_trained_models_spaces`)
+      .post(`/api/ml/saved_objects/update_trained_models_spaces`)
       .auth(user, ml.securityCommon.getPasswordForUser(user))
       .set(getCommonRequestHeader('1'))
       .send(requestBody);

x-pack/platform/test/api_integration/services/ml/api.ts

@@ -1411,7 +1411,7 @@ export function MachineLearningAPIProvider({ getService }: FtrProviderContext) {
       space?: string
     ) {
       const { body, status } = await kbnSupertest
-        .post(`${space ? `/s/${space}` : ''}/internal/ml/saved_objects/update_jobs_spaces`)
+        .post(`${space ? `/s/${space}` : ''}/api/ml/saved_objects/update_jobs_spaces`)
         .set(getCommonRequestHeader('1'))
         .send({ jobType, jobIds: [jobId], spacesToAdd, spacesToRemove });
       this.assertResponseStatusCode(200, status, body);
@@ -1446,9 +1446,7 @@ export function MachineLearningAPIProvider({ getService }: FtrProviderContext) {
       space?: string
     ) {
       const { body, status } = await kbnSupertest
-        .post(
-          `${space ? `/s/${space}` : ''}/internal/ml/saved_objects/update_trained_models_spaces`
-        )
+        .post(`${space ? `/s/${space}` : ''}/api/ml/saved_objects/update_trained_models_spaces`)
         .set(getCommonRequestHeader('1'))
         .send({ modelIds: [modelId], spacesToAdd, spacesToRemove });
       this.assertResponseStatusCode(200, status, body);

x-pack/platform/test/functional/services/ml/api.ts

@@ -1411,7 +1411,7 @@ export function MachineLearningAPIProvider({ getService }: FtrProviderContext) {
       space?: string
     ) {
       const { body, status } = await kbnSupertest
-        .post(`${space ? `/s/${space}` : ''}/internal/ml/saved_objects/update_jobs_spaces`)
+        .post(`${space ? `/s/${space}` : ''}/api/ml/saved_objects/update_jobs_spaces`)
         .set(getCommonRequestHeader('1'))
         .send({ jobType, jobIds: [jobId], spacesToAdd, spacesToRemove });
       this.assertResponseStatusCode(200, status, body);
@@ -1446,9 +1446,7 @@ export function MachineLearningAPIProvider({ getService }: FtrProviderContext) {
       space?: string
     ) {
       const { body, status } = await kbnSupertest
-        .post(
-          `${space ? `/s/${space}` : ''}/internal/ml/saved_objects/update_trained_models_spaces`
-        )
+        .post(`${space ? `/s/${space}` : ''}/api/ml/saved_objects/update_trained_models_spaces`)
         .set(getCommonRequestHeader('1'))
         .send({ modelIds: [modelId], spacesToAdd, spacesToRemove });
       this.assertResponseStatusCode(200, status, body);