[One Workflow] fix: step actions bug (#236769)

## Summary

Closes: elastic/security-team#14052



https://github.com/user-attachments/assets/49389cbd-24d7-49e5-9d34-82754369dfa2


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Sergi Massaneda <[email protected]>

Author: 3 people

src/platform/packages/shared/kbn-workflows/graph/workflow_graph/workflow_graph.ts

@@ -7,6 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
+import type { GraphEdge } from '@dagrejs/dagre';
 import { graphlib } from '@dagrejs/dagre';
 import type { GraphNodeUnion } from '../types';
 import { convertToWorkflowGraph } from '../build_execution_graph/build_execution_graph';
@@ -74,6 +75,10 @@ export class WorkflowGraph {
     return this.graph.edges().map((edge) => ({ v: edge.v, w: edge.w }));
   }
 
+  public getEdge(edgeMetadata: { v: string; w: string }): GraphEdge {
+    return this.graph.edge(edgeMetadata);
+  }
+
   public hasStep(stepId: string): boolean {
     if (!this.stepIdsSet) {
       this.stepIdsSet = new Set(this.getAllNodes().map((node) => node.stepId));

src/platform/plugins/shared/workflows_management/public/features/debug-graph/execution_graph.tsx

@@ -7,18 +7,18 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import React, { useEffect, useMemo } from 'react';
-import { convertToWorkflowGraph } from '@kbn/workflows/graph';
+import React, { useMemo } from 'react';
 import type { NodeTypes, Node } from '@xyflow/react';
 import { Background, Controls, ReactFlow } from '@xyflow/react';
 import { useEuiTheme } from '@elastic/eui';
-import { getWorkflowZodSchemaLoose } from '../../../common/schema';
-import { parseWorkflowYamlToJSON } from '../../../common/lib/yaml_utils';
+import { useSelector } from 'react-redux';
+
 import { ExecutionGraphEdge, ExecutionGraphNode } from './nodes';
 import { convertWorkflowGraphToReactFlow } from './workflow_graph_layout';
 import { mainScopeNodes, secondaryScopeNodes, atomicNodes } from './nodes/types';
 
 import '@xyflow/react/dist/style.css';
+import { selectWorkflowGraph } from '../../widgets/workflow_yaml_editor/lib/store';
 
 export interface ExecutionGraphProps {
   workflowYaml: string | undefined;
@@ -82,57 +82,22 @@ const ReactFlowWrapper: React.FC<{
 
 export const ExecutionGraph: React.FC<ExecutionGraphProps> = ({ workflowYaml }) => {
   const { euiTheme } = useEuiTheme();
-  const [debouncedWorkflowYaml, setDebouncedWorkflowYaml] = React.useState(workflowYaml);
-
-  useEffect(() => {
-    const handler = setTimeout(() => {
-      setDebouncedWorkflowYaml(workflowYaml);
-    }, 500);
-    return () => {
-      clearTimeout(handler);
-    };
-  }, [workflowYaml]);
-
-  const workflowExecutionGraph: { result: any; error: any } | null = useMemo(() => {
-    if (!debouncedWorkflowYaml) {
-      return null;
-    }
-    let result = null;
-    let error = null;
-    try {
-      const parsingResult = parseWorkflowYamlToJSON(
-        debouncedWorkflowYaml,
-        getWorkflowZodSchemaLoose()
-      );
-      if (parsingResult.error) {
-        error = parsingResult.error;
-      }
-      result = convertToWorkflowGraph((parsingResult as { data: any }).data);
-    } catch (e) {
-      error = e;
-    }
-
-    return { result, error };
-  }, [debouncedWorkflowYaml]);
+  const workflowGraph = useSelector(selectWorkflowGraph);
 
   const layoutResult: { result: any; error: string } | null = useMemo(() => {
-    if (!workflowExecutionGraph) {
+    if (!workflowGraph) {
       return null;
     }
 
-    if (workflowExecutionGraph.error) {
-      return { result: null, error: workflowExecutionGraph.error };
-    }
-
     let result = null;
     let error = null;
     try {
-      result = convertWorkflowGraphToReactFlow(workflowExecutionGraph.result);
+      result = convertWorkflowGraphToReactFlow(workflowGraph);
     } catch (e) {
       error = e.message;
     }
     return { result, error };
-  }, [workflowExecutionGraph]);
+  }, [workflowGraph]);
 
   return (
     <>

src/platform/plugins/shared/workflows_management/public/features/debug-graph/workflow_graph_layout.ts

@@ -10,15 +10,16 @@
 import dagre from '@dagrejs/dagre';
 import type { Node } from '@xyflow/react';
 import { Position } from '@xyflow/react';
+import type { WorkflowGraph } from '@kbn/workflows/graph';
 
 /**
  * Converts a workflow graph into positioned ReactFlow nodes and edges using Dagre layout algorithm.
  *
  * @param graph - The dagre graph representation of the workflow
  * @returns Object containing positioned nodes and edges for ReactFlow
  */
-export function convertWorkflowGraphToReactFlow(graph: dagre.graphlib.Graph) {
-  const topologySort = dagre.graphlib.alg.topsort(graph);
+export function convertWorkflowGraphToReactFlow(graph: WorkflowGraph) {
+  const topologySort = graph.topologicalOrder;
   const dagreGraph = new dagre.graphlib.Graph();
   dagreGraph.setGraph({});
   dagreGraph.setDefaultEdgeLabel(() => ({}));
@@ -38,7 +39,7 @@ export function convertWorkflowGraphToReactFlow(graph: dagre.graphlib.Graph) {
   let maxDepth = 0;
 
   topologySort
-    .map((nodeId) => graph.node(nodeId))
+    .map((nodeId) => graph.getNode(nodeId))
     .forEach((node: any) => {
       if (node.type.startsWith('exit')) {
         stack.pop();
@@ -70,7 +71,7 @@ export function convertWorkflowGraphToReactFlow(graph: dagre.graphlib.Graph) {
       })
     );
 
-  graph.edges().forEach((edge) => {
+  graph.getEdges().forEach((edge) => {
     // Reverse source and destination for BT layout
     dagreGraph.setEdge(edge.w, edge.v, {
       type: 'workflowEdge',
@@ -79,16 +80,16 @@ export function convertWorkflowGraphToReactFlow(graph: dagre.graphlib.Graph) {
 
   dagre.layout(dagreGraph);
 
-  const nodes = graph.nodes().map((id) => {
-    const dagreNode = dagreGraph.node(id);
-    const graphNode = graph.node(id) as any;
+  const nodes = graph.getAllNodes().map((graphNode) => {
+    const dagreNode = dagreGraph.node(graphNode.id);
+
     return {
-      id,
+      id: graphNode.id,
       data: {
         ...dagreNode,
         stepType: graphNode?.type,
-        step: graphNode?.configuration,
-        label: graphNode?.label || id,
+        step: (graphNode as any)?.configuration,
+        label: graphNode?.id,
       },
       // See this: https://github.com/dagrejs/dagre/issues/287
       targetPosition: Position.Bottom, // Reversed due to BT layout
@@ -102,11 +103,11 @@ export function convertWorkflowGraphToReactFlow(graph: dagre.graphlib.Graph) {
     } as Node;
   });
 
-  const edges = graph.edges().map((e) => ({
+  const edges = graph.getEdges().map((e) => ({
     id: `${e.v} -> ${e.w}`,
     source: e.v,
     target: e.w,
-    label: graph.edge(e)?.label,
+    label: graph.getEdge(e)?.label,
   }));
 
   return { nodes, edges };

src/platform/plugins/shared/workflows_management/public/pages/workflow_detail/ui/workflow_detail_page.tsx

@@ -25,6 +25,7 @@ import { WorkflowDetailHeader } from './workflow_detail_header';
 import { WorkflowEditor } from './workflow_editor';
 import { WorkflowEditorLayout } from './workflow_detail_layout';
 import { getWorkflowZodSchemaLoose } from '../../../../common/schema';
+import { WorkflowEditorStoreProvider } from '../../../widgets/workflow_yaml_editor/lib/store';
 
 export function WorkflowDetailPage({ id }: { id: string }) {
   const { application, notifications } = useKibana().services;
@@ -244,74 +245,76 @@ export function WorkflowDetailPage({ id }: { id: string }) {
   }
 
   return (
-    <EuiFlexGroup gutterSize="none" style={{ height: '100%' }}>
-      <EuiFlexItem style={{ overflow: 'hidden' }}>
-        <WorkflowDetailHeader
-          name={workflow?.name}
-          isLoading={isLoadingWorkflow}
-          activeTab={activeTab}
-          canRunWorkflow={canRunWorkflow}
-          canSaveWorkflow={canSaveWorkflow}
-          isValid={workflow?.valid ?? true}
-          isEnabled={workflow?.enabled ?? false}
-          handleRunClick={() => handleRunClick({ test: false })}
-          handleSave={handleSave}
-          handleToggleWorkflow={handleToggleWorkflow}
-          canTestWorkflow={canTestWorkflow}
-          handleTestClick={() => handleRunClick({ test: true })}
-          handleTabChange={setActiveTab}
-          hasUnsavedChanges={hasChanges}
-          highlightDiff={highlightDiff}
-          setHighlightDiff={setHighlightDiff}
-          lastUpdatedAt={workflow?.lastUpdatedAt ?? null}
-        />
-        <WorkflowEditorLayout
-          editor={
-            <WorkflowEditor
-              workflow={workflow}
-              workflowYaml={yamlValue}
-              onWorkflowYamlChange={handleChange}
-              hasChanges={hasChanges}
-              execution={execution}
-              activeTab={activeTab}
-              selectedExecutionId={selectedExecutionId}
-              selectedStepId={selectedStepId}
-              highlightDiff={highlightDiff}
-              setSelectedExecution={setSelectedExecution}
-            />
-          }
-          executionList={
-            activeTab === 'executions' && workflow && !selectedExecutionId ? (
-              <WorkflowExecutionList workflowId={workflow?.id ?? null} />
-            ) : null
-          }
-          executionDetail={
-            workflow && selectedExecutionId ? (
-              <WorkflowExecutionDetail
-                workflowExecutionId={selectedExecutionId}
+    <WorkflowEditorStoreProvider>
+      <EuiFlexGroup gutterSize="none" style={{ height: '100%' }}>
+        <EuiFlexItem style={{ overflow: 'hidden' }}>
+          <WorkflowDetailHeader
+            name={workflow?.name}
+            isLoading={isLoadingWorkflow}
+            activeTab={activeTab}
+            canRunWorkflow={canRunWorkflow}
+            canSaveWorkflow={canSaveWorkflow}
+            isValid={workflow?.valid ?? true}
+            isEnabled={workflow?.enabled ?? false}
+            handleRunClick={() => handleRunClick({ test: false })}
+            handleSave={handleSave}
+            handleToggleWorkflow={handleToggleWorkflow}
+            canTestWorkflow={canTestWorkflow}
+            handleTestClick={() => handleRunClick({ test: true })}
+            handleTabChange={setActiveTab}
+            hasUnsavedChanges={hasChanges}
+            highlightDiff={highlightDiff}
+            setHighlightDiff={setHighlightDiff}
+            lastUpdatedAt={workflow?.lastUpdatedAt ?? null}
+          />
+          <WorkflowEditorLayout
+            editor={
+              <WorkflowEditor
+                workflow={workflow}
                 workflowYaml={yamlValue}
-                showBackButton={activeTab === 'executions'}
-                onClose={() => setSelectedExecution(null)}
+                onWorkflowYamlChange={handleChange}
+                hasChanges={hasChanges}
+                execution={execution}
+                activeTab={activeTab}
+                selectedExecutionId={selectedExecutionId}
+                selectedStepId={selectedStepId}
+                highlightDiff={highlightDiff}
+                setSelectedExecution={setSelectedExecution}
               />
-            ) : null
-          }
-        />
-      </EuiFlexItem>
+            }
+            executionList={
+              activeTab === 'executions' && workflow && !selectedExecutionId ? (
+                <WorkflowExecutionList workflowId={workflow?.id ?? null} />
+              ) : null
+            }
+            executionDetail={
+              workflow && selectedExecutionId ? (
+                <WorkflowExecutionDetail
+                  workflowExecutionId={selectedExecutionId}
+                  workflowYaml={yamlValue}
+                  showBackButton={activeTab === 'executions'}
+                  onClose={() => setSelectedExecution(null)}
+                />
+              ) : null
+            }
+          />
+        </EuiFlexItem>
 
-      {workflowExecuteModalOpen && workflow && (
-        <WorkflowExecuteModal
-          definition={workflow.definition}
-          onClose={() => setWorkflowExecuteModalOpen(false)}
-          onSubmit={handleRunWorkflow}
-        />
-      )}
-      {testWorkflowModalOpen && definitionFromCurrentYaml && (
-        <WorkflowExecuteModal
-          definition={definitionFromCurrentYaml}
-          onClose={() => setTestWorkflowModalOpen(false)}
-          onSubmit={handleTestRunWorkflow}
-        />
-      )}
-    </EuiFlexGroup>
+        {workflowExecuteModalOpen && workflow && (
+          <WorkflowExecuteModal
+            definition={workflow.definition}
+            onClose={() => setWorkflowExecuteModalOpen(false)}
+            onSubmit={handleRunWorkflow}
+          />
+        )}
+        {testWorkflowModalOpen && definitionFromCurrentYaml && (
+          <WorkflowExecuteModal
+            definition={definitionFromCurrentYaml}
+            onClose={() => setTestWorkflowModalOpen(false)}
+            onSubmit={handleTestRunWorkflow}
+          />
+        )}
+      </EuiFlexGroup>
+    </WorkflowEditorStoreProvider>
   );
 }

src/platform/plugins/shared/workflows_management/public/widgets/workflow_yaml_editor/lib/hooks/index.ts

@@ -0,0 +1,11 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the "Elastic License
+ * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+ * Public License v 1"; you may not use this file except in compliance with, at
+ * your election, the "Elastic License 2.0", the "GNU Affero General Public
+ * License v3.0 only", or the "Server Side Public License, v 1".
+ */
+
+export { useFocusedStepOutline } from './use_focused_step_outline';
+export { useStepDecorationsInExecution } from './use_step_decorations_in_execution';