[8.19] [AI Assistant] Fix some OpenAI models not accepting temperature for Inference service (#218887) (#219962)

qn895 · elasticmachine · web-flow · commit 84e552b731e6 · 2025-05-06T09:14:10.000+01:00
# Backport This will backport the following commits from `main` to `8.19`: - [[AI Assistant] Fix some OpenAI models not accepting temperature for Inference service (#218887)](#218887)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
diff --git a/x-pack/platform/plugins/shared/inference/server/chat_complete/adapters/inference/create_openai_request.ts b/x-pack/platform/plugins/shared/inference/server/chat_complete/adapters/inference/create_openai_request.ts
@@ -10,6 +10,7 @@ import { OpenAIRequest } from '../openai/types';
 import { messagesToOpenAI, toolChoiceToOpenAI, toolsToOpenAI } from '../openai';
 import type { CreateOpenAIRequestOptions } from './types';
 import { applyProviderTransforms } from './providers';
+import { getTemperatureIfValid } from '../../utils/get_temperature';
 
 export const createRequest = (options: CreateOpenAIRequestOptions): OpenAIRequest => {
   const {
@@ -31,13 +32,13 @@ export const createRequest = (options: CreateOpenAIRequestOptions): OpenAIReques
       tools,
     });
     request = {
-      temperature,
+      ...getTemperatureIfValid(temperature, { connector: options.connector, modelName }),
       model: modelName,
       messages: messagesToOpenAI({ system: wrapped.system, messages: wrapped.messages }),
     };
   } else {
     request = {
-      temperature,
+      ...getTemperatureIfValid(temperature, { connector: options.connector, modelName }),
       model: modelName,
       messages: messagesToOpenAI({ system, messages }),
       tool_choice: toolChoiceToOpenAI(toolChoice),
diff --git a/x-pack/platform/plugins/shared/inference/server/chat_complete/adapters/openai/openai_adapter.ts b/x-pack/platform/plugins/shared/inference/server/chat_complete/adapters/openai/openai_adapter.ts
@@ -17,6 +17,7 @@ import type { OpenAIRequest } from './types';
 import { messagesToOpenAI, toolsToOpenAI, toolChoiceToOpenAI } from './to_openai';
 import { processOpenAIStream } from './process_openai_stream';
 import { emitTokenCountEstimateIfMissing } from './emit_token_count_if_missing';
+import { getTemperatureIfValid } from '../../utils/get_temperature';
 
 export const openAIAdapter: InferenceConnectorAdapter = {
   chatComplete: ({
@@ -27,17 +28,19 @@ export const openAIAdapter: InferenceConnectorAdapter = {
     tools,
     temperature = 0,
     functionCalling = 'auto',
-    modelName,
+    modelName: modelName,
     logger,
     abortSignal,
     metadata,
   }) => {
+    const connector = executor.getConnector();
     const useSimulatedFunctionCalling =
       functionCalling === 'auto'
         ? !isNativeFunctionCallingSupported(executor.getConnector())
         : functionCalling === 'simulated';
 
     let request: OpenAIRequest;
+
     if (useSimulatedFunctionCalling) {
       const wrapped = wrapWithSimulatedFunctionCalling({
         system,
@@ -47,14 +50,14 @@ export const openAIAdapter: InferenceConnectorAdapter = {
       });
       request = {
         stream: true,
-        temperature,
+        ...getTemperatureIfValid(temperature, { connector, modelName }),
         model: modelName,
         messages: messagesToOpenAI({ system: wrapped.system, messages: wrapped.messages }),
       };
     } else {
       request = {
         stream: true,
-        temperature,
+        ...getTemperatureIfValid(temperature, { connector, modelName }),
         model: modelName,
         messages: messagesToOpenAI({ system, messages }),
         tool_choice: toolChoiceToOpenAI(toolChoice),
diff --git a/x-pack/platform/plugins/shared/inference/server/chat_complete/utils/get_temperature.test.ts b/x-pack/platform/plugins/shared/inference/server/chat_complete/utils/get_temperature.test.ts
@@ -0,0 +1,53 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+import { getTemperatureIfValid } from './get_temperature';
+import { InferenceConnector, InferenceConnectorType } from '@kbn/inference-common';
+
+const OPENAI_CONNECTOR = { type: InferenceConnectorType.OpenAI } as InferenceConnector;
+const GEMINI_CONNECTOR = { type: InferenceConnectorType.Gemini } as InferenceConnector;
+describe('getTemperatureIfValid', () => {
+  it('returns an empty object if temperature is undefined', () => {
+    expect(
+      getTemperatureIfValid(undefined, { connector: OPENAI_CONNECTOR, modelName: 'gpt-3.5-turbo' })
+    ).toEqual({});
+  });
+
+  it('returns an object with temperature if OpenAI model accepts', () => {
+    expect(
+      getTemperatureIfValid(0.7, { connector: OPENAI_CONNECTOR, modelName: 'gpt-3.5-turbo' })
+    ).toEqual({
+      temperature: 0.7,
+    });
+    expect(
+      getTemperatureIfValid(0.7, {
+        connector: OPENAI_CONNECTOR,
+        modelName: 'gpt-fake-o1',
+      })
+    ).toEqual({
+      temperature: 0.7,
+    });
+  });
+
+  it('returns an object with temperature if not OpenAI connector', () => {
+    expect(
+      getTemperatureIfValid(0.7, {
+        connector: GEMINI_CONNECTOR,
+        modelName: 'gemma',
+      })
+    ).toEqual({
+      temperature: 0.7,
+    });
+  });
+
+  it("returns an empty object for OpenAI models that don't support temperature", () => {
+    ['o1', 'o1-pro', 'o3', 'o1-mini', 'o3-mini'].forEach((model) => {
+      expect(getTemperatureIfValid(0.7, { connector: OPENAI_CONNECTOR, modelName: model })).toEqual(
+        {}
+      );
+    });
+  });
+});
diff --git a/x-pack/platform/plugins/shared/inference/server/chat_complete/utils/get_temperature.ts b/x-pack/platform/plugins/shared/inference/server/chat_complete/utils/get_temperature.ts
@@ -0,0 +1,32 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+import { InferenceConnector, InferenceConnectorType } from '@kbn/inference-common';
+
+const OPENAI_MODELS_WITHOUT_TEMPERATURE = ['o1', 'o3'];
+
+export const getTemperatureIfValid = (
+  temperature?: number,
+  { connector, modelName }: { connector?: InferenceConnector; modelName?: string } = {}
+) => {
+  if (temperature === undefined) return {};
+
+  const model =
+    modelName ?? connector?.config?.providerConfig?.model_id ?? connector?.config?.defaultModel;
+
+  if (
+    (connector?.type === InferenceConnectorType.OpenAI ||
+      connector?.type === InferenceConnectorType.Inference) &&
+    model
+  ) {
+    const normalizedModelName = model.toLowerCase();
+    const shouldExcludeTemperature = OPENAI_MODELS_WITHOUT_TEMPERATURE.some((m) =>
+      normalizedModelName.startsWith(m)
+    );
+    return shouldExcludeTemperature ? {} : { temperature };
+  }
+  return { temperature };
+};
