Skip to content

Commit 8ae2af7

Browse files
tsullivanek-so
tsullivan
and
ek-so
authored
[8.19] Remapping iInCircle and questionInCircle and deprecating help icon (#223142) (#225535)
# Backport This will backport the following commits from `main` to `8.19`: - [Remapping `iInCircle` and `questionInCircle` and deprecating `help` icon (#223142)](#223142) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kate Sosedova","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-06-25T19:52:04Z","message":"Remapping `iInCircle` and `questionInCircle` and deprecating `help` icon (#223142)\n\n## Summary\n\nThis PR closes the issue https://github.com/elastic/kibana/issues/221380\nand does 3 things:\n1. Replaces all current usages of `iInCircle` with `info` (no visual\nchanges)\n2. Replaces all current usages of `questionInCircle` with `question`(no\nvisual changes)\n3. Replaces all current `help` icon usages with `question`(lifesaver\nicon replaced with question)\n\n## Screenshots:\n![CleanShot 2025-06-18 at 10 34\n01@2x](https://github.com/user-attachments/assets/4379e51e-7422-4570-b452-c17ee26f2d64)\n![CleanShot 2025-06-18 at 10 34\n13@2x](https://github.com/user-attachments/assets/270056c7-4502-47ef-874f-862149fa27ec)\n![CleanShot 2025-06-18 at 10 34\n04@2x](https://github.com/user-attachments/assets/1dff8faf-65b7-4208-b568-7718b1a6b729)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>\nCo-authored-by: Elastic Machine <[email protected]>\nCo-authored-by: Anton Dosov <[email protected]>","sha":"0d2125427f81d2ebedcf7377e6b97da78f1b3cf8","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Fleet","ci:project-deploy-observability","backport:version","v9.1.0","v8.19.0"],"title":"Remapping `iInCircle` and `questionInCircle` and deprecating `help` icon","number":223142,"url":"https://github.com/elastic/kibana/pull/223142","mergeCommit":{"message":"Remapping `iInCircle` and `questionInCircle` and deprecating `help` icon (#223142)\n\n## Summary\n\nThis PR closes the issue https://github.com/elastic/kibana/issues/221380\nand does 3 things:\n1. Replaces all current usages of `iInCircle` with `info` (no visual\nchanges)\n2. Replaces all current usages of `questionInCircle` with `question`(no\nvisual changes)\n3. Replaces all current `help` icon usages with `question`(lifesaver\nicon replaced with question)\n\n## Screenshots:\n![CleanShot 2025-06-18 at 10 34\n01@2x](https://github.com/user-attachments/assets/4379e51e-7422-4570-b452-c17ee26f2d64)\n![CleanShot 2025-06-18 at 10 34\n13@2x](https://github.com/user-attachments/assets/270056c7-4502-47ef-874f-862149fa27ec)\n![CleanShot 2025-06-18 at 10 34\n04@2x](https://github.com/user-attachments/assets/1dff8faf-65b7-4208-b568-7718b1a6b729)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>\nCo-authored-by: Elastic Machine <[email protected]>\nCo-authored-by: Anton Dosov <[email protected]>","sha":"0d2125427f81d2ebedcf7377e6b97da78f1b3cf8"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/223142","number":223142,"mergeCommit":{"message":"Remapping `iInCircle` and `questionInCircle` and deprecating `help` icon (#223142)\n\n## Summary\n\nThis PR closes the issue https://github.com/elastic/kibana/issues/221380\nand does 3 things:\n1. Replaces all current usages of `iInCircle` with `info` (no visual\nchanges)\n2. Replaces all current usages of `questionInCircle` with `question`(no\nvisual changes)\n3. Replaces all current `help` icon usages with `question`(lifesaver\nicon replaced with question)\n\n## Screenshots:\n![CleanShot 2025-06-18 at 10 34\n01@2x](https://github.com/user-attachments/assets/4379e51e-7422-4570-b452-c17ee26f2d64)\n![CleanShot 2025-06-18 at 10 34\n13@2x](https://github.com/user-attachments/assets/270056c7-4502-47ef-874f-862149fa27ec)\n![CleanShot 2025-06-18 at 10 34\n04@2x](https://github.com/user-attachments/assets/1dff8faf-65b7-4208-b568-7718b1a6b729)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>\nCo-authored-by: Elastic Machine <[email protected]>\nCo-authored-by: Anton Dosov <[email protected]>","sha":"0d2125427f81d2ebedcf7377e6b97da78f1b3cf8"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Kate Sosedova <[email protected]>
1 parent 69f15cb commit 8ae2af7

File tree

623 files changed

+1166
-1245
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

623 files changed

+1166
-1245
lines changed

‎examples/search_examples/public/search_sessions/app.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -791,7 +791,7 @@ function NoShardDelayCallout() {
791791
</>
792792
}
793793
color="warning"
794-
iconType="help"
794+
iconType="question"
795795
>
796796
<p>
797797
This demo works best with <EuiCode>shardDelay</EuiCode> aggregation which simulates slow
@@ -807,7 +807,7 @@ function NoShardDelayCallout() {
807807

808808
function NoDataViewsCallout() {
809809
return (
810-
<EuiCallOut title={<>Missing data views!</>} color="warning" iconType="help">
810+
<EuiCallOut title={<>Missing data views!</>} color="warning" iconType="question">
811811
<p>This demo requires at least one data view.</p>
812812
</EuiCallOut>
813813
);

‎src/core/packages/chrome/browser-internal/src/ui/header/__snapshots__/header.test.tsx.snap‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/core/packages/chrome/browser-internal/src/ui/header/header_help_menu.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ class HelpMenu extends Component<Props & WithEuiThemeProps, State> {
156156
})}
157157
onClick={this.onMenuButtonClick}
158158
>
159-
<EuiIcon type="help" size="m" />
159+
<EuiIcon type="question" size="m" />
160160
</EuiHeaderSectionItemButton>
161161
);
162162

‎src/core/packages/notifications/browser-internal/src/toasts/toasts_api.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export class ToastsApi implements IToasts {
124124
public addInfo(toastOrTitle: ToastInput, options?: ToastOptions) {
125125
return this.add({
126126
color: 'primary',
127-
iconType: 'iInCircle',
127+
iconType: 'info',
128128
...normalizeToast(toastOrTitle),
129129
...options,
130130
});

‎src/core/packages/overlays/browser-internal/src/banners/user_banner_service.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export class UserBannerService {
7474
defaultMessage="Attention"
7575
/>
7676
}
77-
iconType="help"
77+
iconType="question"
7878
>
7979
<React.Suspense
8080
fallback={

‎src/platform/packages/shared/cloud/connection_details/tabs/api_keys_tab/views/missing_permissions_panel.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export const MissingPermissionsPanel: React.FC = () => {
1717
<>
1818
<EuiCallOut
1919
color={'warning'}
20-
iconType={'iInCircle'}
20+
iconType={'info'}
2121
title={i18n.translate('cloud.connectionDetails.tabs.apiKeys.missingPermPanel.title', {
2222
defaultMessage: 'Missing permissions',
2323
})}

‎src/platform/packages/shared/cloud/connection_details/tabs/endpoints_tab/rows/cloud_id_row/label.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export const Label: React.FC<{ learnMoreUrl?: string }> = ({ learnMoreUrl }) =>
4141
<EuiPopover
4242
button={
4343
<EuiButtonIcon
44-
iconType="questionInCircle"
44+
iconType="question"
4545
onClick={() => {
4646
setIsPopoverOpen((x) => !x);
4747
}}

‎src/platform/packages/shared/cloud/deployment_details/deployment_details_cloudid_input.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ const Label: FC<{ learnMoreUrl: string }> = ({ learnMoreUrl }) => {
4646
<EuiPopover
4747
button={
4848
<EuiButtonIcon
49-
iconType="questionInCircle"
49+
iconType="question"
5050
onClick={() => {
5151
setIsPopoverOpen(true);
5252
}}

‎src/platform/packages/shared/content-management/content_editor/src/components/editor_flyout_content.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ export const ContentEditorFlyoutContent: FC<Props> = ({
148148
<EuiFlyoutHeader>
149149
<EuiTitle data-test-subj="flyoutTitle">
150150
<h2>
151-
<EuiIcon type="iInCircle" css={iconCSS} size="l" />
151+
<EuiIcon type="info" css={iconCSS} size="l" />
152152
<span>{title}</span>
153153
</h2>
154154
</EuiTitle>

‎src/platform/packages/shared/content-management/content_insights/content_insights_public/src/components/views_stats/views_stats.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ const NoViewsTip = () => {
8484
color="inherit"
8585
iconProps={{ style: { verticalAlign: 'text-bottom', marginLeft: 2 } }}
8686
css={{ textWrap: 'balance' }}
87-
type="questionInCircle"
87+
type="question"
8888
content={
8989
<>
9090
<FormattedMessage

0 commit comments

Comments
 (0)