[Synthtrace] Fix id overflow (#215199)

fixes [214636](#214636)

## Summary

Fix the random id generator, it would sometimes generate an id longer
than the specified length.

> Error: generated id is longer than 16 characters: 17

Author: crespocarlos

src/platform/packages/shared/kbn-apm-synthtrace-client/src/lib/utils/generate_id.ts

@@ -34,10 +34,10 @@ function generateRandomId(length: number = LONG_ID_LENGTH) {
   const randomFactor = Math.floor(Math.random() * UNIQUE_ID_MAX_SEQ);
   const randomHex = (randomFactor * Date.now() * seq).toString(16);
 
-  const generatedId =
-    randomHex.length < length
-      ? `${randomHex}${String(seq).padStart(length - randomHex.length, '0')}`
-      : randomHex.substring(0, length);
+  const generatedId = `${randomHex}${String(seq).padStart(
+    length - randomHex.length,
+    '0'
+  )}`.substring(0, length);
 
   if (generatedId.length > length) {
     throw new Error(`generated id is longer than ${length} characters: ${generatedId.length}`);