[8.19] [ES|QL] Fixes rename wrong validation for asterisc in name (#219832) (#220194)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[ES|QL] Fixes rename wrong validation for asterisc in name
(#219832)](#219832)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-05-06T06:48:28Z","message":"[ES|QL]
Fixes rename wrong validation for asterisc in name (#219832)\n\n##
Summary\n\nRemoves the wildcard validation to fix wrong validation like
that:\n\n<img width=\"844\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c71ee9a9-539a-40a4-b467-2bedf0111ae5\"\n/>\n\n\nThis
scenario\n\n```\nFROM logst* | RENAME agent* AS meow \n```\n\nfails
already so we are ok I think\n\n### Checklist\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"f5afb22941f6008db2f22c1b6fda781e6f9c7e4c","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
Fixes rename wrong validation for asterisc in
name","number":219832,"url":"https://github.com/elastic/kibana/pull/219832","mergeCommit":{"message":"[ES|QL]
Fixes rename wrong validation for asterisc in name (#219832)\n\n##
Summary\n\nRemoves the wildcard validation to fix wrong validation like
that:\n\n<img width=\"844\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c71ee9a9-539a-40a4-b467-2bedf0111ae5\"\n/>\n\n\nThis
scenario\n\n```\nFROM logst* | RENAME agent* AS meow \n```\n\nfails
already so we are ok I think\n\n### Checklist\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"f5afb22941f6008db2f22c1b6fda781e6f9c7e4c"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219832","number":219832,"mergeCommit":{"message":"[ES|QL]
Fixes rename wrong validation for asterisc in name (#219832)\n\n##
Summary\n\nRemoves the wildcard validation to fix wrong validation like
that:\n\n<img width=\"844\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c71ee9a9-539a-40a4-b467-2bedf0111ae5\"\n/>\n\n\nThis
scenario\n\n```\nFROM logst* | RENAME agent* AS meow \n```\n\nfails
already so we are ok I think\n\n### Checklist\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"f5afb22941f6008db2f22c1b6fda781e6f9c7e4c"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <[email protected]>

Author: kibanamachine

src/platform/packages/shared/kbn-esql-validation-autocomplete/src/definitions/commands.ts

@@ -15,8 +15,6 @@ import {
   type ESQLCommand,
   type ESQLFunction,
   type ESQLMessage,
-  type ESQLAstRenameExpression,
-  Walker,
 } from '@kbn/esql-ast';
 import { i18n } from '@kbn/i18n';
 import {
@@ -301,35 +299,6 @@ export const commandDefinitions: Array<CommandDefinition<any>> = [
     declaration: 'RENAME old_name1 AS new_name1[, ..., old_nameN AS new_nameN]',
     examples: ['… | RENAME old AS new', '… | RENAME old AS new, a AS b'],
     suggest: suggestForRename,
-    validate: (command: ESQLCommand<'rename'>) => {
-      const messages: ESQLMessage[] = [];
-
-      const renameExpressions = Walker.findAll(command, (node) => {
-        return node.type === 'option' && node.name === 'as';
-      }) as ESQLAstRenameExpression[];
-
-      for (const expression of renameExpressions) {
-        const [column] = expression.args;
-        if (!isColumnItem(column)) {
-          continue;
-        }
-
-        if (hasWildcard(column.name)) {
-          messages.push(
-            getMessageFromId({
-              messageId: 'wildcardNotSupportedForCommand',
-              values: {
-                command: 'RENAME',
-                value: column.name,
-              },
-              locations: column.location,
-            })
-          );
-        }
-      }
-
-      return messages;
-    },
     fieldsSuggestionsAfter: fieldsSuggestionsAfterRename,
   },
   {

src/platform/packages/shared/kbn-esql-validation-autocomplete/src/validation/esql_validation_meta_tests.json

@@ -2635,22 +2635,17 @@
     {
       "query": "from a_index | rename key* as keywords",
       "error": [
-        "Using wildcards (*) in RENAME is not allowed [key*]",
         "Unknown column [keywords]"
       ],
       "warning": []
     },
     {
-      "query": "from a_index | rename s* as strings",
-      "error": [
-        "Using wildcards (*) in RENAME is not allowed [s*]",
-        "Unknown column [s*]",
-        "Unknown column [strings]"
-      ],
+      "query": "row a = 10 | rename a as `this``is fine`",
+      "error": [],
       "warning": []
     },
     {
-      "query": "row a = 10 | rename a as `this``is fine`",
+      "query": "ROW `C*OUNT` = 5 | RENAME `C*OUNT` AS meow",
       "error": [],
       "warning": []
     },

src/platform/packages/shared/kbn-esql-validation-autocomplete/src/validation/validation.test.ts

@@ -676,15 +676,10 @@ describe('validation logic', () => {
         "SyntaxError: mismatched input '<EOF>' expecting {'?', '??', NAMED_OR_POSITIONAL_PARAM, NAMED_OR_POSITIONAL_DOUBLE_PARAMS, ID_PATTERN}",
       ]);
       testErrorsAndWarnings('from a_index | rename key* as keywords', [
-        'Using wildcards (*) in RENAME is not allowed [key*]',
         'Unknown column [keywords]',
       ]);
-      testErrorsAndWarnings('from a_index | rename s* as strings', [
-        'Using wildcards (*) in RENAME is not allowed [s*]',
-        'Unknown column [s*]',
-        'Unknown column [strings]',
-      ]);
       testErrorsAndWarnings('row a = 10 | rename a as `this``is fine`', []);
+      testErrorsAndWarnings('ROW `C*OUNT` = 5 | RENAME `C*OUNT` AS meow', []);
       testErrorsAndWarnings('row a = 10 | rename a as this is fine', [
         "SyntaxError: mismatched input 'is' expecting <EOF>",
       ]);