Skip to content

Commit 9dc817d

Browse files
dmlemeshkodmlemeshko
authored
[ska] remove x-pack/test dir (#233534)
## Summary Part of elastic/kibana-team#1503 This pull request removes the legacy `x-pack/test` directory and its references from the Kibana repo, consolidating test configuration, artifact upload, ESLint patterns, and code ownership under the newer `x-pack/platform/test` and solution-specific directories.
1 parent 8a71d1d commit 9dc817d

File tree

83 files changed

+304
-3844
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

83 files changed

+304
-3844
lines changed

‎.buildkite/ftr_platform_stateful_configs.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,10 @@ disabled:
66
# Base config files, only necessary to inform config finding script
77
- src/platform/test/functional/config.base.js
88
- src/platform/test/functional/firefox/config.base.ts
9-
- x-pack/test/functional/config.base.js
109
- x-pack/platform/test/functional/config.base.ts
1110
- x-pack/platform/test/localization/config.base.ts
1211
- src/platform/test/server_integration/config.base.js
1312
- x-pack/platform/test/functional_with_es_ssl/config.base.ts
14-
- x-pack/test/api_integration/config.ts
1513
- x-pack/platform/test/api_integration/config.ts
1614
- x-pack/platform/test/fleet_api_integration/config.base.ts
1715
- x-pack/platform/test/functional_basic/apps/ml/config.base.ts

‎.buildkite/ftr_security_stateful_configs.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ disabled:
88
- x-pack/solutions/security/test/security_solution_api_integration/config/ess/config.base.frozen.trial.ts
99
- x-pack/solutions/security/test/security_solution_endpoint/configs/config.base.ts
1010
- x-pack/solutions/security/test/security_solution_endpoint/config.base.ts
11-
- x-pack/test/security_solution_endpoint_api_int/config.base.ts
1211
- x-pack/solutions/security/test/api_integration/config.ts
1312
- x-pack/solutions/security/test/functional/config.base.ts
1413

‎.buildkite/pull_requests.json‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
"^test/",
4545
"^x-pack/platform/test/",
4646
"^x-pack/solutions/(search|observability|security)/test/",
47-
"^x-pack/test/",
4847
"/__snapshots__/",
4948
"\\.test\\.(ts|tsx|js|jsx)"
5049
]
@@ -70,7 +69,6 @@
7069
"kibana_build_reuse_pipeline_slugs": ["kibana-pull-request", "kibana-on-merge", "kibana-deploy-project-from-pr"],
7170
"kibana_build_reuse_regexes": [
7271
"^test/",
73-
"^x-pack/test/",
7472
"^x-pack/platform/test/",
7573
"^x-pack/solutions/(search|observability|security)/test/",
7674
"/__snapshots__/",
@@ -98,7 +96,6 @@
9896
"kibana_build_reuse_pipeline_slugs": ["kibana-pull-request", "kibana-on-merge", "kibana-deploy-cloud-from-pr"],
9997
"kibana_build_reuse_regexes": [
10098
"^test/",
101-
"^x-pack/test/",
10299
"^x-pack/platform/test/",
103100
"^x-pack/solutions/(search|observability|security)/test/",
104101
"/__snapshots__/",

‎.buildkite/scripts/lifecycle/post_command.sh‎

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,19 +32,11 @@ if [[ "$IS_TEST_EXECUTION_STEP" == "true" ]]; then
3232
buildkite-agent artifact upload 'x-pack/platform/test/**/screenshots/diff/*.png'
3333
buildkite-agent artifact upload 'x-pack/platform/test/**/screenshots/failure/*.png'
3434
buildkite-agent artifact upload 'x-pack/platform/test/**/screenshots/session/*.png'
35+
buildkite-agent artifact upload 'x-pack/platform/test/functional/failure_debug/html/*.html'
3536
buildkite-agent artifact upload 'x-pack/platform/test/serverless/**/screenshots/diff/*.png'
3637
buildkite-agent artifact upload 'x-pack/platform/test/serverless/**/screenshots/failure/*.png'
3738
buildkite-agent artifact upload 'x-pack/platform/test/serverless/**/screenshots/session/*.png'
3839
buildkite-agent artifact upload 'x-pack/platform/test/serverless/**/failure_debug/html/*.html'
39-
buildkite-agent artifact upload 'x-pack/test/**/screenshots/diff/*.png'
40-
buildkite-agent artifact upload 'x-pack/test/**/screenshots/failure/*.png'
41-
buildkite-agent artifact upload 'x-pack/test/**/screenshots/session/*.png'
42-
buildkite-agent artifact upload 'x-pack/test/functional/apps/reporting/reports/session/*.pdf'
43-
buildkite-agent artifact upload 'x-pack/test/functional/failure_debug/html/*.html'
44-
buildkite-agent artifact upload 'x-pack/platform/test/**/screenshots/diff/*.png'
45-
buildkite-agent artifact upload 'x-pack/platform/test/**/screenshots/failure/*.png'
46-
buildkite-agent artifact upload 'x-pack/platform/test/**/screenshots/session/*.png'
47-
buildkite-agent artifact upload 'x-pack/platform/test/functional/failure_debug/html/*.html'
4840
buildkite-agent artifact upload '.es/**/*.hprof'
4941
buildkite-agent artifact upload 'data/es_debug_*.tar.gz'
5042
buildkite-agent artifact upload '.es/es*.log'

‎.eslintrc.js‎

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -773,7 +773,6 @@ module.exports = {
773773
'src/platform/test/*/*.config.ts',
774774
'src/platform/test/*/{tests,test_suites,apis,apps}/**/*',
775775
'src/platform/test/server_integration/**/*.ts',
776-
'x-pack/test/functional/apps/**/*.js',
777776
'x-pack/solutions/observability/plugins/apm/**/*.js',
778777
'x-pack/platform/test/*/{tests,test_suites,apis,apps}/**/*',
779778
'x-pack/platform/test/*api_integration*/**/*',
@@ -784,18 +783,14 @@ module.exports = {
784783
'x-pack/solutions/*/test/api_integration_deployment_agnostic/*configs/**/*',
785784
'x-pack/solutions/*/test/alerting_api_integration/**/*',
786785
'x-pack/solutions/*/test/serverless/*/configs/**/*',
787-
'x-pack/test/*/{tests,test_suites,apis,apps}/**/*',
788-
'x-pack/test/*/*config.*ts',
789786
'x-pack/platform/test/saved_object_api_integration/*/apis/**/*',
790787
'x-pack/platform/test/ui_capabilities/*/tests/**/*',
791788
'x-pack/platform/test/upgrade_assistant_integration/**/*',
792-
'x-pack/test/performance/**/*.ts',
793789
'**/cypress.config.{js,ts}',
794790
'x-pack/platform/test/serverless/shared/config*.ts',
795791
'x-pack/platform/test/serverless/*/test_suites/**/*',
796792
'x-pack/platform/test/serverless/functional/config*.ts',
797793
'x-pack/platform/test/serverless/*/configs/**/*',
798-
'x-pack/test/profiling_api_integration/**/*.ts',
799794
'x-pack/solutions/security/test/security_solution_api_integration/*/test_suites/**/*',
800795
'x-pack/solutions/security/test/security_solution_api_integration/**/config*.ts',
801796
'**/playwright.config.ts',
@@ -1576,8 +1571,8 @@ module.exports = {
15761571
files: [
15771572
'src/platform/test/{accessibility,*functional*}/apps/**/*.{js,ts}',
15781573
'src/platform/test/*api_integration*/**/*.{js,ts}',
1579-
'x-pack/test/{accessibility,*functional*}/apps/**/*.{js,ts}',
1580-
'x-pack/test/*api_integration*/**/*.{js,ts}',
1574+
'x-pack/platform/test/{accessibility,*functional*}/apps/**/*.{js,ts}',
1575+
'x-pack/platform/test/*api_integration*/**/*.{js,ts}',
15811576
],
15821577
extends: ['plugin:mocha/recommended'],
15831578
plugins: ['mocha'],
@@ -1811,7 +1806,8 @@ module.exports = {
18111806
'x-pack/platform/test/cases_api_integration/**/*.{ts, tsx}',
18121807
'x-pack/solutions/**/test/cases_api_integration/**/*.{ts, tsx}',
18131808
'x-pack/platform/test/rule_registry/**/*.{ts, tsx}',
1814-
'x-pack/test/api_integration/apis/cases/**/*.{ts, tsx}',
1809+
'x-pack/platform/test/api_integration/apis/cases/**/*.{ts, tsx}',
1810+
'x-pack/solutions/**/test/api_integration/apis/cases/**/*.{ts, tsx}',
18151811
],
18161812
},
18171813

@@ -2183,8 +2179,8 @@ module.exports = {
21832179
'x-pack/platform/plugins/shared/security/**/*.{ts,tsx}',
21842180
'x-pack/platform/packages/private/security/**/*.{ts,tsx}',
21852181
'x-pack/platform/packages/shared/security/**/*.{ts,tsx}',
2186-
'x-pack/test/security_api_integration/**/*.{ts,tsx}',
2187-
'x-pack/test/security_functional/**/*.{ts,tsx}',
2182+
'x-pack/platform/test/security_api_integration/**/*.{ts,tsx}',
2183+
'x-pack/platform/test/security_functional/**/*.{ts,tsx}',
21882184

21892185
'x-pack/platform/plugins/shared/spaces/**/*.{ts,tsx}',
21902186
'x-pack/platform/test/spaces_api_integration/**/*.{ts,tsx}',
@@ -2306,9 +2302,8 @@ module.exports = {
23062302
// FIXME PhilippeOberti @kbn/timelines-plugin depends on security-solution-plugin (security/private) (timelines is going to disappear)
23072303
'x-pack/platform/plugins/shared/timelines/**',
23082304

2309-
// For now, we keep the exception to let tests depend on anythying.
2305+
// For now, we keep the exception to let tests depend on anything.
23102306
// Ideally, we need to classify the solution specific ones to reduce CI times
2311-
'x-pack/test/**',
23122307
'x-pack/platform/test/plugin_functional/plugins/resolver_test/**',
23132308
],
23142309
rules: {

0 commit comments

Comments
 (0)