Commit a24c33d
[EDR Workflows][Move endpoint exceptions] Endpoint Exceptions page added (#232388)
## Summary
This PR adds the Endpoint Exceptions list page:
- accessible from
- Manage sidebar (ess classic solution view) / Endpoint Exceptions
- Administration landing page (ess classic solution view) / Endpoint
Exceptions
- Assets sidebar (serverless, ess security solution view)
- or directly: `/app/security/administration/endpoint_exceptions`
- it lists existing Endpoint Exceptions
- items are searchable
- items are deletable
- add/edit form is only a placeholder so far, they can be created/edited
under Rules / Shared exception lists
> [!important]
> Moving Endpoint Exceptions is behind feature flag, so until it is not
released, existing behavior (accessing EE from shared exception lists
page etc.) should be intact. This is hopefully enforced by existing
tests (e.g. #229469) and new ones
in
`x-pack/solutions/security/plugins/security_solution/public/management/cypress/e2e/artifacts/endpoint_exceptions.no_ff.cy.ts`
## Dev notes
- Endpoint exceptions are already added to `ENDPOINT_ARTIFACT_LISTS`
(c8560ca), to allow artifact list page
creating the list on page load in case it does not exist. It exists
usually, created by
[`TelemetryReceiver`](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/server/lib/telemetry/receiver.ts#L691)
class.
- To keep existing behavior, Endpoint exceptions are removed on-the-fly
from the array, see the same commit.
- I didn't add a lot of tests testing the new functionalities - I plan
to have them tested with the existing
[`artifacts_rbac_runner.ts`](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/public/management/cypress/support/artifacts_rbac_runner.ts),
similarly to other artifacts. This is possible after having the form and
separate Endpoint Exceptions sub-feature privilege in place.
## Testing
Enable feature flag in `kibana.dev.yml`:
```
xpack.securitySolution.enableExperimental:
- endpointExceptionsMovedUnderManagement
```
## Screenshots
<img width="1110" height="792" alt="image"
src="https://github.com/user-attachments/assets/a392a082-64d9-4c1e-b55c-8d4e730ce13c"
/>
<img width="1185" height="818" alt="image"
src="https://github.com/user-attachments/assets/dd7111b4-deb5-4940-82c8-b6eb19987496"
/>
<img width="1183" height="815" alt="image"
src="https://github.com/user-attachments/assets/53dfed0a-92ab-4ca1-8772-0f0e95703972"
/>
### Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
---------
Co-authored-by: kibanamachine <[email protected]>1 parent 0bbed22 commit a24c33d
File tree
32 files changed
+530
-111
lines changed- src/core/server/integration_tests/ci_checks/saved_objects
- x-pack/solutions/security
- packages/kbn-securitysolution-list-constants
- plugins
- lists/server
- saved_objects
- services/exception_lists
- security_solution
- common
- public
- exceptions
- api
- hooks/use_list_detail_view
- management
- common
- cypress
- e2e/artifacts
- tasks
- pages
- endpoint_exceptions
- service
- view
- components
- integration_tests
- scripts/endpoint/common
- server
- endpoint/migrations
- lib/detection_engine/rule_management/logic/export
- lists_integration/endpoint/handlers
- test
- security_solution_api_integration/test_suites/edr_workflows/spaces/trial_license_complete_tier
- security_solution_endpoint
- apps/integrations
- services
32 files changed
+530
-111
lines changedLines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
616 | 616 | | |
617 | 617 | | |
618 | 618 | | |
619 | | - | |
620 | | - | |
| 619 | + | |
| 620 | + | |
621 | 621 | | |
622 | 622 | | |
623 | 623 | | |
624 | 624 | | |
625 | | - | |
626 | | - | |
| 625 | + | |
| 626 | + | |
627 | 627 | | |
628 | 628 | | |
629 | 629 | | |
| |||
Lines changed: 12 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | 56 | | |
69 | 57 | | |
70 | 58 | | |
| |||
75 | 63 | | |
76 | 64 | | |
77 | 65 | | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
78 | 71 | | |
79 | 72 | | |
80 | 73 | | |
| |||
109 | 102 | | |
110 | 103 | | |
111 | 104 | | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| |||
Lines changed: 8 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
| 17 | + | |
21 | 18 | | |
22 | 19 | | |
23 | 20 | | |
| |||
58 | 55 | | |
59 | 56 | | |
60 | 57 | | |
61 | | - | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
62 | 64 | | |
63 | 65 | | |
64 | 66 | | |
| |||
72 | 74 | | |
73 | 75 | | |
74 | 76 | | |
75 | | - | |
| 77 | + | |
76 | 78 | | |
77 | 79 | | |
78 | 80 | | |
| |||
Lines changed: 5 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
| 14 | + | |
19 | 15 | | |
20 | 16 | | |
21 | 17 | | |
| |||
43 | 39 | | |
44 | 40 | | |
45 | 41 | | |
46 | | - | |
| 42 | + | |
47 | 43 | | |
48 | 44 | | |
49 | 45 | | |
50 | 46 | | |
51 | | - | |
| 47 | + | |
52 | 48 | | |
53 | 49 | | |
54 | | - | |
| 50 | + | |
55 | 51 | | |
56 | 52 | | |
57 | 53 | | |
| |||
61 | 57 | | |
62 | 58 | | |
63 | 59 | | |
64 | | - | |
| 60 | + | |
65 | 61 | | |
66 | 62 | | |
67 | 63 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
| 142 | + | |
| 143 | + | |
142 | 144 | | |
143 | 145 | | |
144 | 146 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
30 | | - | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
31 | 34 | | |
32 | 35 | | |
33 | 36 | | |
| |||
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
114 | 115 | | |
115 | 116 | | |
116 | 117 | | |
117 | | - | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
118 | 122 | | |
119 | 123 | | |
120 | 124 | | |
| |||
x-pack/solutions/security/plugins/security_solution/public/exceptions/pages/shared_lists/index.tsx
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
| |||
133 | 134 | | |
134 | 135 | | |
135 | 136 | | |
136 | | - | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
137 | 140 | | |
138 | 141 | | |
139 | 142 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| 30 | + | |
29 | 31 | | |
30 | 32 | | |
31 | 33 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
0 commit comments