You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[Embeddables] Decouple fetching from search sessions (#240333)
Closes#239610
## Summary
This PR decouples fetching from search session IDs - i.e. we no longer
need the search session ID to change in order to trigger a refetch. This
unblocks #233124, since making a
selection in a section-scoped control should **not** trigger a new
search session but it **should** cause a refetch for the targeted
panels. This is also just a cleaner implementation overall, since search
sessions should **not** drive fetching.
Note that, in order to ensure that fetching still happens **after** the
search session ID changes (so that embeddables receive the up-to-date ID
and no double fetch happens), I had to add an async callback that allows
the Dashboard to let the `fetch$` observable know when the search
session ID is stable.
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.
---------
Co-authored-by: kibanamachine <[email protected]>
0 commit comments