Commit a751550
# Backport
This will backport the following commits from `main` to `8.x`:
- [[Security Solution] Improve documentation for `version` and
`revision` fields
(#216074)](#216074)
<!--- Backport version: 9.6.6 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)
<!--BACKPORT [{"author":{"name":"Jacek
Kolezynski","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-03-31T18:06:13Z","message":"[Security
Solution] Improve documentation for `version` and `revision` fields
(#216074)\n\n**Resolves:
https://github.com/elastic/security-docs/issues/3545**\n\n##
Summary\n\nI am fixing documentation for the version and revision
fields.\nI used this page as the base
documentation:\nhttps://docs.elastic.dev/security-solution/dev-docs/detections/rule-versions\n\nThe
changes:\n- by marking the RuleVersion as read-only I am making sure we
are\nproperly documenting that this field is not to be used in the
request.\nIt is only returned in the response.\n- by introducing
RuleRevision type and marking it as read-only, I am\ndoing the same for
this field, saying that this field is not supposed to\nbe used in the
request.\n- I am not changing any code in the app, as the ticket says we
shouldn't\ndo any breaking changes and the update of the version should
not cause\n400 error. Basically current behavior is kept: users can
still update\nthe version to whatever value they want, including going
backwards, and\nthe changes to revision field is completely ignored.\n-
I am adding a condensed description of these fields.\n\nI wanted to
introduce an internal link between these two fields, but I\ncouldn't
make it work in Bump.sh (even though this should work, normal\nMarkdown
links) so I abandoned this idea.\n\nYou can also use this
[link](https://bump.sh/jkelas2/doc/kibana_wip2)\nwhere I deployed the
generated bundled doc.\n\nScreenshots:\n\n<img width=\"664\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/34d82eb2-f7f0-4369-ad8e-2fd3c1f35447\"\n/>\n\n<img
width=\"660\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/dc7772af-0185-4850-816e-60be003775d6\"\n/>\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"63575a8320a7e021df79727ad66ed4cf01dd1e5f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections
and Resp","Team: SecuritySolution","Feature:Rule
Management","APIDocs","Team:Detection Rule Management","Feature:Prebuilt
Detection Rules","backport:version","9.1
candidate","v9.1.0","v8.19.0"],"title":"[Security Solution] Improve
documentation for `version` and `revision`
fields","number":216074,"url":"https://github.com/elastic/kibana/pull/216074","mergeCommit":{"message":"[Security
Solution] Improve documentation for `version` and `revision` fields
(#216074)\n\n**Resolves:
https://github.com/elastic/security-docs/issues/3545**\n\n##
Summary\n\nI am fixing documentation for the version and revision
fields.\nI used this page as the base
documentation:\nhttps://docs.elastic.dev/security-solution/dev-docs/detections/rule-versions\n\nThe
changes:\n- by marking the RuleVersion as read-only I am making sure we
are\nproperly documenting that this field is not to be used in the
request.\nIt is only returned in the response.\n- by introducing
RuleRevision type and marking it as read-only, I am\ndoing the same for
this field, saying that this field is not supposed to\nbe used in the
request.\n- I am not changing any code in the app, as the ticket says we
shouldn't\ndo any breaking changes and the update of the version should
not cause\n400 error. Basically current behavior is kept: users can
still update\nthe version to whatever value they want, including going
backwards, and\nthe changes to revision field is completely ignored.\n-
I am adding a condensed description of these fields.\n\nI wanted to
introduce an internal link between these two fields, but I\ncouldn't
make it work in Bump.sh (even though this should work, normal\nMarkdown
links) so I abandoned this idea.\n\nYou can also use this
[link](https://bump.sh/jkelas2/doc/kibana_wip2)\nwhere I deployed the
generated bundled doc.\n\nScreenshots:\n\n<img width=\"664\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/34d82eb2-f7f0-4369-ad8e-2fd3c1f35447\"\n/>\n\n<img
width=\"660\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/dc7772af-0185-4850-816e-60be003775d6\"\n/>\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"63575a8320a7e021df79727ad66ed4cf01dd1e5f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216074","number":216074,"mergeCommit":{"message":"[Security
Solution] Improve documentation for `version` and `revision` fields
(#216074)\n\n**Resolves:
https://github.com/elastic/security-docs/issues/3545**\n\n##
Summary\n\nI am fixing documentation for the version and revision
fields.\nI used this page as the base
documentation:\nhttps://docs.elastic.dev/security-solution/dev-docs/detections/rule-versions\n\nThe
changes:\n- by marking the RuleVersion as read-only I am making sure we
are\nproperly documenting that this field is not to be used in the
request.\nIt is only returned in the response.\n- by introducing
RuleRevision type and marking it as read-only, I am\ndoing the same for
this field, saying that this field is not supposed to\nbe used in the
request.\n- I am not changing any code in the app, as the ticket says we
shouldn't\ndo any breaking changes and the update of the version should
not cause\n400 error. Basically current behavior is kept: users can
still update\nthe version to whatever value they want, including going
backwards, and\nthe changes to revision field is completely ignored.\n-
I am adding a condensed description of these fields.\n\nI wanted to
introduce an internal link between these two fields, but I\ncouldn't
make it work in Bump.sh (even though this should work, normal\nMarkdown
links) so I abandoned this idea.\n\nYou can also use this
[link](https://bump.sh/jkelas2/doc/kibana_wip2)\nwhere I deployed the
generated bundled doc.\n\nScreenshots:\n\n<img width=\"664\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/34d82eb2-f7f0-4369-ad8e-2fd3c1f35447\"\n/>\n\n<img
width=\"660\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/dc7772af-0185-4850-816e-60be003775d6\"\n/>\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"63575a8320a7e021df79727ad66ed4cf01dd1e5f"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Co-authored-by: Jacek Kolezynski <[email protected]>
1 parent 79cc21e commit a751550
File tree
8 files changed
+143
-18
lines changed- oas_docs/output
- x-pack/solutions/security/plugins/security_solution
- common/api/detection_engine/model/rule_schema
- docs/openapi
- ess
- serverless
8 files changed
+143
-18
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50145 | 50145 | | |
50146 | 50146 | | |
50147 | 50147 | | |
50148 | | - | |
50149 | | - | |
| 50148 | + | |
50150 | 50149 | | |
50151 | 50150 | | |
50152 | 50151 | | |
| |||
50492 | 50491 | | |
50493 | 50492 | | |
50494 | 50493 | | |
| 50494 | + | |
| 50495 | + | |
| 50496 | + | |
| 50497 | + | |
| 50498 | + | |
| 50499 | + | |
| 50500 | + | |
| 50501 | + | |
| 50502 | + | |
50495 | 50503 | | |
50496 | 50504 | | |
50497 | 50505 | | |
| |||
50520 | 50528 | | |
50521 | 50529 | | |
50522 | 50530 | | |
50523 | | - | |
| 50531 | + | |
| 50532 | + | |
| 50533 | + | |
| 50534 | + | |
| 50535 | + | |
| 50536 | + | |
| 50537 | + | |
50524 | 50538 | | |
50525 | 50539 | | |
50526 | 50540 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35675 | 35675 | | |
35676 | 35676 | | |
35677 | 35677 | | |
35678 | | - | |
35679 | | - | |
| 35678 | + | |
35680 | 35679 | | |
35681 | 35680 | | |
35682 | 35681 | | |
| |||
36022 | 36021 | | |
36023 | 36022 | | |
36024 | 36023 | | |
| 36024 | + | |
| 36025 | + | |
| 36026 | + | |
| 36027 | + | |
| 36028 | + | |
| 36029 | + | |
| 36030 | + | |
| 36031 | + | |
| 36032 | + | |
36025 | 36033 | | |
36026 | 36034 | | |
36027 | 36035 | | |
| |||
36050 | 36058 | | |
36051 | 36059 | | |
36052 | 36060 | | |
36053 | | - | |
| 36061 | + | |
| 36062 | + | |
| 36063 | + | |
| 36064 | + | |
| 36065 | + | |
| 36066 | + | |
| 36067 | + | |
36054 | 36068 | | |
36055 | 36069 | | |
36056 | 36070 | | |
| |||
Lines changed: 19 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
39 | | - | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
40 | 46 | | |
41 | 47 | | |
42 | 48 | | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
43 | 60 | | |
44 | 61 | | |
45 | 62 | | |
| |||
Lines changed: 17 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
28 | 44 | | |
29 | 45 | | |
30 | 46 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| 62 | + | |
62 | 63 | | |
63 | 64 | | |
64 | 65 | | |
| |||
166 | 167 | | |
167 | 168 | | |
168 | 169 | | |
169 | | - | |
| 170 | + | |
170 | 171 | | |
171 | 172 | | |
172 | 173 | | |
| |||
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
196 | | - | |
197 | | - | |
| 196 | + | |
198 | 197 | | |
199 | 198 | | |
200 | 199 | | |
| |||
Lines changed: 35 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5115 | 5115 | | |
5116 | 5116 | | |
5117 | 5117 | | |
5118 | | - | |
5119 | | - | |
| 5118 | + | |
5120 | 5119 | | |
5121 | 5120 | | |
5122 | 5121 | | |
| |||
5505 | 5504 | | |
5506 | 5505 | | |
5507 | 5506 | | |
| 5507 | + | |
| 5508 | + | |
| 5509 | + | |
| 5510 | + | |
| 5511 | + | |
| 5512 | + | |
| 5513 | + | |
| 5514 | + | |
| 5515 | + | |
| 5516 | + | |
| 5517 | + | |
| 5518 | + | |
| 5519 | + | |
| 5520 | + | |
| 5521 | + | |
| 5522 | + | |
| 5523 | + | |
| 5524 | + | |
| 5525 | + | |
5508 | 5526 | | |
5509 | 5527 | | |
5510 | 5528 | | |
| |||
5538 | 5556 | | |
5539 | 5557 | | |
5540 | 5558 | | |
5541 | | - | |
| 5559 | + | |
| 5560 | + | |
| 5561 | + | |
| 5562 | + | |
| 5563 | + | |
| 5564 | + | |
| 5565 | + | |
| 5566 | + | |
| 5567 | + | |
| 5568 | + | |
| 5569 | + | |
| 5570 | + | |
| 5571 | + | |
| 5572 | + | |
| 5573 | + | |
5542 | 5574 | | |
5543 | 5575 | | |
5544 | 5576 | | |
| |||
Lines changed: 35 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4109 | 4109 | | |
4110 | 4110 | | |
4111 | 4111 | | |
4112 | | - | |
4113 | | - | |
| 4112 | + | |
4114 | 4113 | | |
4115 | 4114 | | |
4116 | 4115 | | |
| |||
4499 | 4498 | | |
4500 | 4499 | | |
4501 | 4500 | | |
| 4501 | + | |
| 4502 | + | |
| 4503 | + | |
| 4504 | + | |
| 4505 | + | |
| 4506 | + | |
| 4507 | + | |
| 4508 | + | |
| 4509 | + | |
| 4510 | + | |
| 4511 | + | |
| 4512 | + | |
| 4513 | + | |
| 4514 | + | |
| 4515 | + | |
| 4516 | + | |
| 4517 | + | |
| 4518 | + | |
| 4519 | + | |
4502 | 4520 | | |
4503 | 4521 | | |
4504 | 4522 | | |
| |||
4532 | 4550 | | |
4533 | 4551 | | |
4534 | 4552 | | |
4535 | | - | |
| 4553 | + | |
| 4554 | + | |
| 4555 | + | |
| 4556 | + | |
| 4557 | + | |
| 4558 | + | |
| 4559 | + | |
| 4560 | + | |
| 4561 | + | |
| 4562 | + | |
| 4563 | + | |
| 4564 | + | |
| 4565 | + | |
| 4566 | + | |
| 4567 | + | |
4536 | 4568 | | |
4537 | 4569 | | |
4538 | 4570 | | |
| |||
0 commit comments