Skip to content

Commit a76f89f

Browse files
qn895elasticmachine
authored andcommitted
[AI Infra] Fix Security AI Assistant not calling tools correctly when consuming InferenceChatModel with OSS like Mistral (#236317)
## Summary This PR fixes #234931, where the Security AI Assistant not calling tools correctly when consuming InferenceChatModel with OSS like Mistral Before <img width="1726" height="797" alt="Screenshot 2025-09-29 at 16 23 42" src="https://github.com/user-attachments/assets/8c8df6ac-c071-4c75-a2ca-7c692c124aae" /> After <img width="867" height="866" alt="Screenshot 2025-09-29 at 16 56 13" src="https://github.com/user-attachments/assets/64e68c5d-0145-4cf9-901f-b9d9be6c5f1b" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... Co-authored-by: Elastic Machine <[email protected]>
1 parent eec9313 commit a76f89f

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

x-pack/platform/plugins/shared/inference/server/chat_complete/simulated_function_calling/parse_inline_function_calls.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,10 @@ export function parseInlineFunctionCalls({ logger }: { logger: Logger }) {
6363
if (!parsedFunctionCall.name) {
6464
throw createInferenceInternalError(`Missing name for tool use`);
6565
}
66+
let input = parsedFunctionCall.input;
67+
if (typeof input === 'string') {
68+
input = { input };
69+
}
6670

6771
subscriber.next({
6872
content: '',
@@ -72,7 +76,7 @@ export function parseInlineFunctionCalls({ logger }: { logger: Logger }) {
7276
toolCallId: parsedFunctionCall.name,
7377
function: {
7478
name: parsedFunctionCall.name,
75-
arguments: JSON.stringify(parsedFunctionCall.input || {}),
79+
arguments: JSON.stringify(input || {}),
7680
},
7781
},
7882
],

0 commit comments

Comments
 (0)