[EDR Workflows][FF Cleanup] Remove responseActionUploadEnabled feature flag (#236914)

Removes the `responseActionUploadEnabled` feature flag (enabled in
v8.9). The upload response action is now always available without
feature flag gating.

Author: szwarckonrad

x-pack/solutions/security/plugins/security_solution/common/experimental_features.ts

@@ -42,11 +42,6 @@ export const allowedExperimentalValues = Object.freeze({
    */
   socTrendsEnabled: false,
 
-  /**
-   * Enables the `upload` endpoint response action (v8.9)
-   */
-  responseActionUploadEnabled: true,
-
   /**
    * Enables Automated Endpoint Process actions
    */

x-pack/solutions/security/plugins/security_solution/public/management/components/endpoint_responder/command_render_components/integration_tests/upload_action.test.tsx

@@ -68,7 +68,6 @@ describe.skip('When using `upload` response action', () => {
     user = userEvent.setup({ advanceTimers: jest.advanceTimersByTime });
     const mockedContext = createAppRootMockRenderer();
 
-    mockedContext.setExperimentalFlag({ responseActionUploadEnabled: true });
     apiMocks = responseActionsHttpMocks(mockedContext.coreStart.http);
     endpointPrivileges = { ...getEndpointAuthzInitialStateMock(), loading: false };
     endpointCapabilities = [...ENDPOINT_CAPABILITIES];

x-pack/solutions/security/plugins/security_solution/public/management/components/endpoint_responder/lib/console_commands_definition.ts

@@ -184,7 +184,6 @@ export const getEndpointConsoleCommands = ({
 }: GetEndpointConsoleCommandsOptions): CommandDefinition[] => {
   const featureFlags = ExperimentalFeaturesService.get();
   const {
-    responseActionUploadEnabled: isUploadEnabled,
     crowdstrikeRunScriptEnabled,
     microsoftDefenderEndpointRunScriptEnabled,
     microsoftDefenderEndpointCancelEnabled,
@@ -484,51 +483,48 @@ export const getEndpointConsoleCommands = ({
   ];
 
   // `upload` command
-  // planned for 8.9
-  if (isUploadEnabled) {
-    consoleCommands.push({
-      name: 'upload',
-      about: getCommandAboutInfo({
-        aboutInfo: CONSOLE_COMMANDS.upload.about,
-        isSupported: doesEndpointSupportCommand('upload'),
-      }),
-      RenderComponent: UploadActionResult,
-      meta: commandMeta,
-      exampleUsage: 'upload --file --overwrite --comment "script to fix registry"',
-      exampleInstruction: ENTER_OR_ADD_COMMENT_ARG_INSTRUCTION,
-      validate: capabilitiesAndPrivilegesValidator(agentType),
-      mustHaveArgs: true,
-      args: {
-        file: {
-          required: true,
-          allowMultiples: false,
-          about: CONSOLE_COMMANDS.upload.args.file.about,
-          mustHaveValue: 'truthy',
-          SelectorComponent: ArgumentFileSelector,
-        },
-        overwrite: {
-          required: false,
-          allowMultiples: false,
-          about: CONSOLE_COMMANDS.upload.args.overwrite.about,
-          mustHaveValue: false,
-        },
-        comment: {
-          required: false,
-          allowMultiples: false,
-          mustHaveValue: 'non-empty-string',
-          about: COMMENT_ARG_ABOUT,
-        },
+  consoleCommands.push({
+    name: 'upload',
+    about: getCommandAboutInfo({
+      aboutInfo: CONSOLE_COMMANDS.upload.about,
+      isSupported: doesEndpointSupportCommand('upload'),
+    }),
+    RenderComponent: UploadActionResult,
+    meta: commandMeta,
+    exampleUsage: 'upload --file --overwrite --comment "script to fix registry"',
+    exampleInstruction: ENTER_OR_ADD_COMMENT_ARG_INSTRUCTION,
+    validate: capabilitiesAndPrivilegesValidator(agentType),
+    mustHaveArgs: true,
+    args: {
+      file: {
+        required: true,
+        allowMultiples: false,
+        about: CONSOLE_COMMANDS.upload.args.file.about,
+        mustHaveValue: 'truthy',
+        SelectorComponent: ArgumentFileSelector,
       },
-      helpGroupLabel: HELP_GROUPS.responseActions.label,
-      helpGroupPosition: HELP_GROUPS.responseActions.position,
-      helpCommandPosition: 7,
-      helpDisabled: !doesEndpointSupportCommand('upload'),
-      helpHidden: !getRbacControl({
-        commandName: 'upload',
-        privileges: endpointPrivileges,
-      }),
-    });
-  }
+      overwrite: {
+        required: false,
+        allowMultiples: false,
+        about: CONSOLE_COMMANDS.upload.args.overwrite.about,
+        mustHaveValue: false,
+      },
+      comment: {
+        required: false,
+        allowMultiples: false,
+        mustHaveValue: 'non-empty-string',
+        about: COMMENT_ARG_ABOUT,
+      },
+    },
+    helpGroupLabel: HELP_GROUPS.responseActions.label,
+    helpGroupPosition: HELP_GROUPS.responseActions.position,
+    helpCommandPosition: 7,
+    helpDisabled: !doesEndpointSupportCommand('upload'),
+    helpHidden: !getRbacControl({
+      commandName: 'upload',
+      privileges: endpointPrivileges,
+    }),
+  });
 
   if (microsoftDefenderEndpointCancelEnabled) {
     const isSupported = canCancelForCurrentContext();

x-pack/solutions/security/plugins/security_solution/public/management/components/endpoint_responder/lib/integration_tests/console_commands_definition.test.tsx

@@ -44,9 +44,7 @@ describe('When displaying Endpoint Response Actions', () => {
 
   describe('for agent type endpoint', () => {
     beforeEach(() => {
-      (ExperimentalFeaturesService.get as jest.Mock).mockReturnValue({
-        responseActionUploadEnabled: true,
-      });
+      (ExperimentalFeaturesService.get as jest.Mock).mockReturnValue({});
       commands = getEndpointConsoleCommands({
         agentType: 'endpoint',
         endpointAgentId: '123',

x-pack/solutions/security/plugins/security_solution/public/management/components/endpoint_response_actions_list/components/hooks.tsx

@@ -339,11 +339,6 @@ export const useActionsLogFilter = ({
       : RESPONSE_ACTION_API_COMMANDS_NAMES.filter((commandName) => {
           const featureFlags = ExperimentalFeaturesService.get();
 
-          // upload - v8.9
-          if (commandName === 'upload' && !featureFlags.responseActionUploadEnabled) {
-            return false;
-          }
-
           if (
             commandName === 'runscript' &&
             !featureFlags.microsoftDefenderEndpointRunScriptEnabled &&

x-pack/solutions/security/plugins/security_solution/public/management/components/endpoint_response_actions_list/integration_tests/response_actions_log.test.tsx

@@ -1525,7 +1525,6 @@ describe('Response actions history', () => {
 
     beforeEach(() => {
       featureFlags = {
-        responseActionUploadEnabled: true,
         crowdstrikeRunScriptEnabled: true,
         microsoftDefenderEndpointCancelEnabled: true,
       };

x-pack/solutions/security/plugins/security_solution/server/config.mock.ts

@@ -13,7 +13,7 @@ import type { ConfigType } from './config';
 import { duration } from 'moment';
 
 export const createMockConfig = (): ConfigType => {
-  const enableExperimental: Array<keyof ExperimentalFeatures> = ['responseActionUploadEnabled'];
+  const enableExperimental: Array<keyof ExperimentalFeatures> = [];
 
   return {
     [SIGNALS_INDEX_KEY]: DEFAULT_SIGNALS_INDEX,