Skip to content

Commit a8579bb

Browse files
authored
Make saved_objects_tagging plugin shared (#205695)
## Summary So that it can be used from `streams_app` (o11y). See #204309 Steps to relocate: 1. Fetch latest `main` 2. Update the `group` and/or `visibility` in the module's manifest. 3. Run `node scripts/relocate --moveOnly @kbn/saved-objects-tagging-plugin`
1 parent 49b477d commit a8579bb

File tree

171 files changed

+19
-17
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

171 files changed

+19
-17
lines changed

.github/CODEOWNERS

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -853,7 +853,6 @@ x-pack/platform/plugins/private/remote_clusters @elastic/kibana-management
853853
x-pack/platform/plugins/private/reporting @elastic/appex-sharedux
854854
x-pack/platform/plugins/private/rollup @elastic/kibana-management
855855
x-pack/platform/plugins/private/runtime_fields @elastic/kibana-management
856-
x-pack/platform/plugins/private/saved_objects_tagging @elastic/appex-sharedux
857856
x-pack/platform/plugins/private/snapshot_restore @elastic/kibana-management
858857
x-pack/platform/plugins/private/telemetry_collection_xpack @elastic/kibana-core
859858
x-pack/platform/plugins/private/transform @elastic/ml-ui
@@ -893,6 +892,7 @@ x-pack/platform/plugins/shared/notifications @elastic/appex-sharedux
893892
x-pack/platform/plugins/shared/observability_solution/observability_ai_assistant @elastic/obs-ai-assistant
894893
x-pack/platform/plugins/shared/osquery @elastic/security-defend-workflows
895894
x-pack/platform/plugins/shared/rule_registry @elastic/response-ops @elastic/obs-ux-management-team
895+
x-pack/platform/plugins/shared/saved_objects_tagging @elastic/appex-sharedux
896896
x-pack/platform/plugins/shared/screenshotting @elastic/kibana-reporting-services
897897
x-pack/platform/plugins/shared/searchprofiler @elastic/kibana-management
898898
x-pack/platform/plugins/shared/security @elastic/kibana-security
@@ -3233,7 +3233,7 @@ x-pack/platform/plugins/private/remote_clusters @elastic/kibana-management
32333233
x-pack/platform/plugins/private/reporting @elastic/appex-sharedux
32343234
x-pack/platform/plugins/private/rollup @elastic/kibana-management
32353235
x-pack/platform/plugins/private/runtime_fields @elastic/kibana-management
3236-
x-pack/platform/plugins/private/saved_objects_tagging @elastic/appex-sharedux
3236+
x-pack/platform/plugins/shared/saved_objects_tagging @elastic/appex-sharedux
32373237
x-pack/platform/plugins/private/snapshot_restore @elastic/kibana-management
32383238
x-pack/platform/plugins/private/telemetry_collection_xpack @elastic/kibana-core
32393239
x-pack/platform/plugins/private/transform @elastic/ml-ui

docs/developer/plugin-list.asciidoc

Lines changed: 1 addition & 1 deletion

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -789,7 +789,7 @@
789789
"@kbn/saved-objects-plugin": "link:src/platform/plugins/shared/saved_objects",
790790
"@kbn/saved-objects-settings": "link:packages/kbn-saved-objects-settings",
791791
"@kbn/saved-objects-tagging-oss-plugin": "link:src/platform/plugins/shared/saved_objects_tagging_oss",
792-
"@kbn/saved-objects-tagging-plugin": "link:x-pack/platform/plugins/private/saved_objects_tagging",
792+
"@kbn/saved-objects-tagging-plugin": "link:x-pack/platform/plugins/shared/saved_objects_tagging",
793793
"@kbn/saved-search-component": "link:packages/kbn-saved-search-component",
794794
"@kbn/saved-search-plugin": "link:src/platform/plugins/shared/saved_search",
795795
"@kbn/screenshot-mode-example-plugin": "link:examples/screenshot_mode_example",

packages/kbn-relocate/utils/relocate.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,12 +92,14 @@ export const calculateModuleTargetFolder = (module: Package): string => {
9292
};
9393

9494
export const isInTargetFolder = (module: Package, log: ToolingLog): boolean => {
95-
if (!module.group || module.group === 'common' || !module.visibility) {
95+
const { group, visibility } = module.manifest;
96+
97+
if (!group || group === 'common' || !visibility) {
9698
log.warning(`The module '${module.id}' is missing the group/visibility information`);
9799
return false;
98100
}
99101

100-
const baseTargetFolders = TARGET_FOLDERS[`${module.group}:${module.visibility}`];
102+
const baseTargetFolders = TARGET_FOLDERS[`${group}:${visibility}`];
101103
const baseTargetFolder = baseTargetFolders.find((candidate) => {
102104
return module.directory.includes(candidate);
103105
});

tsconfig.base.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1548,8 +1548,8 @@
15481548
"@kbn/saved-objects-settings/*": ["packages/kbn-saved-objects-settings/*"],
15491549
"@kbn/saved-objects-tagging-oss-plugin": ["src/platform/plugins/shared/saved_objects_tagging_oss"],
15501550
"@kbn/saved-objects-tagging-oss-plugin/*": ["src/platform/plugins/shared/saved_objects_tagging_oss/*"],
1551-
"@kbn/saved-objects-tagging-plugin": ["x-pack/platform/plugins/private/saved_objects_tagging"],
1552-
"@kbn/saved-objects-tagging-plugin/*": ["x-pack/platform/plugins/private/saved_objects_tagging/*"],
1551+
"@kbn/saved-objects-tagging-plugin": ["x-pack/platform/plugins/shared/saved_objects_tagging"],
1552+
"@kbn/saved-objects-tagging-plugin/*": ["x-pack/platform/plugins/shared/saved_objects_tagging/*"],
15531553
"@kbn/saved-search-component": ["packages/kbn-saved-search-component"],
15541554
"@kbn/saved-search-component/*": ["packages/kbn-saved-search-component/*"],
15551555
"@kbn/saved-search-plugin": ["src/platform/plugins/shared/saved_search"],

x-pack/.i18nrc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@
159159
"xpack.snapshotRestore": "platform/plugins/private/snapshot_restore",
160160
"xpack.spaces": "platform/plugins/shared/spaces",
161161
"xpack.savedObjectsTagging": [
162-
"platform/plugins/private/saved_objects_tagging"
162+
"platform/plugins/shared/saved_objects_tagging"
163163
],
164164
"xpack.taskManager": "legacy/platform/plugins/shared/task_manager",
165165
"xpack.threatIntelligence": "solutions/security/plugins/threat_intelligence",

x-pack/platform/plugins/private/saved_objects_tagging/README.md renamed to x-pack/platform/plugins/shared/saved_objects_tagging/README.md

Lines changed: 2 additions & 2 deletions

0 commit comments

Comments
 (0)