Skip to content

Commit ac0ed90

Browse files
authored
[Discover] Fix search session rename error in dev (#218363) (#226757)
## Summary Closes #218363 Updating a search session returns an `updated_by` key that wasn't defined in the `searchSessionsUpdateSchema`. While in dev the `core_versioned_route` runs some response validations and was complaining that the key wasn't defined there. --- Before https://github.com/user-attachments/assets/4e1afa28-6115-440f-84fb-4b524ea3b7b9 After https://github.com/user-attachments/assets/d1ec9a7d-dfc7-4cdb-9891-9fe99c3fd2cf ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
1 parent f077066 commit ac0ed90

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/platform/plugins/shared/data/server/search/routes/response_schema.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ export const searchSessionsUpdateSchema = () =>
6868
id: schema.string(),
6969
type: schema.string(),
7070
updated_at: schema.maybe(schema.string()),
71+
updated_by: schema.maybe(schema.string()),
7172
version: schema.maybe(schema.string()),
7273
namespaces: schema.maybe(schema.arrayOf(schema.string())),
7374
references: schema.maybe(referencesSchema),

0 commit comments

Comments
 (0)