Skip to content

Commit b71581b

Browse files
[8.19] [Discover][Trace waterfall] Update link to relate errors to use QSTR (#224637) (#224701)
# Backport This will backport the following commits from `main` to `8.19`: - [[Discover][Trace waterfall] Update link to relate errors to use QSTR (#224637)](#224637) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Irene Blanco","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-06-20T13:39:36Z","message":"[Discover][Trace waterfall] Update link to relate errors to use QSTR (#224637)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/224596\n\nThe “View related errors” link in the full-screen waterfall was\nresolving to an invalid ES|QL query in some specific scenarios (it\nworked fine in edge-oblt, for example).\n\nTo work around this and make the query less restrictive for ES|QL, we’ve\nupdated it to use `QSTR` instead. It provides the same type of search\nand gives us the expected results without triggering errors.\n\n**Before**\n![Screen Recording 2025-06-20 at 09 46\n13](https://github.com/user-attachments/assets/4d1c0c19-dbc0-42b2-aba9-194f121eb1c5)\n**After**\n![Screen Recording 2025-06-20 at 09 43\n32](https://github.com/user-attachments/assets/69e0f580-84b8-4c0e-93e7-ebc907e975b0)\n\n\n## How to test\n\n- Enable the discover profiles by adding this to the` kibana.yml `file:\n```discover.experimental.enabledProfiles:\n - observability-traces-data-source-profile\n - observability-traces-transaction-document-profile\n - observability-traces-span-document-profile\n```\n- Make sure your space has Observability as Solution View.\n- Open Discover and query a trace with errors\n- Open any flyout and go to the full screen waterfall\n- Click on \"View related links\" on any of the nodes","sha":"88e32532ee7f4b3fa3c85bd415090cc5aa5c3f56","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-infra_services","backport:version","v9.1.0","v8.19.0"],"title":"[Discover][Trace waterfall] Update link to relate errors to use QSTR","number":224637,"url":"https://github.com/elastic/kibana/pull/224637","mergeCommit":{"message":"[Discover][Trace waterfall] Update link to relate errors to use QSTR (#224637)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/224596\n\nThe “View related errors” link in the full-screen waterfall was\nresolving to an invalid ES|QL query in some specific scenarios (it\nworked fine in edge-oblt, for example).\n\nTo work around this and make the query less restrictive for ES|QL, we’ve\nupdated it to use `QSTR` instead. It provides the same type of search\nand gives us the expected results without triggering errors.\n\n**Before**\n![Screen Recording 2025-06-20 at 09 46\n13](https://github.com/user-attachments/assets/4d1c0c19-dbc0-42b2-aba9-194f121eb1c5)\n**After**\n![Screen Recording 2025-06-20 at 09 43\n32](https://github.com/user-attachments/assets/69e0f580-84b8-4c0e-93e7-ebc907e975b0)\n\n\n## How to test\n\n- Enable the discover profiles by adding this to the` kibana.yml `file:\n```discover.experimental.enabledProfiles:\n - observability-traces-data-source-profile\n - observability-traces-transaction-document-profile\n - observability-traces-span-document-profile\n```\n- Make sure your space has Observability as Solution View.\n- Open Discover and query a trace with errors\n- Open any flyout and go to the full screen waterfall\n- Click on \"View related links\" on any of the nodes","sha":"88e32532ee7f4b3fa3c85bd415090cc5aa5c3f56"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224637","number":224637,"mergeCommit":{"message":"[Discover][Trace waterfall] Update link to relate errors to use QSTR (#224637)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/224596\n\nThe “View related errors” link in the full-screen waterfall was\nresolving to an invalid ES|QL query in some specific scenarios (it\nworked fine in edge-oblt, for example).\n\nTo work around this and make the query less restrictive for ES|QL, we’ve\nupdated it to use `QSTR` instead. It provides the same type of search\nand gives us the expected results without triggering errors.\n\n**Before**\n![Screen Recording 2025-06-20 at 09 46\n13](https://github.com/user-attachments/assets/4d1c0c19-dbc0-42b2-aba9-194f121eb1c5)\n**After**\n![Screen Recording 2025-06-20 at 09 43\n32](https://github.com/user-attachments/assets/69e0f580-84b8-4c0e-93e7-ebc907e975b0)\n\n\n## How to test\n\n- Enable the discover profiles by adding this to the` kibana.yml `file:\n```discover.experimental.enabledProfiles:\n - observability-traces-data-source-profile\n - observability-traces-transaction-document-profile\n - observability-traces-span-document-profile\n```\n- Make sure your space has Observability as Solution View.\n- Open Discover and query a trace with errors\n- Open any flyout and go to the full screen waterfall\n- Click on \"View related links\" on any of the nodes","sha":"88e32532ee7f4b3fa3c85bd415090cc5aa5c3f56"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Irene Blanco <[email protected]>
1 parent fb7336e commit b71581b

File tree

1 file changed

+1
-1
lines changed
  • src/platform/plugins/shared/unified_doc_viewer/public/components/observability/traces/components/full_screen_waterfall

1 file changed

+1
-1
lines changed

src/platform/plugins/shared/unified_doc_viewer/public/components/observability/traces/components/full_screen_waterfall/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export const FullScreenWaterfall = ({
7373
filters: [],
7474
query: {
7575
language: 'kuery',
76-
esql: `FROM ${indexes.apm.errors},${indexes.logs} | WHERE trace.id == "${traceId}" AND span.id == "${docId}"`,
76+
esql: `FROM ${indexes.apm.errors},${indexes.logs} | WHERE QSTR("trace.id:${traceId} AND span.id:${docId}")`,
7777
},
7878
});
7979

0 commit comments

Comments
 (0)