Skip to content

Commit bcdf942

Browse files
SoniaSanzVSoniaSanzV
authored
Add waitUntilLoadingHasFinished in failing tests (#205485)
Fixes: #205535 Fixes: #205514 Fixes: #205498 Fixes: #205464 Fixes: #205456 Fixes: #205453 Fixes: #205450 Fixes: #205412 Fixes: #205410 Fixes: #205401 Fixes: #205400 Fixes: #205399 Fixes: #205350 Fixes: #205349 Fixes: #205316 Fixes: #205288 Fixes: #205287 ## Summary It seems that the step tabs are not loading fast enough for the tests to find the expected element in a [bunch of test](https://github.com/elastic/kibana/issues?q=is%3Aopen%20label%3A%22Team%3AKibana%20Management%22%20label%3A%22failed-test%22%20created%3A%3E%40today-1w%20). This PR attempt to fix it. It also adds the `data-test-subj="indexModeValue"` tag in `TabSummary` that was missing.
1 parent 5c13e90 commit bcdf942

File tree

5 files changed

+31
-51
lines changed

5 files changed

+31
-51
lines changed

‎x-pack/platform/plugins/shared/index_management/public/application/sections/home/template_list/template_details/tabs/tab_summary.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ export const TabSummary: React.FunctionComponent<Props> = ({ templateDetails })
234234
defaultMessage="Index mode"
235235
/>
236236
</EuiDescriptionListTitle>
237-
<EuiDescriptionListDescription>
237+
<EuiDescriptionListDescription data-test-subj="indexModeValue">
238238
{indexModeLabels[indexMode]}
239239
</EuiDescriptionListDescription>
240240
</>

‎x-pack/test/functional/apps/index_management/data_streams_tab/data_streams_tab.ts‎

Lines changed: 13 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -282,6 +282,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
282282

283283
// Click update template
284284
await pageObjects.indexManagement.clickNextButton();
285+
await pageObjects.header.waitUntilLoadingHasFinished();
285286

286287
// Verify index mode and close detail tab
287288
expect(await testSubjects.getVisibleText('indexModeValue')).to.be(indexModeName);
@@ -322,11 +323,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
322323

323324
await changeIndexMode('index_mode_logsdb');
324325
// Navigate to the last step of the wizard
325-
await testSubjects.click('nextButton');
326-
await testSubjects.click('nextButton');
327-
await testSubjects.click('nextButton');
328-
await testSubjects.click('nextButton');
329-
await testSubjects.click('nextButton');
326+
await testSubjects.click('formWizardStep-5');
327+
await pageObjects.header.waitUntilLoadingHasFinished();
330328

331329
await verifyModeHasBeenChanged(INDEX_MODE.LOGSDB);
332330
});
@@ -339,11 +337,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
339337

340338
await changeIndexMode('index_mode_standard');
341339
// Navigate to the last step of the wizard
342-
await testSubjects.click('nextButton');
343-
await testSubjects.click('nextButton');
344-
await testSubjects.click('nextButton');
345-
await testSubjects.click('nextButton');
346-
await testSubjects.click('nextButton');
340+
await testSubjects.click('formWizardStep-5');
341+
await pageObjects.header.waitUntilLoadingHasFinished();
347342

348343
await verifyModeHasBeenChanged(INDEX_MODE.STANDARD);
349344
});
@@ -357,16 +352,15 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
357352

358353
await changeIndexMode('index_mode_logsdb');
359354

360-
await testSubjects.click('nextButton');
361-
await testSubjects.click('nextButton');
355+
await testSubjects.click('formWizardStep-2');
356+
await pageObjects.header.waitUntilLoadingHasFinished();
362357
// Modify Index settings
363358
await testSubjects.setValue('kibanaCodeEditor', '{}', {
364359
clearWithKeyboard: true,
365360
});
366361
// Navigate to the last step of the wizard
367-
await testSubjects.click('nextButton');
368-
await testSubjects.click('nextButton');
369-
await testSubjects.click('nextButton');
362+
await testSubjects.click('formWizardStep-5');
363+
await pageObjects.header.waitUntilLoadingHasFinished();
370364

371365
await verifyModeHasBeenChanged(INDEX_MODE.LOGSDB);
372366
});
@@ -379,8 +373,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
379373

380374
await changeIndexMode('index_mode_time_series');
381375

382-
await testSubjects.click('nextButton');
383-
await testSubjects.click('nextButton');
376+
await testSubjects.click('formWizardStep-2');
377+
await pageObjects.header.waitUntilLoadingHasFinished();
384378
// Modify Index settings
385379
await testSubjects.setValue(
386380
'kibanaCodeEditor',
@@ -390,9 +384,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
390384
}
391385
);
392386
// Navigate to the last step of the wizard
393-
await testSubjects.click('nextButton');
394-
await testSubjects.click('nextButton');
395-
await testSubjects.click('nextButton');
387+
await testSubjects.click('formWizardStep-5');
388+
await pageObjects.header.waitUntilLoadingHasFinished();
396389

397390
await verifyModeHasBeenChanged(INDEX_MODE.TIME_SERIES);
398391
});

‎x-pack/test/functional/apps/index_management/index_templates_tab/index_template_tab.ts‎

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
4747
await testSubjects.click('show-filters-button');
4848
await testSubjects.click('filter-option-h');
4949
// Navigate to the last step of the wizard
50-
await testSubjects.click('nextButton');
51-
await testSubjects.click('nextButton');
52-
await testSubjects.click('nextButton');
53-
await testSubjects.click('nextButton');
54-
await testSubjects.click('nextButton');
50+
await testSubjects.click('formWizardStep-5');
51+
await pageObjects.header.waitUntilLoadingHasFinished();
5552

5653
expect(await testSubjects.getVisibleText('lifecycleValue')).to.be('7 hours');
5754

@@ -71,11 +68,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
7168
await testSubjects.click('index_mode_logsdb');
7269

7370
// Navigate to the last step of the wizard
74-
await testSubjects.click('nextButton');
75-
await testSubjects.click('nextButton');
76-
await testSubjects.click('nextButton');
77-
await testSubjects.click('nextButton');
78-
await testSubjects.click('nextButton');
71+
await testSubjects.click('formWizardStep-5');
72+
await pageObjects.header.waitUntilLoadingHasFinished();
7973

8074
expect(await testSubjects.exists('indexModeTitle')).to.be(true);
8175
expect(await testSubjects.getVisibleText('indexModeValue')).to.be('LogsDB');

‎x-pack/test_serverless/functional/test_suites/common/management/index_management/data_streams.ts‎

Lines changed: 11 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
199199

200200
// Click update template
201201
await pageObjects.indexManagement.clickNextButton();
202+
await pageObjects.header.waitUntilLoadingHasFinished();
202203

203204
// Verify index mode and close detail tab
204205
expect(await testSubjects.getVisibleText('indexModeValue')).to.be(indexModeName);
@@ -246,11 +247,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
246247

247248
await changeIndexMode('index_mode_logsdb');
248249
// Navigate to the last step of the wizard
249-
await testSubjects.click('nextButton');
250-
await testSubjects.click('nextButton');
251-
await testSubjects.click('nextButton');
252-
await testSubjects.click('nextButton');
253-
await testSubjects.click('nextButton');
250+
await testSubjects.click('formWizardStep-5');
251+
await pageObjects.header.waitUntilLoadingHasFinished();
254252

255253
await verifyModeHasBeenChanged(INDEX_MODE.LOGSDB);
256254
});
@@ -263,11 +261,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
263261

264262
await changeIndexMode('index_mode_standard');
265263
// Navigate to the last step of the wizard
266-
await testSubjects.click('nextButton');
267-
await testSubjects.click('nextButton');
268-
await testSubjects.click('nextButton');
269-
await testSubjects.click('nextButton');
270-
await testSubjects.click('nextButton');
264+
await testSubjects.click('formWizardStep-5');
265+
await pageObjects.header.waitUntilLoadingHasFinished();
271266

272267
await verifyModeHasBeenChanged(INDEX_MODE.STANDARD);
273268
});
@@ -281,16 +276,14 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
281276

282277
await changeIndexMode('index_mode_logsdb');
283278

284-
await testSubjects.click('nextButton');
285-
await testSubjects.click('nextButton');
279+
await testSubjects.click('formWizardStep-2');
280+
await pageObjects.header.waitUntilLoadingHasFinished();
286281
// Modify Index settings
287282
await testSubjects.setValue('kibanaCodeEditor', '{}', {
288283
clearWithKeyboard: true,
289284
});
290285
// Navigate to the last step of the wizard
291-
await testSubjects.click('nextButton');
292-
await testSubjects.click('nextButton');
293-
await testSubjects.click('nextButton');
286+
await testSubjects.click('formWizardStep-5');
294287

295288
await verifyModeHasBeenChanged(INDEX_MODE.LOGSDB);
296289
});
@@ -303,8 +296,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
303296

304297
await changeIndexMode('index_mode_time_series');
305298

306-
await testSubjects.click('nextButton');
307-
await testSubjects.click('nextButton');
299+
await testSubjects.click('formWizardStep-2');
300+
await pageObjects.header.waitUntilLoadingHasFinished();
308301
// Modify Index settings
309302
await testSubjects.setValue(
310303
'kibanaCodeEditor',
@@ -314,9 +307,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
314307
}
315308
);
316309
// Navigate to the last step of the wizard
317-
await testSubjects.click('nextButton');
318-
await testSubjects.click('nextButton');
319-
await testSubjects.click('nextButton');
310+
await testSubjects.click('formWizardStep-5');
320311

321312
await verifyModeHasBeenChanged(INDEX_MODE.TIME_SERIES);
322313
});

‎x-pack/test_serverless/functional/test_suites/common/management/index_management/index_templates.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,12 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
117117

118118
// Click form summary step and then the submit button
119119
await testSubjects.click('formWizardStep-5');
120+
await pageObjects.header.waitUntilLoadingHasFinished();
120121
expect(await testSubjects.getVisibleText('indexModeValue')).to.be('LogsDB');
121122

122123
// Click update template
123124
await pageObjects.indexManagement.clickNextButton();
125+
await pageObjects.header.waitUntilLoadingHasFinished();
124126

125127
// Close detail tab
126128
expect(await testSubjects.getVisibleText('indexModeValue')).to.be('LogsDB');

0 commit comments

Comments
 (0)