Skip to content

Commit c986220

Browse files
[8.x] [Cloud Security] Fix for Contextual Flyout UI bugs from Bug Hunt (#196393) (#196499)
# Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] Fix for Contextual Flyout UI bugs from Bug Hunt (#196393)](#196393) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rickyanto Ang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-16T08:45:56Z","message":"[Cloud Security] Fix for Contextual Flyout UI bugs from Bug Hunt (#196393)\n\n## Summary\r\n\r\nThis PR is to address the small UI enhancements for Contextual Flyouts\r\n<img width=\"649\" alt=\"Screenshot 2024-10-15 at 10 10 20 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/f4a1dbf1-8800-4060-8674-2318c21a9b58\">\r\n<img width=\"801\" alt=\"Screenshot 2024-10-15 at 10 10 52 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/e2fdfaed-1b2a-4d66-af6e-420cbf1a26c7\">\r\n\r\nList of UI updates:\r\n- Fixed Color for Misconfiguration and Vulneabilities Preview Title\r\n- Fixed Size and Font for Posture Score text in Misconfiguration Preview\r\ncomponent and Vulnerabilities in Vulnerabilities Preview component\r\n- Fixed Size for number in Misconfiguration Preview and Vulnerabilities\r\nPreview component\r\n- Fixed Paddings for Misconfiguration and Vulnerabilities Preview\r\ncomponent\r\n- Fixed Padding between 2 preview components\r\n- Fixed Width size for severity column","sha":"f049dc048d910293ddb880f98b155fb35ce3120f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:prev-minor","v8.16.0"],"title":"[Cloud Security] Fix for Contextual Flyout UI bugs from Bug Hunt","number":196393,"url":"https://github.com/elastic/kibana/pull/196393","mergeCommit":{"message":"[Cloud Security] Fix for Contextual Flyout UI bugs from Bug Hunt (#196393)\n\n## Summary\r\n\r\nThis PR is to address the small UI enhancements for Contextual Flyouts\r\n<img width=\"649\" alt=\"Screenshot 2024-10-15 at 10 10 20 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/f4a1dbf1-8800-4060-8674-2318c21a9b58\">\r\n<img width=\"801\" alt=\"Screenshot 2024-10-15 at 10 10 52 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/e2fdfaed-1b2a-4d66-af6e-420cbf1a26c7\">\r\n\r\nList of UI updates:\r\n- Fixed Color for Misconfiguration and Vulneabilities Preview Title\r\n- Fixed Size and Font for Posture Score text in Misconfiguration Preview\r\ncomponent and Vulnerabilities in Vulnerabilities Preview component\r\n- Fixed Size for number in Misconfiguration Preview and Vulnerabilities\r\nPreview component\r\n- Fixed Paddings for Misconfiguration and Vulnerabilities Preview\r\ncomponent\r\n- Fixed Padding between 2 preview components\r\n- Fixed Width size for severity column","sha":"f049dc048d910293ddb880f98b155fb35ce3120f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196393","number":196393,"mergeCommit":{"message":"[Cloud Security] Fix for Contextual Flyout UI bugs from Bug Hunt (#196393)\n\n## Summary\r\n\r\nThis PR is to address the small UI enhancements for Contextual Flyouts\r\n<img width=\"649\" alt=\"Screenshot 2024-10-15 at 10 10 20 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/f4a1dbf1-8800-4060-8674-2318c21a9b58\">\r\n<img width=\"801\" alt=\"Screenshot 2024-10-15 at 10 10 52 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/e2fdfaed-1b2a-4d66-af6e-420cbf1a26c7\">\r\n\r\nList of UI updates:\r\n- Fixed Color for Misconfiguration and Vulneabilities Preview Title\r\n- Fixed Size and Font for Posture Score text in Misconfiguration Preview\r\ncomponent and Vulnerabilities in Vulnerabilities Preview component\r\n- Fixed Size for number in Misconfiguration Preview and Vulnerabilities\r\nPreview component\r\n- Fixed Paddings for Misconfiguration and Vulnerabilities Preview\r\ncomponent\r\n- Fixed Padding between 2 preview components\r\n- Fixed Width size for severity column","sha":"f049dc048d910293ddb880f98b155fb35ce3120f"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Rickyanto Ang <[email protected]>
1 parent ddcecd6 commit c986220

File tree

4 files changed

+13
-15
lines changed

4 files changed

+13
-15
lines changed

x-pack/plugins/security_solution/public/cloud_security_posture/components/csp_details/vulnerabilities_findings_details_table.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ export const VulnerabilitiesFindingsDetailsTable = memo(({ queryName }: { queryN
154154
'xpack.securitySolution.flyout.left.insights.vulnerability.table.ruleColumnName',
155155
{ defaultMessage: 'CVSS' }
156156
),
157-
width: '12.5%',
157+
width: '15%',
158158
},
159159
{
160160
field: 'vulnerability',
@@ -171,7 +171,7 @@ export const VulnerabilitiesFindingsDetailsTable = memo(({ queryName }: { queryN
171171
'xpack.securitySolution.flyout.left.insights.vulnerability.table.ruleColumnName',
172172
{ defaultMessage: 'Severity' }
173173
),
174-
width: '12.5%',
174+
width: '20%',
175175
},
176176
{
177177
field: 'vulnerability',
@@ -182,7 +182,7 @@ export const VulnerabilitiesFindingsDetailsTable = memo(({ queryName }: { queryN
182182
'xpack.securitySolution.flyout.left.insights.vulnerability.table.ruleColumnName',
183183
{ defaultMessage: 'Package' }
184184
),
185-
width: '50%',
185+
width: '40%',
186186
},
187187
];
188188

x-pack/plugins/security_solution/public/cloud_security_posture/components/entity_insight.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,14 +64,14 @@ export const EntityInsight = <T,>({
6464
insightContent.push(
6565
<>
6666
<MisconfigurationsPreview name={name} fieldName={fieldName} isPreviewMode={isPreviewMode} />
67-
<EuiSpacer size="m" />
67+
<EuiSpacer size="s" />
6868
</>
6969
);
7070
if (isVulnerabilitiesFindingForHost && hasVulnerabilitiesFindings)
7171
insightContent.push(
7272
<>
7373
<VulnerabilitiesPreview name={name} isPreviewMode={isPreviewMode} />
74-
<EuiSpacer size="m" />
74+
<EuiSpacer size="s" />
7575
</>
7676
);
7777
return (

x-pack/plugins/security_solution/public/cloud_security_posture/components/misconfiguration/misconfiguration_preview.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,12 @@ const MisconfigurationPreviewScore = ({
8484
<EuiFlexGroup direction="column" gutterSize="none">
8585
<EuiFlexItem>
8686
<EuiTitle size="s">
87-
<h1>{`${Math.round((passedFindings / (passedFindings + failedFindings)) * 100)}%`}</h1>
87+
<h3>{`${Math.round((passedFindings / (passedFindings + failedFindings)) * 100)}%`}</h3>
8888
</EuiTitle>
8989
</EuiFlexItem>
9090
<EuiFlexItem>
9191
<EuiText
92-
size="m"
92+
size="xs"
9393
css={css`
9494
font-weight: ${euiTheme.font.weight.semiBold};
9595
`}
@@ -225,8 +225,7 @@ export const MisconfigurationsPreview = ({
225225
header={{
226226
iconType: !isPreviewMode && hasMisconfigurationFindings ? 'arrowStart' : '',
227227
title: (
228-
<EuiText
229-
size="xs"
228+
<EuiTitle
230229
css={css`
231230
font-weight: ${euiTheme.font.weight.semiBold};
232231
`}
@@ -235,7 +234,7 @@ export const MisconfigurationsPreview = ({
235234
id="xpack.securitySolution.flyout.right.insights.misconfigurations.misconfigurationsTitle"
236235
defaultMessage="Misconfigurations"
237236
/>
238-
</EuiText>
237+
</EuiTitle>
239238
),
240239
link: hasMisconfigurationFindings ? link : undefined,
241240
}}

x-pack/plugins/security_solution/public/cloud_security_posture/components/vulnerabilities/vulnerabilities_preview.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,12 @@ const VulnerabilitiesCount = ({
4848
<EuiFlexGroup direction="column" gutterSize="none">
4949
<EuiFlexItem>
5050
<EuiTitle size="s">
51-
<h1>{vulnerabilitiesTotal}</h1>
51+
<h3>{vulnerabilitiesTotal}</h3>
5252
</EuiTitle>
5353
</EuiFlexItem>
5454
<EuiFlexItem>
5555
<EuiText
56-
size="m"
56+
size="xs"
5757
css={css`
5858
font-weight: ${euiTheme.font.weight.semiBold};
5959
`}
@@ -162,8 +162,7 @@ export const VulnerabilitiesPreview = ({
162162
header={{
163163
iconType: !isPreviewMode && hasVulnerabilitiesFindings ? 'arrowStart' : '',
164164
title: (
165-
<EuiText
166-
size="xs"
165+
<EuiTitle
167166
css={css`
168167
font-weight: ${euiTheme.font.weight.semiBold};
169168
`}
@@ -172,7 +171,7 @@ export const VulnerabilitiesPreview = ({
172171
id="xpack.securitySolution.flyout.right.insights.vulnerabilities.vulnerabilitiesTitle"
173172
defaultMessage="Vulnerabilities"
174173
/>
175-
</EuiText>
174+
</EuiTitle>
176175
),
177176
link,
178177
}}

0 commit comments

Comments
 (0)