Commit cab9883
authored
[Reporting] re-allow multi-page Canvas reports (#255022)
resolves #252838
## Summary
A previous PR - #245330 - added an
incorrect validation on the `locatorParams` parameter, of a maximum of
one entry in the array. Previously there was no limit.
Canvas uses multiple `locatorParams` for multi-page workpads, and so
these ended up failing the validation, and would not generate a report.
This PR changes the limit from 1 to 100.
The validation was added in 9.3.0, so only needs to be backported to the
9.3 branch ...
### To Verify
Create a multi-page Canvas workpad, and generate a PDF for it. Canvas is
not enabled in Kibana by default, anymore, but some instructions to
enable it are here: https://support.elastic.co/knowledge/9f434635
## Release note
Fixes a problem generating a report with multi-page Canvas workpads.
### Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.1 parent 40cac4c commit cab9883
File tree
2 files changed
+18
-1
lines changed- x-pack/platform/plugins/private/reporting/server/routes/common/request_handler
2 files changed
+18
-1
lines changedLines changed: 17 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
365 | 365 | | |
366 | 366 | | |
367 | 367 | | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
368 | 385 | | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
| 98 | + | |
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
| |||
0 commit comments