Skip to content

Commit cacfa7f

Browse files
authored
[7.17][build] Standardize docker image tarball suffixes for architectures (#224969) (#225355)
#224969
1 parent e1901b6 commit cacfa7f

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

.buildkite/scripts/steps/artifacts/publish.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ function download {
1616
mkdir -p target
1717
cd target
1818

19-
download "kibana-$FULL_VERSION-docker-image.tar.gz"
20-
download "kibana-$FULL_VERSION-docker-image-aarch64.tar.gz"
21-
download "kibana-ubi-$FULL_VERSION-docker-image.tar.gz"
19+
download "kibana-$FULL_VERSION-docker-image-amd64.tar.gz"
20+
download "kibana-$FULL_VERSION-docker-image-arm64.tar.gz"
21+
download "kibana-ubi-$FULL_VERSION-docker-image-amd64.tar.gz"
2222

2323
download "kibana-$FULL_VERSION-arm64.deb"
2424
download "kibana-$FULL_VERSION-amd64.deb"

.buildkite/scripts/steps/package_testing/build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ set -euo pipefail
66

77
node scripts/build --all-platforms --debug
88

9-
DOCKER_FILE="kibana-$KIBANA_PKG_VERSION-SNAPSHOT-docker-image.tar.gz"
9+
DOCKER_FILE="kibana-$KIBANA_PKG_VERSION-SNAPSHOT-docker-image-amd64.tar.gz"
1010

1111
cd target
1212
buildkite-agent artifact upload "./$DOCKER_FILE;./*.deb;./*.rpm"

.buildkite/scripts/steps/package_testing/test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ elif [[ "$TEST_PACKAGE" == "rpm" ]]; then
1515
buildkite-agent artifact download 'kibana-*-x86_64.rpm' . --build "${KIBANA_BUILD_ID:-$BUILDKITE_BUILD_ID}"
1616
KIBANA_IP_ADDRESS="192.168.56.6"
1717
elif [[ "$TEST_PACKAGE" == "docker" ]]; then
18-
buildkite-agent artifact download "kibana-$KIBANA_PKG_VERSION*-docker-image.tar.gz" . --build "${KIBANA_BUILD_ID:-$BUILDKITE_BUILD_ID}"
18+
buildkite-agent artifact download "kibana-$KIBANA_PKG_VERSION*-docker-image-amd64.tar.gz" . --build "${KIBANA_BUILD_ID:-$BUILDKITE_BUILD_ID}"
1919
KIBANA_IP_ADDRESS="192.168.56.7"
2020
fi
2121
cd ..

src/dev/build/tasks/os_packages/docker_generator/run.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ export async function runDockerGenerator(
6161
const dockerBuildDate = flags.dockerBuildDate || new Date().toISOString();
6262
// That would produce oss, default and default-ubi7
6363
const dockerBuildDir = config.resolveFromRepo('build', 'kibana-docker', `default${imageFlavor}`);
64-
const imageArchitecture = flags.architecture === 'aarch64' ? '-aarch64' : '';
64+
const imageArchitecture = flags.architecture === 'aarch64' ? '-arm64' : '-amd64';
6565
const dockerTargetFilename = config.resolveFromTarget(
6666
`kibana${imageFlavor}-${version}-docker-image${imageArchitecture}.tar.gz`
6767
);

test/package/roles/install_kibana_docker/tasks/main.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
- name: find docker image
22
find:
33
paths: /packages/
4-
patterns: kibana-[0-9]*-docker-image.tar.gz
4+
patterns: kibana-[0-9]*-docker-image-amd64.tar.gz
55
register: kibana_docker
66

77
- name: load image
88
become: yes
99
docker_image:
10-
name: "{{ kibana_docker.files[0].path | basename| regex_replace('kibana-(.*)-docker-image.tar.gz', 'docker.elastic.co/kibana/kibana:\\1') }}"
10+
name: "{{ kibana_docker.files[0].path | basename| regex_replace('kibana-(.*)-docker-image-amd64.tar.gz', 'docker.elastic.co/kibana/kibana:\\1') }}"
1111
load_path: '{{ kibana_docker.files[0].path }}'
1212
timeout: 300
1313
source: load
@@ -17,7 +17,7 @@
1717
become: yes
1818
docker_container:
1919
name: kibana
20-
image: "{{ kibana_docker.files[0].path | basename| regex_replace('kibana-(.*)-docker-image.tar.gz', 'docker.elastic.co/kibana/kibana:\\1') }}"
20+
image: "{{ kibana_docker.files[0].path | basename| regex_replace('kibana-(.*)-docker-image-amd64.tar.gz', 'docker.elastic.co/kibana/kibana:\\1') }}"
2121
network_mode: host
2222
env:
2323
SERVER_HOST: 0.0.0.0

0 commit comments

Comments
 (0)