[8.19] [ObsUX][APM] Add tooltip for exit spans missing destination (#213714) (#219965)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[ObsUX][APM] Add tooltip for exit spans missing destination
(#213714)](#213714)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Miriam","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-03-13T08:45:56Z","message":"[ObsUX][APM]
Add tooltip for exit spans missing destination (#213714)\n\nCloses
https://github.com/elastic/kibana/issues/212638\n\n### Summary\n\nIn
order to help users, support agents and engineers to spot
eventual\nproblems on the Service Map, we want to display a warning on
the exit\nspans that lack the span.destination.service.resource on the
trace\nwaterfall.\n\n\n![image](https://github.com/user-attachments/assets/eee3f962-a91c-49bb-9f06-c989ed8500c5)","sha":"9fb25a155c9d88b0b23ac4264c6d38bead9f544b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:obs-ux-infra_services","v9.1.0","v8.19.0"],"title":"[ObsUX][APM]
Add tooltip for exit spans missing
destination","number":213714,"url":"https://github.com/elastic/kibana/pull/213714","mergeCommit":{"message":"[ObsUX][APM]
Add tooltip for exit spans missing destination (#213714)\n\nCloses
https://github.com/elastic/kibana/issues/212638\n\n### Summary\n\nIn
order to help users, support agents and engineers to spot
eventual\nproblems on the Service Map, we want to display a warning on
the exit\nspans that lack the span.destination.service.resource on the
trace\nwaterfall.\n\n\n![image](https://github.com/user-attachments/assets/eee3f962-a91c-49bb-9f06-c989ed8500c5)","sha":"9fb25a155c9d88b0b23ac4264c6d38bead9f544b"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213714","number":213714,"mergeCommit":{"message":"[ObsUX][APM]
Add tooltip for exit spans missing destination (#213714)\n\nCloses
https://github.com/elastic/kibana/issues/212638\n\n### Summary\n\nIn
order to help users, support agents and engineers to spot
eventual\nproblems on the Service Map, we want to display a warning on
the exit\nspans that lack the span.destination.service.resource on the
trace\nwaterfall.\n\n\n![image](https://github.com/user-attachments/assets/eee3f962-a91c-49bb-9f06-c989ed8500c5)","sha":"9fb25a155c9d88b0b23ac4264c6d38bead9f544b"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Miriam <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>

Author: 3 people

x-pack/solutions/observability/plugins/apm/common/waterfall/typings.ts

@@ -63,6 +63,7 @@ export interface WaterfallSpan {
     sync?: boolean;
     duration: { us: number };
     links?: SpanLink[];
+    destination?: { service?: { resource?: string } };
   };
   transaction?: {
     id?: string;

x-pack/solutions/observability/plugins/apm/public/components/app/transaction_details/waterfall_with_summary/waterfall_container/waterfall/span_missing_destination_tooltip.tsx

@@ -0,0 +1,28 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+import { EuiIcon, EuiToolTip } from '@elastic/eui';
+import React from 'react';
+import { i18n } from '@kbn/i18n';
+
+export function SpanMissingDestinationTooltip() {
+  return (
+    <EuiToolTip
+      title={i18n.translate('xpack.apm.waterfallItem.euiToolTip.spanMissingDestinationLabel', {
+        defaultMessage: 'Missing destination',
+      })}
+      content={i18n.translate(
+        'xpack.apm.waterfallItem.euiToolTip.spanMissingDestinationDescription',
+        {
+          defaultMessage:
+            'This exit span is missing the span.destination.service.resource field which might prevent linking it to downstream transactions on features that depend on this information. i.e.: Service Map. Make sure the instrumentation of this exit span follows OTel Semantic Conventions',
+        }
+      )}
+    >
+      <EuiIcon type="warning" size="s" color="danger" />
+    </EuiToolTip>
+  );
+}

x-pack/solutions/observability/plugins/apm/public/components/app/transaction_details/waterfall_with_summary/waterfall_container/waterfall/waterfall_helpers/waterfall_helpers.ts

@@ -9,6 +9,7 @@ import { euiPaletteColorBlind } from '@elastic/eui';
 import type { Dictionary } from 'lodash';
 import { first, flatten, groupBy, isEmpty, sortBy, uniq } from 'lodash';
 import { ProcessorEvent } from '@kbn/observability-plugin/common';
+import { isOpenTelemetryAgentName } from '../../../../../../../../common/agent_name';
 import type { CriticalPathSegment } from '../../../../../../../../common/critical_path/types';
 import type { APIReturnType } from '../../../../../../../services/rest/create_call_apm_api';
 import type { Transaction } from '../../../../../../../../typings/es_schemas/ui/transaction';
@@ -75,6 +76,7 @@ interface IWaterfallItemBase<TDocument, TDoctype> {
   legendValues: Record<WaterfallLegendType, string>;
   spanLinksCount: SpanLinksCount;
   isOrphan?: boolean;
+  missingDestination?: boolean;
 }
 
 export type IWaterfallError = Omit<
@@ -594,6 +596,18 @@ function buildTree({
           hasInitializedChildren: false,
         };
 
+        // It is missing a destination when a child (currentNode) is a transaction
+        // and its parent (node) is a span without destination for Otel agents.
+
+        if (
+          currentNode.item.docType === 'transaction' &&
+          node.item.docType === 'span' &&
+          !node.item.doc.span?.destination?.service?.resource &&
+          isOpenTelemetryAgentName(node.item.doc.agent.name)
+        ) {
+          node.item.missingDestination = true;
+        }
+
         node.children.push(currentNode);
         queue.push(currentNode);
       });

x-pack/solutions/observability/plugins/apm/public/components/app/transaction_details/waterfall_with_summary/waterfall_container/waterfall/waterfall_item.tsx

@@ -24,6 +24,7 @@ import { FailureBadge } from './failure_badge';
 import { useApmRouter } from '../../../../../../hooks/use_apm_router';
 import { useAnyOfApmParams } from '../../../../../../hooks/use_apm_params';
 import { OrphanItemTooltipIcon } from './orphan_item_tooltip_icon';
+import { SpanMissingDestinationTooltip } from './span_missing_destination_tooltip';
 
 type ItemType = 'transaction' | 'span' | 'error';
 
@@ -286,6 +287,7 @@ export function WaterfallItem({
           <PrefixIcon item={item} />
         </SpanActionToolTip>
         {item.isOrphan ? <OrphanItemTooltipIcon docType={item.docType} /> : null}
+        {item.missingDestination ? <SpanMissingDestinationTooltip /> : null}
         <HttpStatusCode item={item} />
         <NameLabel item={item} />
 

x-pack/solutions/observability/plugins/apm/server/routes/traces/__snapshots__/queries.test.ts.snap

@@ -37,6 +37,7 @@ import {
   SPAN_COMPOSITE_COMPRESSION_STRATEGY,
   SPAN_COMPOSITE_COUNT,
   SPAN_COMPOSITE_SUM,
+  SPAN_DESTINATION_SERVICE_RESOURCE,
   SPAN_DURATION,
   SPAN_ID,
   SPAN_LINKS,
@@ -105,6 +106,7 @@ export async function getTraceItems({
     PARENT_ID,
     TRANSACTION_ID,
     SPAN_ID,
+    SPAN_DESTINATION_SERVICE_RESOURCE,
     ERROR_CULPRIT,
     ERROR_LOG_MESSAGE,
     ERROR_EXC_MESSAGE,
@@ -303,6 +305,7 @@ async function getTraceDocsPerPage({
     SPAN_COMPOSITE_COMPRESSION_STRATEGY,
     SPAN_COMPOSITE_SUM,
     SPAN_SYNC,
+    SPAN_DESTINATION_SERVICE_RESOURCE,
     CHILD_ID,
     OTEL_SPAN_LINKS_SPAN_ID,
     OTEL_SPAN_LINKS_TRACE_ID,