Commit dbd3c33
authored
# Backport
This will backport the following commits from `main` to `8.19`:
- [[Vega] Change Vega editor inactiveSelectionBackground color in dark
mode to match Monaco Editor dark theme
(#229589)](#229589)
<!--- Backport version: 10.0.1 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)
<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-07-29T12:39:09Z","message":"[Vega]
Change Vega editor inactiveSelectionBackground color in dark mode to
match Monaco Editor dark theme (#229589)\n\n## Summary\n\nThis PR fixes
wrong color being used for when you have text selected in\nVega editor
and the editor isn't focused. After the change, the color\nmatches the
default value used in Monaco Editor dark theme.\n\n| Before | After
|\n|--------|-------|\n| <img width=\"373\" height=\"995\"
alt=\"Before\"\nsrc=\"https://github.com/user-attachments/assets/183684db-a1f4-43b4-bc1d-f3c5e9c1193d\"\n/>
| <img width=\"371\" height=\"946\"
alt=\"After\"\nsrc=\"https://github.com/user-attachments/assets/ee965d26-8016-45af-b6f1-1ed86953467c\"\n/>
|\n\nCloses:
#228296","sha":"95a18def87020db328b1bf89369f634395e13879","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Feature:Vega","Team:Visualizations","release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Vega]
Change Vega editor inactiveSelectionBackground color in dark mode to
match Monaco Editor dark
theme","number":229589,"url":"https://github.com/elastic/kibana/pull/229589","mergeCommit":{"message":"[Vega]
Change Vega editor inactiveSelectionBackground color in dark mode to
match Monaco Editor dark theme (#229589)\n\n## Summary\n\nThis PR fixes
wrong color being used for when you have text selected in\nVega editor
and the editor isn't focused. After the change, the color\nmatches the
default value used in Monaco Editor dark theme.\n\n| Before | After
|\n|--------|-------|\n| <img width=\"373\" height=\"995\"
alt=\"Before\"\nsrc=\"https://github.com/user-attachments/assets/183684db-a1f4-43b4-bc1d-f3c5e9c1193d\"\n/>
| <img width=\"371\" height=\"946\"
alt=\"After\"\nsrc=\"https://github.com/user-attachments/assets/ee965d26-8016-45af-b6f1-1ed86953467c\"\n/>
|\n\nCloses:
#228296","sha":"95a18def87020db328b1bf89369f634395e13879"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229589","number":229589,"mergeCommit":{"message":"[Vega]
Change Vega editor inactiveSelectionBackground color in dark mode to
match Monaco Editor dark theme (#229589)\n\n## Summary\n\nThis PR fixes
wrong color being used for when you have text selected in\nVega editor
and the editor isn't focused. After the change, the color\nmatches the
default value used in Monaco Editor dark theme.\n\n| Before | After
|\n|--------|-------|\n| <img width=\"373\" height=\"995\"
alt=\"Before\"\nsrc=\"https://github.com/user-attachments/assets/183684db-a1f4-43b4-bc1d-f3c5e9c1193d\"\n/>
| <img width=\"371\" height=\"946\"
alt=\"After\"\nsrc=\"https://github.com/user-attachments/assets/ee965d26-8016-45af-b6f1-1ed86953467c\"\n/>
|\n\nCloses:
#228296","sha":"95a18def87020db328b1bf89369f634395e13879"}}]}]
BACKPORT-->
1 parent b9ca831 commit dbd3c33
File tree
1 file changed
+36
-1
lines changed- src/platform/plugins/private/vis_types/vega/public/components
1 file changed
+36
-1
lines changedLines changed: 36 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
20 | 23 | | |
21 | 24 | | |
22 | 25 | | |
| |||
48 | 51 | | |
49 | 52 | | |
50 | 53 | | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
51 | 84 | | |
| 85 | + | |
52 | 86 | | |
53 | 87 | | |
54 | 88 | | |
| |||
103 | 137 | | |
104 | 138 | | |
105 | 139 | | |
| 140 | + | |
106 | 141 | | |
107 | 142 | | |
108 | 143 | | |
| |||
0 commit comments