Commit df5b2b6
authored
# Backport
This will backport the following commits from `main` to `8.19`:
- [[APM][Unified Waterfall] Enable telemetry by removing unnecessary
stopPropagation calls and updating data-test-subj attributes
(#229182)](#229182)
<!--- Backport version: 10.0.1 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)
<!--BACKPORT [{"author":{"name":"Irene
Blanco","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-07-25T19:07:23Z","message":"[APM][Unified
Waterfall] Enable telemetry by removing unnecessary stopPropagation
calls and updating data-test-subj attributes (#229182)\n\n##
Summary\n\nRelates to
https://github.com/elastic/kibana/issues/225472\n\nWhile building the
Unified Waterfall, part of the code was inspired by\nthe APM waterfall,
and there were some `e.stopPropagation` calls that\nwere no longer
needed and they were preventing the click event from\nreaching our
EBT.\n\nTo bring those events back and enable telemetry analysis on
waterfall\nusage, the `e.stopPropagation` calls have been removed, and a
few\n`data-test-subj` attributes have been renamed and/or added.\n\nA
minor UI issue with the dependency field was also detected and
fixed\nalong the way.\n\n|Before|After|\n|-|-|\n|<img width=\"1317\"
height=\"969\" alt=\"Screenshot 2025-07-23 at 17 26
11\"\nsrc=\"https://github.com/user-attachments/assets/bfea8171-9430-4480-9664-65d1e6780c61\"\n/>|<img
width=\"1317\" height=\"965\" alt=\"Screenshot 2025-07-23 at 17
28\n27\"\nsrc=\"https://github.com/user-attachments/assets/46ddac58-c723-4ab2-82b7-b6d9ee9996b5\"\n/>|\n\n\n##
How to test\n- Go to Discover in an Observability Solution space\n-
Query traces (`FROM traces-*`)\n- Open any span/transaction flyout\n-
Open the full screen waterfall\n- Open flyout from the waterfall\n-
Check for the sent events, we now have
clicks\n\n---------\n\nCo-authored-by: Cauê Marcondes
<[email protected]>","sha":"46e1b78c9d6d282bd8222f69d4ab692b05cfb25a","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-infra_services","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[APM][Unified
Waterfall] Enable telemetry by removing unnecessary stopPropagation
calls and updating data-test-subj
attributes","number":229182,"url":"https://github.com/elastic/kibana/pull/229182","mergeCommit":{"message":"[APM][Unified
Waterfall] Enable telemetry by removing unnecessary stopPropagation
calls and updating data-test-subj attributes (#229182)\n\n##
Summary\n\nRelates to
https://github.com/elastic/kibana/issues/225472\n\nWhile building the
Unified Waterfall, part of the code was inspired by\nthe APM waterfall,
and there were some `e.stopPropagation` calls that\nwere no longer
needed and they were preventing the click event from\nreaching our
EBT.\n\nTo bring those events back and enable telemetry analysis on
waterfall\nusage, the `e.stopPropagation` calls have been removed, and a
few\n`data-test-subj` attributes have been renamed and/or added.\n\nA
minor UI issue with the dependency field was also detected and
fixed\nalong the way.\n\n|Before|After|\n|-|-|\n|<img width=\"1317\"
height=\"969\" alt=\"Screenshot 2025-07-23 at 17 26
11\"\nsrc=\"https://github.com/user-attachments/assets/bfea8171-9430-4480-9664-65d1e6780c61\"\n/>|<img
width=\"1317\" height=\"965\" alt=\"Screenshot 2025-07-23 at 17
28\n27\"\nsrc=\"https://github.com/user-attachments/assets/46ddac58-c723-4ab2-82b7-b6d9ee9996b5\"\n/>|\n\n\n##
How to test\n- Go to Discover in an Observability Solution space\n-
Query traces (`FROM traces-*`)\n- Open any span/transaction flyout\n-
Open the full screen waterfall\n- Open flyout from the waterfall\n-
Check for the sent events, we now have
clicks\n\n---------\n\nCo-authored-by: Cauê Marcondes
<[email protected]>","sha":"46e1b78c9d6d282bd8222f69d4ab692b05cfb25a"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229182","number":229182,"mergeCommit":{"message":"[APM][Unified
Waterfall] Enable telemetry by removing unnecessary stopPropagation
calls and updating data-test-subj attributes (#229182)\n\n##
Summary\n\nRelates to
https://github.com/elastic/kibana/issues/225472\n\nWhile building the
Unified Waterfall, part of the code was inspired by\nthe APM waterfall,
and there were some `e.stopPropagation` calls that\nwere no longer
needed and they were preventing the click event from\nreaching our
EBT.\n\nTo bring those events back and enable telemetry analysis on
waterfall\nusage, the `e.stopPropagation` calls have been removed, and a
few\n`data-test-subj` attributes have been renamed and/or added.\n\nA
minor UI issue with the dependency field was also detected and
fixed\nalong the way.\n\n|Before|After|\n|-|-|\n|<img width=\"1317\"
height=\"969\" alt=\"Screenshot 2025-07-23 at 17 26
11\"\nsrc=\"https://github.com/user-attachments/assets/bfea8171-9430-4480-9664-65d1e6780c61\"\n/>|<img
width=\"1317\" height=\"965\" alt=\"Screenshot 2025-07-23 at 17
28\n27\"\nsrc=\"https://github.com/user-attachments/assets/46ddac58-c723-4ab2-82b7-b6d9ee9996b5\"\n/>|\n\n\n##
How to test\n- Go to Discover in an Observability Solution space\n-
Query traces (`FROM traces-*`)\n- Open any span/transaction flyout\n-
Open the full screen waterfall\n- Open flyout from the waterfall\n-
Check for the sent events, we now have
clicks\n\n---------\n\nCo-authored-by: Cauê Marcondes
<[email protected]>","sha":"46e1b78c9d6d282bd8222f69d4ab692b05cfb25a"}}]}]
BACKPORT-->
1 parent b7b1e53 commit df5b2b6
File tree
2 files changed
+20
-19
lines changed2 files changed
+20
-19
lines changedLines changed: 15 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
26 | 40 | | |
27 | 41 | | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
| 42 | + | |
37 | 43 | | |
38 | 44 | | |
39 | 45 | | |
| |||
Lines changed: 5 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
49 | 50 | | |
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
53 | | - | |
| 54 | + | |
54 | 55 | | |
55 | | - | |
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
| 81 | + | |
81 | 82 | | |
82 | 83 | | |
83 | 84 | | |
| |||
86 | 87 | | |
87 | 88 | | |
88 | 89 | | |
89 | | - | |
| 90 | + | |
90 | 91 | | |
91 | 92 | | |
92 | 93 | | |
93 | | - | |
| 94 | + | |
94 | 95 | | |
95 | | - | |
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
| |||
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | 141 | | |
147 | 142 | | |
148 | 143 | | |
| |||
0 commit comments