[Security Solution] fix issue where analyzer is not showing when the newDataViewPickerEnabled feature flag is off (#255182)

PhilippeOberti · web-flow · commit e314aaf64e0e · 2026-02-27T17:46:55.000-06:00
## Summary This somewhat recent [PR](#245712) that was aiming at fixing a bug related to dataViews with analyzer actually introduced another bug. The code added in that previous PR was verifying that the dataView was correctly loaded before showing analyzer, but the check was done only for the `newDataViewPickerEnabled` feature flag turned on... This PR fixes that issue and handles both the `newDataViewPickerEnabled` feature flag on and off. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
diff --git a/x-pack/solutions/security/plugins/security_solution/public/flyout/document_details/left/components/analyze_graph.test.tsx b/x-pack/solutions/security/plugins/security_solution/public/flyout/document_details/left/components/analyze_graph.test.tsx
@@ -26,8 +26,9 @@ import { useIsInvestigateInResolverActionEnabled } from '../../../../detections/
 import { useIsExperimentalFeatureEnabled } from '../../../../common/hooks/use_experimental_features';
 import { useSelectedPatterns } from '../../../../data_view_manager/hooks/use_selected_patterns';
 import { useDataView } from '../../../../data_view_manager/hooks/use_data_view';
-import type { DataView } from '@kbn/data-views-plugin/common';
+import type { DataView, DataViewSpec } from '@kbn/data-views-plugin/common';
 import { createStubDataView } from '@kbn/data-views-plugin/common/data_views/data_view.stub';
+import { useSourcererDataView } from '../../../../sourcerer/containers';
 
 jest.mock('react-router-dom', () => {
   const actual = jest.requireActual('react-router-dom');
@@ -41,6 +42,7 @@ jest.mock(
 );
 jest.mock('../../../../common/hooks/use_experimental_features');
 jest.mock('../../../../data_view_manager/hooks/use_selected_patterns');
+jest.mock('../../../../sourcerer/containers');
 
 const mockUseWhichFlyout = useWhichFlyout as jest.Mock;
 const FLYOUT_KEY = 'securitySolution';
@@ -61,6 +63,7 @@ const NO_ANALYZER_MESSAGE =
 const dataView: DataView = createStubDataView({
   spec: { title: '.alerts-security.alerts-default' },
 });
+const dataViewSpec: DataViewSpec = createStubDataView({ spec: {} }).toSpec();
 
 const renderAnalyzer = (
   contextValue = {
@@ -94,85 +97,160 @@ describe('<AnalyzeGraph />', () => {
     });
   });
 
-  it('renders analyzer graph correctly', () => {
-    const wrapper = renderAnalyzer();
+  describe('newDataViewPickerEnabled true', () => {
+    beforeEach(() => {
+      (useSourcererDataView as jest.Mock).mockReturnValue({});
+    });
 
-    expect(wrapper.getByTestId(ANALYZER_GRAPH_TEST_ID)).toBeInTheDocument();
-  });
+    it('renders analyzer graph correctly', () => {
+      const wrapper = renderAnalyzer();
 
-  it('should render no data message when analyzer is not enabled', () => {
-    (useIsInvestigateInResolverActionEnabled as jest.Mock).mockReturnValue(false);
+      expect(wrapper.getByTestId(ANALYZER_GRAPH_TEST_ID)).toBeInTheDocument();
+    });
 
-    const contextValue = {
-      eventId: 'eventId',
-      scopeId: TableId.test,
-      dataAsNestedObject: {},
-    } as unknown as DocumentDetailsContext;
+    it('should render no data message when analyzer is not enabled', () => {
+      (useIsInvestigateInResolverActionEnabled as jest.Mock).mockReturnValue(false);
 
-    const { container } = renderAnalyzer(contextValue);
+      const contextValue = {
+        eventId: 'eventId',
+        scopeId: TableId.test,
+        dataAsNestedObject: {},
+      } as unknown as DocumentDetailsContext;
 
-    expect(container).toHaveTextContent(NO_ANALYZER_MESSAGE);
-  });
+      const { container } = renderAnalyzer(contextValue);
 
-  it('should show loading spinner while data view is loading', () => {
-    (useDataView as jest.Mock).mockReturnValue({
-      status: 'loading',
+      expect(container).toHaveTextContent(NO_ANALYZER_MESSAGE);
     });
 
-    const { getByTestId } = renderAnalyzer();
+    it('should show loading spinner while data view is loading', () => {
+      (useDataView as jest.Mock).mockReturnValue({
+        status: 'loading',
+      });
 
-    expect(getByTestId(DATA_VIEW_LOADING_TEST_ID)).toBeInTheDocument();
-  });
+      const { getByTestId } = renderAnalyzer();
 
-  it('should show loading spinner while data view is pristine', () => {
-    (useDataView as jest.Mock).mockReturnValue({
-      status: 'pristine',
+      expect(getByTestId(DATA_VIEW_LOADING_TEST_ID)).toBeInTheDocument();
     });
 
-    const { getByTestId } = renderAnalyzer();
+    it('should show loading spinner while data view is pristine', () => {
+      (useDataView as jest.Mock).mockReturnValue({
+        status: 'pristine',
+      });
 
-    expect(getByTestId(DATA_VIEW_LOADING_TEST_ID)).toBeInTheDocument();
-  });
+      const { getByTestId } = renderAnalyzer();
 
-  it('should show error message if data view is error', () => {
-    (useDataView as jest.Mock).mockReturnValue({
-      status: 'error',
+      expect(getByTestId(DATA_VIEW_LOADING_TEST_ID)).toBeInTheDocument();
     });
 
-    const { getByTestId } = renderAnalyzer();
+    it('should show error message if data view is error', () => {
+      (useDataView as jest.Mock).mockReturnValue({
+        status: 'error',
+      });
 
-    expect(getByTestId(DATA_VIEW_ERROR_TEST_ID)).toHaveTextContent(
-      'Unable to retrieve the data view for analyzer'
-    );
-  });
+      const { getByTestId } = renderAnalyzer();
 
-  it('should show error message if data view is ready but no matched indices', () => {
-    (useDataView as jest.Mock).mockReturnValue({
-      status: 'ready',
-      dataView: {
-        ...dataView,
-        hasMatchedIndices: jest.fn().mockReturnValue(false),
-      },
+      expect(getByTestId(DATA_VIEW_ERROR_TEST_ID)).toHaveTextContent(
+        'Unable to retrieve the data view for analyzer'
+      );
+    });
+
+    it('should show error message if data view is ready but no matched indices', () => {
+      (useDataView as jest.Mock).mockReturnValue({
+        status: 'ready',
+        dataView: {
+          ...dataView,
+          hasMatchedIndices: jest.fn().mockReturnValue(false),
+        },
+      });
+
+      const { getByTestId } = renderAnalyzer();
+
+      expect(getByTestId(DATA_VIEW_ERROR_TEST_ID)).toHaveTextContent(
+        'Unable to retrieve the data view for analyzer'
+      );
     });
 
-    const { getByTestId } = renderAnalyzer();
+    it('should open details panel in preview when clicking on view button', () => {
+      const wrapper = renderAnalyzer();
 
-    expect(getByTestId(DATA_VIEW_ERROR_TEST_ID)).toHaveTextContent(
-      'Unable to retrieve the data view for analyzer'
-    );
+      expect(wrapper.getByTestId('resolver:graph-controls:show-panel-button')).toBeInTheDocument();
+      wrapper.getByTestId('resolver:graph-controls:show-panel-button').click();
+      expect(mockFlyoutApi.openPreviewPanel).toBeCalledWith({
+        id: DocumentDetailsAnalyzerPanelKey,
+        params: {
+          resolverComponentInstanceID: `${FLYOUT_KEY}-${TableId.test}`,
+          banner: ANALYZER_PREVIEW_BANNER,
+        },
+      });
+    });
   });
 
-  it('should open details panel in preview when clicking on view button', () => {
-    const wrapper = renderAnalyzer();
+  describe('newDataViewPickerEnabled false', () => {
+    beforeEach(() => {
+      jest.clearAllMocks();
 
-    expect(wrapper.getByTestId('resolver:graph-controls:show-panel-button')).toBeInTheDocument();
-    wrapper.getByTestId('resolver:graph-controls:show-panel-button').click();
-    expect(mockFlyoutApi.openPreviewPanel).toBeCalledWith({
-      id: DocumentDetailsAnalyzerPanelKey,
-      params: {
-        resolverComponentInstanceID: `${FLYOUT_KEY}-${TableId.test}`,
-        banner: ANALYZER_PREVIEW_BANNER,
-      },
+      (useIsExperimentalFeatureEnabled as jest.Mock).mockReturnValue(false);
+    });
+
+    it('should show loading spinner while sourcerer data view is loading', () => {
+      (useSourcererDataView as jest.Mock).mockReturnValue({
+        loading: true,
+        sourcererDataView: dataViewSpec,
+      });
+
+      const { getByTestId } = renderAnalyzer();
+
+      expect(getByTestId(DATA_VIEW_LOADING_TEST_ID)).toBeInTheDocument();
+    });
+
+    it('should render an error if the dataViewSpec is undefined', () => {
+      (useSourcererDataView as jest.Mock).mockReturnValue({
+        loading: false,
+        sourcererDataView: undefined,
+      });
+
+      const { getByTestId } = renderAnalyzer();
+
+      expect(getByTestId(DATA_VIEW_ERROR_TEST_ID)).toHaveTextContent(
+        'Unable to retrieve the data view for analyzer'
+      );
+    });
+
+    it('should render an error if the dataViewSpec is invalid because id is undefined', () => {
+      (useSourcererDataView as jest.Mock).mockReturnValue({
+        loading: false,
+        sourcererDataView: { ...dataViewSpec, id: undefined, title: 'title' },
+      });
+
+      const { getByTestId } = renderAnalyzer();
+
+      expect(getByTestId(DATA_VIEW_ERROR_TEST_ID)).toHaveTextContent(
+        'Unable to retrieve the data view for analyzer'
+      );
+    });
+
+    it('should render an error if the dataViewSpec is invalid because title is empty', () => {
+      (useSourcererDataView as jest.Mock).mockReturnValue({
+        loading: false,
+        sourcererDataView: { ...dataViewSpec, id: 'id', title: '' },
+      });
+
+      const { getByTestId } = renderAnalyzer();
+
+      expect(getByTestId(DATA_VIEW_ERROR_TEST_ID)).toHaveTextContent(
+        'Unable to retrieve the data view for analyzer'
+      );
+    });
+
+    it('should render the content', () => {
+      (useSourcererDataView as jest.Mock).mockReturnValue({
+        loading: false,
+        sourcererDataView: { ...dataViewSpec, id: 'id', title: 'title' },
+      });
+
+      const { getByTestId } = renderAnalyzer();
+
+      expect(getByTestId(ANALYZER_GRAPH_TEST_ID)).toBeInTheDocument();
     });
   });
 });
diff --git a/x-pack/solutions/security/plugins/security_solution/public/flyout/document_details/left/components/analyze_graph.tsx b/x-pack/solutions/security/plugins/security_solution/public/flyout/document_details/left/components/analyze_graph.tsx
@@ -67,7 +67,35 @@ export const AnalyzeGraph: FC = () => {
     ? experimentalAnalyzerPatterns
     : oldAnalyzerPatterns;
 
-  const { dataView, status } = useDataView(PageScope.analyzer);
+  const { dataView: experimentalDataView, status: experimentalDataViewStatus } = useDataView(
+    PageScope.analyzer
+  );
+  const { sourcererDataView: oldSourcererDataViewSpec, loading: oldSourcererDataViewIsLoading } =
+    useSourcererDataView(PageScope.analyzer);
+
+  const isLoading: boolean = useMemo(
+    () =>
+      newDataViewPickerEnabled
+        ? experimentalDataViewStatus === 'loading' || experimentalDataViewStatus === 'pristine'
+        : oldSourcererDataViewIsLoading,
+    [experimentalDataViewStatus, newDataViewPickerEnabled, oldSourcererDataViewIsLoading]
+  );
+
+  const isDataViewInvalid: boolean = useMemo(
+    () =>
+      newDataViewPickerEnabled
+        ? experimentalDataViewStatus === 'error' ||
+          (experimentalDataViewStatus === 'ready' && !experimentalDataView.hasMatchedIndices())
+        : !oldSourcererDataViewSpec ||
+          !oldSourcererDataViewSpec.id ||
+          !oldSourcererDataViewSpec.title,
+    [
+      experimentalDataView,
+      experimentalDataViewStatus,
+      newDataViewPickerEnabled,
+      oldSourcererDataViewSpec,
+    ]
+  );
 
   const { openPreviewPanel } = useExpandableFlyoutApi();
 
@@ -89,7 +117,7 @@ export const AnalyzeGraph: FC = () => {
     );
   }
 
-  if (status === 'loading' || status === 'pristine') {
+  if (isLoading) {
     return (
       <EuiFlexGroup gutterSize="m" justifyContent="center" alignItems="center">
         <EuiFlexItem grow={false}>
@@ -99,7 +127,7 @@ export const AnalyzeGraph: FC = () => {
     );
   }
 
-  if (status === 'error' || (status === 'ready' && !dataView.hasMatchedIndices())) {
+  if (isDataViewInvalid) {
     return (
       <EuiEmptyPrompt
         color="danger"
