Skip to content

Commit e6fcce9

Browse files
[9.2] [ML][AI Connector] Anthropic Connector: ensure max tokens parameter is passed as expected by service (#241188) (#241208)
# Backport This will backport the following commits from `main` to `9.2`: - [[ML][AI Connector] Anthropic Connector: ensure max tokens parameter is passed as expected by service (#241188)](#241188) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Melissa Alvarez","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-10-29T21:00:37Z","message":"[ML][AI Connector] Anthropic Connector: ensure max tokens parameter is passed as expected by service (#241188)\n\n## Summary\n\nFixes https://github.com/elastic/kibana/issues/241142\n\nThis is a temporary workaround for anthropic max_tokens handling until\nthe services endpoint is updated to reflect the correct structure.\nAnthropic is unique in that it requires max_tokens to be sent as part of\nthe task_settings instead of the usual service_settings.\nUntil the services endpoint is updated to reflect that, there is no way\nfor the form UI to know where to put max_tokens. This can be removed\nonce that update is made.\n\n\nhttps://github.com/user-attachments/assets/e89e7fb2-5509-45c6-9f43-deccb0873267\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"0a8c77d8e2341c9de9b175ed7d4549550389c20e","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","backport:version","Feature:Inference UI","v9.3.0","Feature: AI Infra","v8.19.7","v9.1.7","v9.2.1"],"title":"[ML][AI Connector] Anthropic Connector: ensure max tokens parameter is passed as expected by service","number":241188,"url":"https://github.com/elastic/kibana/pull/241188","mergeCommit":{"message":"[ML][AI Connector] Anthropic Connector: ensure max tokens parameter is passed as expected by service (#241188)\n\n## Summary\n\nFixes https://github.com/elastic/kibana/issues/241142\n\nThis is a temporary workaround for anthropic max_tokens handling until\nthe services endpoint is updated to reflect the correct structure.\nAnthropic is unique in that it requires max_tokens to be sent as part of\nthe task_settings instead of the usual service_settings.\nUntil the services endpoint is updated to reflect that, there is no way\nfor the form UI to know where to put max_tokens. This can be removed\nonce that update is made.\n\n\nhttps://github.com/user-attachments/assets/e89e7fb2-5509-45c6-9f43-deccb0873267\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"0a8c77d8e2341c9de9b175ed7d4549550389c20e"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.1","9.2"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/241188","number":241188,"mergeCommit":{"message":"[ML][AI Connector] Anthropic Connector: ensure max tokens parameter is passed as expected by service (#241188)\n\n## Summary\n\nFixes https://github.com/elastic/kibana/issues/241142\n\nThis is a temporary workaround for anthropic max_tokens handling until\nthe services endpoint is updated to reflect the correct structure.\nAnthropic is unique in that it requires max_tokens to be sent as part of\nthe task_settings instead of the usual service_settings.\nUntil the services endpoint is updated to reflect that, there is no way\nfor the form UI to know where to put max_tokens. This can be removed\nonce that update is made.\n\n\nhttps://github.com/user-attachments/assets/e89e7fb2-5509-45c6-9f43-deccb0873267\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"0a8c77d8e2341c9de9b175ed7d4549550389c20e"}},{"branch":"8.19","label":"v8.19.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Melissa Alvarez <[email protected]>
1 parent f29c8e7 commit e6fcce9

File tree

1 file changed

+20
-0
lines changed
  • x-pack/platform/plugins/shared/stack_connectors/server/connector_types/inference

1 file changed

+20
-0
lines changed

x-pack/platform/plugins/shared/stack_connectors/server/connector_types/inference/index.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,27 @@ export const getConnectorType = (): SubActionConnectorType<Config, Secrets> => (
6565
minimumLicenseRequired: 'enterprise' as const,
6666
preSaveHook: async ({ config, secrets, logger, services, isUpdate }) => {
6767
const esClient = services.scopedClusterClient.asInternalUser;
68+
6869
try {
70+
// NOTE: This is a temporary workaround for anthropic max_tokens handling until the services endpoint is updated to reflect the correct structure.
71+
// Anthropic is unique in that it requires max_tokens to be sent as part of the task_settings instead of the usual service_settings.
72+
// Until the services endpoint is updated to reflect that, there is no way for the form UI to know where to put max_tokens. This can be removed once that update is made.
73+
if (
74+
config?.provider === ServiceProviderKeys.anthropic &&
75+
// @ts-ignore max_tokens is not defined in the type, but we allow it in the schema
76+
config?.providerConfig?.max_tokens
77+
) {
78+
// @ts-ignore
79+
config.taskTypeConfig = {
80+
...(config.taskTypeConfig ?? {}),
81+
// @ts-ignore
82+
max_tokens: config.providerConfig.max_tokens,
83+
};
84+
// This field is unknown to the anthropic service config, so we remove it
85+
// @ts-ignore
86+
delete config.providerConfig.max_tokens;
87+
}
88+
6989
const taskSettings = config?.taskTypeConfig
7090
? {
7191
...unflattenObject(config?.taskTypeConfig),

0 commit comments

Comments
 (0)