[chore] Clean up shared-ux RedirectAppLinks wrappers (#241017)

## Summary

Follow up to #216194

## Testing

Visually check that all the pages where the wrapper is removed look
good, since we're removing div with flex styles

---------

Co-authored-by: kibanamachine <[email protected]>

Author: Dosant

examples/content_management_examples/public/examples/index.tsx

@@ -11,7 +11,6 @@ import React from 'react';
 import ReactDOM from 'react-dom';
 import { Redirect } from 'react-router-dom';
 import { Router, Routes, Route } from '@kbn/shared-ux-router';
-import { RedirectAppLinks } from '@kbn/shared-ux-link-redirect-app';
 import { EuiPageTemplate, EuiSideNav } from '@elastic/eui';
 import type { AppMountParameters, CoreStart } from '@kbn/core/public';
 import type { StartDeps } from '../types';
@@ -27,63 +26,61 @@ export const renderApp = (
   ReactDOM.render(
     core.rendering.addContext(
       <Router history={history}>
-        <RedirectAppLinks coreStart={core}>
-          <EuiPageTemplate offset={0}>
-            <EuiPageTemplate.Sidebar>
-              <EuiSideNav
-                items={[
-                  {
-                    id: 'Examples',
-                    name: 'Examples',
-                    items: [
-                      {
-                        id: 'todos',
-                        name: 'Todo app',
-                        'data-test-subj': 'todosExample',
-                        href: '/app/contentManagementExamples/todos',
-                      },
-                      {
-                        id: 'msearch',
-                        name: 'MSearch',
-                        'data-test-subj': 'msearchExample',
-                        href: '/app/contentManagementExamples/msearch',
-                      },
-                      {
-                        id: 'finder',
-                        name: 'Finder',
-                        'data-test-subj': 'finderExample',
-                        href: '/app/contentManagementExamples/finder',
-                      },
-                    ],
-                  },
-                ]}
-              />
-            </EuiPageTemplate.Sidebar>
+        <EuiPageTemplate offset={0}>
+          <EuiPageTemplate.Sidebar>
+            <EuiSideNav
+              items={[
+                {
+                  id: 'Examples',
+                  name: 'Examples',
+                  items: [
+                    {
+                      id: 'todos',
+                      name: 'Todo app',
+                      'data-test-subj': 'todosExample',
+                      href: '/app/contentManagementExamples/todos',
+                    },
+                    {
+                      id: 'msearch',
+                      name: 'MSearch',
+                      'data-test-subj': 'msearchExample',
+                      href: '/app/contentManagementExamples/msearch',
+                    },
+                    {
+                      id: 'finder',
+                      name: 'Finder',
+                      'data-test-subj': 'finderExample',
+                      href: '/app/contentManagementExamples/finder',
+                    },
+                  ],
+                },
+              ]}
+            />
+          </EuiPageTemplate.Sidebar>
 
-            <EuiPageTemplate.Section>
-              <Routes>
-                <Redirect from="/" to="/todos" exact />
-                <Route path="/todos">
-                  <TodoApp contentClient={contentManagement.client} />
-                </Route>
-                <Route path="/msearch">
-                  <MSearchApp
-                    contentClient={contentManagement.client}
-                    core={core}
-                    savedObjectsTagging={savedObjectsTaggingOss}
-                  />
-                </Route>
-                <Route path="/finder">
-                  <FinderApp
-                    contentClient={contentManagement.client}
-                    core={core}
-                    savedObjectsTagging={savedObjectsTaggingOss}
-                  />
-                </Route>
-              </Routes>
-            </EuiPageTemplate.Section>
-          </EuiPageTemplate>
-        </RedirectAppLinks>
+          <EuiPageTemplate.Section>
+            <Routes>
+              <Redirect from="/" to="/todos" exact />
+              <Route path="/todos">
+                <TodoApp contentClient={contentManagement.client} />
+              </Route>
+              <Route path="/msearch">
+                <MSearchApp
+                  contentClient={contentManagement.client}
+                  core={core}
+                  savedObjectsTagging={savedObjectsTaggingOss}
+                />
+              </Route>
+              <Route path="/finder">
+                <FinderApp
+                  contentClient={contentManagement.client}
+                  core={core}
+                  savedObjectsTagging={savedObjectsTaggingOss}
+                />
+              </Route>
+            </Routes>
+          </EuiPageTemplate.Section>
+        </EuiPageTemplate>
       </Router>
     ),
     element

examples/content_management_examples/tsconfig.json

@@ -18,7 +18,6 @@
     "@kbn/core",
     "@kbn/developer-examples-plugin",
     "@kbn/content-management-plugin",
-    "@kbn/shared-ux-link-redirect-app",
     "@kbn/content-management-table-list-view",
     "@kbn/content-management-table-list-view-table",
     "@kbn/i18n-react",

src/core/packages/chrome/browser-internal/src/ui/header/__snapshots__/header.test.tsx.snap

@@ -35,8 +35,6 @@ import type {
 } from '@kbn/core-chrome-browser';
 import type { CustomBranding } from '@kbn/core-custom-branding-common';
 import type { DocLinksStart } from '@kbn/core-doc-links-browser';
-import { RedirectAppLinks } from '@kbn/shared-ux-link-redirect-app';
-import { css } from '@emotion/react';
 import { CollapsibleNav } from './collapsible_nav';
 import { HeaderBadge } from './header_badge';
 import { HeaderBreadcrumbs } from './header_breadcrumbs';
@@ -199,18 +197,12 @@ export function Header({
 
               <HeaderNavControls side="left" navControls$={observables.navControlsLeft$} />
             </EuiHeaderSection>
-            <RedirectAppLinks
-              coreStart={{ application }}
-              css={css`
-                min-width: 0; // enable text truncation for long breadcrumb titles
-              `}
+
+            <BreadcrumbsWithExtensionsWrapper
+              breadcrumbsAppendExtensions$={breadcrumbsAppendExtensions$}
             >
-              <BreadcrumbsWithExtensionsWrapper
-                breadcrumbsAppendExtensions$={breadcrumbsAppendExtensions$}
-              >
-                {Breadcrumbs}
-              </BreadcrumbsWithExtensionsWrapper>
-            </RedirectAppLinks>
+              {Breadcrumbs}
+            </BreadcrumbsWithExtensionsWrapper>
 
             <HeaderBadge badge$={observables.badge$} />
 

src/core/packages/chrome/browser-internal/src/ui/header/header.tsx

@@ -32,7 +32,6 @@ import type { DocLinksStart } from '@kbn/core-doc-links-browser';
 import type { HttpStart } from '@kbn/core-http-browser';
 import type { MountPoint } from '@kbn/core-mount-utils-browser';
 import { i18n } from '@kbn/i18n';
-import { RedirectAppLinks } from '@kbn/shared-ux-link-redirect-app';
 import React, { type ComponentProps, useCallback } from 'react';
 import useObservable from 'react-use/lib/useObservable';
 import type { Observable } from 'rxjs';
@@ -74,9 +73,6 @@ const getHeaderCss = ({ size, colors }: EuiThemeComputed) => ({
   breadcrumbsSectionItem: css`
     min-width: 0; // needed to enable breadcrumbs truncation
   `,
-  redirectAppLinksContainer: css`
-    min-width: 0; // needed to enable breadcrumbs truncation
-  `,
   leftNavcontrols: css`
     .navcontrols__separator {
       display: flex;
@@ -276,16 +272,11 @@ export const ProjectHeader = ({
               </EuiHeaderSectionItem>
 
               <EuiHeaderSectionItem css={headerCss.breadcrumbsSectionItem}>
-                <RedirectAppLinks
-                  coreStart={{ application }}
-                  css={headerCss.redirectAppLinksContainer}
+                <BreadcrumbsWithExtensionsWrapper
+                  breadcrumbsAppendExtensions$={breadcrumbsAppendExtensions$}
                 >
-                  <BreadcrumbsWithExtensionsWrapper
-                    breadcrumbsAppendExtensions$={breadcrumbsAppendExtensions$}
-                  >
-                    <Breadcrumbs breadcrumbs$={observables.breadcrumbs$} />
-                  </BreadcrumbsWithExtensionsWrapper>
-                </RedirectAppLinks>
+                  <Breadcrumbs breadcrumbs$={observables.breadcrumbs$} />
+                </BreadcrumbsWithExtensionsWrapper>
               </EuiHeaderSectionItem>
             </EuiHeaderSection>
 

src/core/packages/chrome/browser-internal/src/ui/project/header.tsx

@@ -23,7 +23,6 @@ import type { ApplicationStart } from '@kbn/core-application-browser';
 import type { NavigationTourManager } from '@kbn/core-chrome-navigation-tour';
 import { NavigationTour } from '@kbn/core-chrome-navigation-tour';
 import useObservable from 'react-use/lib/useObservable';
-import { RedirectNavigationAppLinks } from './redirect_app_links';
 import type { NavigationItems } from './to_navigation_items';
 import { toNavigationItems } from './to_navigation_items';
 import { PanelStateManager } from './panel_state_manager';
@@ -76,22 +75,20 @@ export const Navigation = (props: ChromeNavigationProps) => {
           props.isCollapsed ? 'collapsed' : 'expanded'
         }
       />
-      <RedirectNavigationAppLinks application={props.application}>
-        <NavigationComponent
-          items={navItems}
-          logo={logoItem}
-          sidePanelFooter={
-            <NavigationFeedbackSnippet
-              solutionId={solutionId}
-              feedbackUrlParams={feedbackUrlParams}
-            />
-          }
-          isCollapsed={props.isCollapsed}
-          setWidth={props.setWidth}
-          activeItemId={activeItemId}
-          data-test-subj={classnames(dataTestSubj, 'projectSideNav', 'projectSideNavV2')}
-        />
-      </RedirectNavigationAppLinks>
+      <NavigationComponent
+        items={navItems}
+        logo={logoItem}
+        sidePanelFooter={
+          <NavigationFeedbackSnippet
+            solutionId={solutionId}
+            feedbackUrlParams={feedbackUrlParams}
+          />
+        }
+        isCollapsed={props.isCollapsed}
+        setWidth={props.setWidth}
+        activeItemId={activeItemId}
+        data-test-subj={classnames(dataTestSubj, 'projectSideNav', 'projectSideNavV2')}
+      />
     </>
   );
 };

src/core/packages/chrome/browser-internal/src/ui/project/sidenav_v2/navigation/navigation.tsx

@@ -46,7 +46,6 @@
     "@kbn/default-nav-management",
     "@kbn/default-nav-devtools",
     "@kbn/shared-ux-router",
-    "@kbn/shared-ux-link-redirect-app",
     "@kbn/core-http-browser-internal",
     "@kbn/core-base-browser-internal",
     "@kbn/core-base-browser-mocks",