[Security Solution][Data View Picker] Fix test suites (#227422)

## Summary

This PR ~~enables the new
[picker](elastic/security-team#11959) by
default~~ fixes tests that w ill be affected by the new picker,
deprecating some of them and updating default mocks in some of the
suites to always include a mocked version of `useDataView`. individual
tests may still override the mock. There will be a follow up with
default enable experimental feature flag.

## Testing
You tell me what is not working:). Its just fixing tests.

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: PhilippeOberti <[email protected]>

Author: 3 people

x-pack/platform/plugins/shared/osquery/cypress/e2e/all/timelines.cy.ts

@@ -28,18 +28,8 @@ describe('ALL - Timelines', { tags: ['@ess'] }, () => {
       cy.getBySel('timeline-bottom-bar-title-button').click();
     });
     cy.getBySel('timelineQueryInput').type(
-      'NOT host.name: "dev-fleet-server*" and component.type: "osquery"{enter}'
+      'NOT host.name: "dev-fleet-server*" and component.type: "osquery" AND (_index: "logs-*" OR _index: "filebeat-*"){enter}'
     );
-    // Filter out alerts
-    cy.getBySel('timeline-sourcerer-trigger').click();
-    cy.getBySel('sourcerer-advanced-options-toggle').click();
-    cy.getBySel('sourcerer-combo-box').within(() => {
-      cy.getBySel('comboBoxClearButton').click();
-      cy.getBySel('comboBoxInput').type(
-        'logs-*{downArrow}{enter}filebeat-*{downArrow}{enter}{esc}'
-      );
-    });
-    cy.getBySel('sourcerer-save').click();
 
     // Force true due to pointer-events: none on parent prevents user mouse interaction.
     cy.getBySel('docTableExpandToggleColumn').first().click({ force: true });

x-pack/solutions/security/plugins/security_solution/public/app/components/top_values_popover/top_values_popover.test.tsx

@@ -18,6 +18,7 @@ jest.mock('react-router-dom', () => {
     useLocation: jest.fn().mockReturnValue({ pathname: '/test' }),
   };
 });
+jest.mock('../../../data_view_manager/hooks/use_data_view');
 
 const element = document.createElement('button');
 document.body.appendChild(element);

x-pack/solutions/security/plugins/security_solution/public/app/home/global_header/index.test.tsx

@@ -14,37 +14,21 @@ import {
   SECURITY_FEATURE_ID,
   THREAT_INTELLIGENCE_PATH,
 } from '../../../../common/constants';
-import {
-  createMockStore,
-  mockGlobalState,
-  mockIndexPattern,
-  TestProviders,
-} from '../../../common/mock';
+import { createMockStore, mockGlobalState, TestProviders } from '../../../common/mock';
 import { TimelineId } from '../../../../common/types/timeline';
 import { sourcererPaths } from '../../../sourcerer/containers/sourcerer_paths';
 
-import { useIsExperimentalFeatureEnabled } from '../../../common/hooks/use_experimental_features';
 import { DATA_VIEW_PICKER_TEST_ID } from '../../../data_view_manager/components/data_view_picker/constants';
 import { useKibana as mockUseKibana } from '../../../common/lib/kibana/__mocks__';
 import { useKibana } from '../../../common/lib/kibana';
 
-jest.mock('../../../common/hooks/use_experimental_features');
-
 jest.mock('react-router-dom', () => {
   const actual = jest.requireActual('react-router-dom');
   return { ...actual, useLocation: jest.fn().mockReturnValue({ pathname: '' }) };
 });
 
 jest.mock('../../../common/lib/kibana');
 
-jest.mock('../../../common/containers/source', () => ({
-  useFetchIndex: () => [false, { indicesExist: true, indexPatterns: mockIndexPattern }],
-}));
-
-jest.mock('../../../sourcerer/containers/use_signal_helpers', () => ({
-  useSignalHelpers: () => ({ signalIndexNeedsInit: false }),
-}));
-
 jest.mock('react-reverse-portal', () => ({
   InPortal: ({ children }: { children: React.ReactNode }) => <>{children}</>,
   OutPortal: ({ children }: { children: React.ReactNode }) => <>{children}</>,
@@ -133,29 +117,31 @@ describe('global header', () => {
     expect(link?.getAttribute('href')).toBe(ADD_THREAT_INTELLIGENCE_DATA_PATH);
   });
 
-  it.each(sourcererPaths)('shows sourcerer on %s page', (pathname) => {
-    (useLocation as jest.Mock).mockReturnValue({ pathname });
-
-    const { getByTestId } = render(
-      <TestProviders store={store}>
-        <GlobalHeader />
-      </TestProviders>
-    );
-    expect(getByTestId('sourcerer-trigger')).toBeInTheDocument();
-  });
-
-  it('shows sourcerer on rule details page', () => {
+  // TODO: Skipping until feature flag is enabled https://github.com/elastic/security-team/issues/11959 by default
+  // it.each(sourcererPaths)('shows data view manager on %s page', (pathname) => {
+  //   (useLocation as jest.Mock).mockReturnValue({ pathname });
+  //
+  //   const { getByTestId } = render(
+  //     <TestProviders store={store}>
+  //       <GlobalHeader />
+  //     </TestProviders>
+  //   );
+  //   expect(getByTestId(DATA_VIEW_PICKER_TEST_ID)).toBeInTheDocument();
+  // });
+
+  // TODO: Skipping until feature flag is enabled https://github.com/elastic/security-team/issues/11959 by default
+  it.skip('shows data view manager on rule details page', () => {
     (useLocation as jest.Mock).mockReturnValue({ pathname: sourcererPaths[2] });
 
     const { getByTestId } = render(
       <TestProviders store={store}>
         <GlobalHeader />
       </TestProviders>
     );
-    expect(getByTestId('sourcerer-trigger')).toBeInTheDocument();
+    expect(getByTestId(DATA_VIEW_PICKER_TEST_ID)).toBeInTheDocument();
   });
 
-  it('shows no sourcerer if timeline is open', () => {
+  it('shows no data view manager if timeline is open', () => {
     const mockstate = {
       ...mockGlobalState,
       timeline: {
@@ -178,7 +164,7 @@ describe('global header', () => {
       </TestProviders>
     );
 
-    expect(queryByTestId('sourcerer-trigger')).not.toBeInTheDocument();
+    expect(queryByTestId(DATA_VIEW_PICKER_TEST_ID)).not.toBeInTheDocument();
   });
 
   it('shows AI Assistant header link', () => {
@@ -190,22 +176,4 @@ describe('global header', () => {
 
     waitFor(() => expect(findByTestId('assistantNavLink')).toBeInTheDocument());
   });
-
-  describe('when new data view picker is enabled', () => {
-    beforeEach(() => {
-      // Mocking location to be alerts page
-      (useLocation as jest.Mock).mockReturnValue({ pathname: sourcererPaths[0] });
-      jest.mocked(useIsExperimentalFeatureEnabled).mockReturnValue(true);
-    });
-
-    it('should render it instead of sourcerer', () => {
-      const { queryByTestId } = render(
-        <TestProviders store={store}>
-          <GlobalHeader />
-        </TestProviders>
-      );
-      expect(queryByTestId('sourcerer-trigger')).not.toBeInTheDocument();
-      expect(queryByTestId(DATA_VIEW_PICKER_TEST_ID)).toBeInTheDocument();
-    });
-  });
 });

x-pack/solutions/security/plugins/security_solution/public/attack_discovery/jest.config.js

@@ -15,5 +15,8 @@ module.exports = {
   collectCoverageFrom: [
     '<rootDir>/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/**/*.{ts,tsx}',
   ],
+  setupFilesAfterEnv: [
+    '<rootDir>/x-pack/solutions/security/plugins/security_solution/public/attack_discovery/test/setup.ts',
+  ],
   moduleNameMapper: require('../../server/__mocks__/module_name_map'),
 };

x-pack/solutions/security/plugins/security_solution/public/attack_discovery/test/setup.ts

@@ -0,0 +1,8 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+jest.mock('../../data_view_manager/hooks/use_data_view');

x-pack/solutions/security/plugins/security_solution/public/common/components/drag_and_drop/__snapshots__/drag_drop_context_wrapper.test.tsx.snap

@@ -13,6 +13,8 @@ import type { ModalInspectProps } from './modal';
 import { ModalInspectQuery, formatIndexPatternRequested } from './modal';
 import { InputsModelId } from '../../store/inputs/constants';
 import { fireEvent, render, screen } from '@testing-library/react';
+import { useDataView } from '../../../data_view_manager/hooks/use_data_view';
+import { withIndices } from '../../../data_view_manager/hooks/__mocks__/use_data_view';
 
 jest.mock('react-router-dom', () => {
   const original = jest.requireActual('react-router-dom');
@@ -23,9 +25,9 @@ jest.mock('react-router-dom', () => {
   };
 });
 
-const getRequest = (
-  indices: string[] = ['auditbeat-*', 'filebeat-*', 'packetbeat-*', 'winlogbeat-*']
-) =>
+const defaultIndices = ['auditbeat-*', 'filebeat-*', 'packetbeat-*', 'winlogbeat-*'];
+
+const getRequest = (indices: string[] = defaultIndices) =>
   `{"index": ${JSON.stringify(
     indices
   )},"allowNoIndices": true, "ignoreUnavailable": true, "body": { "aggregations": {"hosts": {"cardinality": {"field": "host.name" } }, "hosts_histogram": {"auto_date_histogram": {"field": "@timestamp","buckets": "6"},"aggs": { "count": {"cardinality": {"field": "host.name" }}}}}, "query": {"bool": {"filter": [{"range": { "@timestamp": {"gte": 1562290224506,"lte": 1562376624506 }}}]}}, "size": 0, "track_total_hits": false}}`;
@@ -244,6 +246,8 @@ describe('Modal Inspect', () => {
 
   describe('index pattern messaging', () => {
     test('should show no messaging when all patterns match sourcerer selection', () => {
+      jest.mocked(useDataView).mockReturnValue(withIndices(defaultIndices));
+
       renderModal();
 
       expect(screen.queryByTestId('not-sourcerer-msg')).toBeNull();

x-pack/solutions/security/plugins/security_solution/public/common/components/inspect/modal.test.tsx

@@ -48,7 +48,7 @@ import { useDataView } from '../../../data_view_manager/hooks/use_data_view';
 interface SiemSearchBarProps {
   id: InputsModelId.global | InputsModelId.timeline;
   pollForSignalIndex?: () => void;
-  sourcererDataView: DataViewSpec | undefined;
+  sourcererDataView: DataViewSpec | DataView | undefined; // TODO remove DataViewSpec type when we remove the newDataViewPickerEnabled feature flag
   timelineId?: string;
   dataTestSubj?: string;
   hideFilterBar?: boolean;
@@ -315,6 +315,10 @@ export const SearchBarComponent = memo<SiemSearchBarProps & PropsFromRedux>(
       }
 
       if (sourcererDataView != null) {
+        if (sourcererDataView instanceof DataView) {
+          return [sourcererDataView];
+        }
+
         return [new DataView({ spec: sourcererDataView, fieldFormats })];
       } else {
         return null;

x-pack/solutions/security/plugins/security_solution/public/common/components/search_bar/index.tsx

@@ -84,12 +84,12 @@ describe('Table Helpers', () => {
     test('it returns 2 items then overflows when displayCount is 2', () => {
       const rowItems = getRowItemsWithActions({
         values: items,
-        fieldName: 'attrName',
+        fieldName: 'user.name',
         idPrefix: 'idPrefix',
         displayCount: 2,
       });
       const { queryAllByTestId, queryByTestId } = render(<TestProviders>{rowItems}</TestProviders>);
-      expect(queryAllByTestId('cellActions-renderContent-attrName').length).toBe(2);
+      expect(queryAllByTestId('cellActions-renderContent-user.name').length).toBe(2);
       expect(queryByTestId('overflow-button')).toBeInTheDocument();
     });
   });

x-pack/solutions/security/plugins/security_solution/public/common/components/tables/helpers.test.tsx

@@ -11,6 +11,8 @@ import { mockExtraFilter, wrapper } from '../../../mocks';
 import { useLensAttributes } from '../../../use_lens_attributes';
 
 import { getAlertsByStatusAttributes } from './alerts_by_status_donut';
+import { useDataView } from '../../../../../../data_view_manager/hooks/use_data_view';
+import { withIndices } from '../../../../../../data_view_manager/hooks/__mocks__/use_data_view';
 
 jest.mock('uuid', () => ({
   v4: jest.fn().mockReturnValue('generated-uuid'),
@@ -34,6 +36,12 @@ jest.mock('../../../../../utils/route/use_route_spy', () => ({
 }));
 
 describe('getAlertsByStatusAttributes', () => {
+  beforeAll(() => {
+    jest
+      .mocked(useDataView)
+      .mockReturnValue(withIndices(['signal-index'], 'security-solution-my-test'));
+  });
+
   it('should render without extra options', () => {
     const { result } = renderHook(
       () =>