add servicenow data source by seanstory · Pull Request #252430 · elastic/kibana

seanstory · 2026-02-10T00:17:14Z

Summary

Closes https://github.com/elastic/search-team/issues/12864

Adds a ServiceNow datasource

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
Review the backport guidelines and apply applicable backport:* labels.

Release note

Adds a ServiceNow: Search connector, for searching across records and knowledge bases, retrieving contents, metadata, and comments.

github-actions · 2026-02-10T00:18:52Z

🔍 Preview links for changed docs

docs/reference/connectors-kibana/servicenow-search-action-type.md

...latform/packages/shared/kbn-connector-specs/src/specs/servicenow_search/servicenow_search.ts

seanstory

self review for AI consumption

...latform/packages/shared/kbn-connector-specs/src/specs/servicenow_search/servicenow_search.ts

...m/plugins/shared/data_sources/server/sources/servicenow/workflows/get_knowledge_article.yaml

...latform/packages/shared/kbn-connector-specs/src/specs/servicenow_search/servicenow_search.ts

x-pack/platform/plugins/shared/data_sources/server/sources/servicenow/workflows/search.yaml

x-pack/platform/plugins/shared/data_sources/server/sources/servicenow/data_type.ts

seanstory · 2026-02-19T23:20:05Z

buildkite test this

florent-leborgne

Few comments/questions on the docs before I approve :)

docs/reference/connectors-kibana/_snippets/elastic-connectors-list.md

docs/reference/connectors-kibana/servicenow-search-action-type.md

elasticmachine · 2026-02-25T15:20:47Z

💚 Build Succeeded

Buildkite Build
Commit: 53ec79e

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`dataSources`	180	182	+2
`stackConnectors`	688	691	+3
`workflowsManagement`	1298	1299	+1
total			+6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dataSources`	198.3KB	199.5KB	+1.2KB
`stackConnectors`	1.2MB	1.2MB	+9.5KB
`workflowsManagement`	1.5MB	1.5MB	+8.4KB
total			+19.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`stackConnectors`	81.0KB	81.0KB	+72.0B

Unknown metric groups

async chunk count

id	before	after	diff
`dataSources`	15	16	+1
`stackConnectors`	129	130	+1
total			+2

History

erikcurrin-elastic

Some questions about handlers and correct formatting...

.github/CODEOWNERS

erikcurrin-elastic · 2026-02-25T21:48:38Z

...rm/packages/shared/kbn-connector-specs/src/specs/servicenow_search/servicenow_search.test.ts

@@ -0,0 +1,699 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one


This seems excessive for what is basically a bunch of mocks.

Have a concrete suggestion/request? If AI is going to write and maintain an excessive number of tests, I'm not too bothered. I'd rather have the better coverage.

...rm/packages/shared/kbn-connector-specs/src/specs/servicenow_search/servicenow_search.test.ts

...latform/packages/shared/kbn-connector-specs/src/specs/servicenow_search/servicenow_search.ts

Copilot

Pull request overview

This PR adds a ServiceNow data source connector for federated search capabilities, enabling users to search and retrieve records from ServiceNow instances including incidents, knowledge articles, change requests, and other record types.

Changes:

Added a new ServiceNow Search connector with OAuth2 client credentials authentication
Implemented comprehensive workflow definitions for search, retrieval, and data access operations
Added full test coverage and documentation for the connector

Reviewed changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`servicenow_search.ts`	Core connector implementation with actions for search, record retrieval, listing, and attachment handling
`types.ts`	Zod schemas and TypeScript types for all connector action inputs
`servicenow_search.test.ts`	Comprehensive unit tests covering all connector actions and error cases
`workflows/*.yaml`	Workflow definitions for search, list, get, and attachment operations
`data_type.ts`	Data source configuration integrating the connector with the catalog
`servicenow-search-action-type.md`	User-facing documentation including setup instructions and API reference
`all_specs.ts`, `connector_icons_map.ts`, `index.ts`	Registration and integration of the new connector

.github/CODEOWNERS

artem-shelkovnikov · 2026-02-27T17:45:37Z

...latform/packages/shared/kbn-connector-specs/src/specs/servicenow_search/servicenow_search.ts

+      },
+    },
+
+    listTables: {


Is there a way to describe a table? Or this method returns schema?

This method doesn't include the schema. The developer instance of ServiceNow I'm using for testing has "normal" serviceNow tables, so the LLM has been able to just rely on its training to figure out which columns to use. But I think this is a good point, and wont' hold up in a production scenario. I'll add a tool for explicit schema discovery.

Iterate on ServiceNow data source Fix getComments filter logic Changes from node scripts/eslint_all_files --no-cache --fix

…ersion

…ure connectors

elasticmachine · 2026-02-27T21:58:40Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 9d61084

Failed CI Steps

Jest Tests #5

Test Failures

[job] [logs] Jest Tests #5 / CreateFlyout should render the flyout title

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`dataSources`	180	182	+2
`stackConnectors`	688	692	+4
`workflowsManagement`	1306	1308	+2
total			+8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dataSources`	198.3KB	199.5KB	+1.2KB
`stackConnectors`	1.2MB	1.2MB	+10.1KB
`workflowsManagement`	1.5MB	1.5MB	+9.0KB
total			+20.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`stackConnectors`	81.0KB	81.0KB	+72.0B

Unknown metric groups

async chunk count

id	before	after	diff
`dataSources`	15	16	+1
`stackConnectors`	129	130	+1
total			+2

History

💛 Build #401879 was flaky 02bfa09
💚 Build #400682 succeeded 53ec79e
💔 Build #400337 failed cd88dae
💔 Build #398176 failed fe4d292
💔 Build #398168 failed 0e118c0

seanstory changed the title ~~Seanstory/add servicenow data source~~ add servicenow data source Feb 10, 2026

github-actions bot deployed to docs-preview February 10, 2026 00:18 View deployment

seanstory changed the title ~~add servicenow data source~~ [WIP] add servicenow data source Feb 13, 2026

erikcurrin-elastic reviewed Feb 13, 2026

View reviewed changes

seanstory force-pushed the seanstory/add-servicenow-data-source branch from a8871a9 to e86e482 Compare February 18, 2026 22:51

github-actions bot deployed to docs-preview February 18, 2026 22:53 View deployment

seanstory force-pushed the seanstory/add-servicenow-data-source branch from 02979d4 to 11a5ca7 Compare February 18, 2026 22:57

github-actions bot deployed to docs-preview February 18, 2026 22:59 View deployment

seanstory commented Feb 19, 2026

View reviewed changes

github-actions bot deployed to docs-preview February 19, 2026 20:50 View deployment

seanstory added release_note:feature Makes this part of the condensed release notes backport:skip This PR does not require backporting labels Feb 19, 2026

seanstory changed the title ~~[WIP] add servicenow data source~~ add servicenow data source Feb 19, 2026

seanstory marked this pull request as ready for review February 19, 2026 23:31

seanstory requested review from a team as code owners February 19, 2026 23:31

github-actions bot deployed to docs-preview February 19, 2026 23:42 View deployment

github-actions bot deployed to docs-preview February 20, 2026 00:03 View deployment

florent-leborgne reviewed Feb 20, 2026

View reviewed changes

seanstory force-pushed the seanstory/add-servicenow-data-source branch 2 times, most recently from 466f94c to cd88dae Compare February 24, 2026 20:37

github-actions bot deployed to docs-preview February 24, 2026 20:38 View deployment

seanstory force-pushed the seanstory/add-servicenow-data-source branch from cd88dae to 53ec79e Compare February 25, 2026 13:40

github-actions bot deployed to docs-preview February 25, 2026 13:42 View deployment

erikcurrin-elastic reviewed Feb 25, 2026

View reviewed changes

seanstory force-pushed the seanstory/add-servicenow-data-source branch from 53ec79e to 8fb3b65 Compare February 26, 2026 22:47

github-actions bot deployed to docs-preview February 26, 2026 22:48 View deployment

github-actions bot deployed to docs-preview February 26, 2026 23:09 View deployment

seanstory requested a review from Copilot February 26, 2026 23:32

Copilot AI reviewed Feb 26, 2026

View reviewed changes

.github/CODEOWNERS Show resolved Hide resolved

artem-shelkovnikov reviewed Feb 27, 2026

View reviewed changes

seanstory added 6 commits February 27, 2026 15:32

First pass at ServiceNow data source

e5d4c7e

Iterate on ServiceNow data source Fix getComments filter logic Changes from node scripts/eslint_all_files --no-cache --fix

Address documentation PR comments, scrubbing workplace-ai refs, add v…

1856402

…ersion

missed test updates

28e9eea

Extract casting into concrete types

5f98545

Move zod schemas to types.ts file, and establish as a pattern for fut…

4dd5545

…ure connectors

Add describe_table tool

9d61084

seanstory force-pushed the seanstory/add-servicenow-data-source branch from cc81f5b to 9d61084 Compare February 27, 2026 20:32

github-actions bot deployed to docs-preview February 27, 2026 20:34 View deployment

		@@ -0,0 +1,699 @@
		/*
		* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one

Conversation

seanstory commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Release note

Uh oh!

github-actions bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 Preview links for changed docs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seanstory left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seanstory commented Feb 19, 2026

Uh oh!

florent-leborgne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Feb 25, 2026

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

async chunk count

History

Uh oh!

erikcurrin-elastic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

erikcurrin-elastic Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

seanstory Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

artem-shelkovnikov Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

seanstory Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Feb 27, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

async chunk count

seanstory commented Feb 10, 2026 •

edited

Loading

github-actions bot commented Feb 10, 2026 •

edited

Loading