From f4ed58363ad2681d207648b0e72c43d13aa0bf5a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20R=C3=BChsen?= Date: Fri, 21 Mar 2025 19:29:52 +0100 Subject: [PATCH 1/2] [profiling] Add color for Executable flamegraph nodes --- .../packages/shared/kbn-profiling-utils/common/profiling.ts | 4 +++- .../plugins/profiling/common/frame_type_colors.ts | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/platform/packages/shared/kbn-profiling-utils/common/profiling.ts b/src/platform/packages/shared/kbn-profiling-utils/common/profiling.ts index b818f89606b9b..6f46ac41ede51 100644 --- a/src/platform/packages/shared/kbn-profiling-utils/common/profiling.ts +++ b/src/platform/packages/shared/kbn-profiling-utils/common/profiling.ts @@ -42,6 +42,7 @@ export enum FrameType { Root = 0x100, ProcessName = 0x101, ThreadName = 0x102, + ExecutableName = 0x103, } const frameTypeDescriptions = { @@ -59,8 +60,9 @@ const frameTypeDescriptions = { [FrameType.ErrorFlag]: 'ErrorFlag', [FrameType.Error]: 'Error', [FrameType.Root]: 'Root', - [FrameType.ProcessName]: 'Process', // Due to OTEL semconv issues, "process name" is currently more correct than "executable name" + [FrameType.ProcessName]: 'Process', [FrameType.ThreadName]: 'Thread', + [FrameType.ExecutableName]: 'Executable', }; export function isErrorFrame(ft: FrameType): boolean { diff --git a/x-pack/solutions/observability/plugins/profiling/common/frame_type_colors.ts b/x-pack/solutions/observability/plugins/profiling/common/frame_type_colors.ts index 4d02980f7fc8c..cdef000e828be 100644 --- a/x-pack/solutions/observability/plugins/profiling/common/frame_type_colors.ts +++ b/x-pack/solutions/observability/plugins/profiling/common/frame_type_colors.ts @@ -30,6 +30,7 @@ import { FrameType, normalizeFrameType } from '@kbn/profiling-utils'; */ const RED = 0xfd8484; const ORANGE = 0xffaa00; +const DARKORANGE = 0xff7700; const YELLOW = 0xe1e100; export const FRAME_TYPE_COLOR_MAP = { @@ -49,6 +50,7 @@ export const FRAME_TYPE_COLOR_MAP = { [FrameType.Root]: [RED, RED, RED, RED], [FrameType.ProcessName]: [ORANGE, ORANGE, ORANGE, ORANGE], [FrameType.ThreadName]: [YELLOW, YELLOW, YELLOW, YELLOW], + [FrameType.ExecutableName]: [DARKORANGE, DARKORANGE, DARKORANGE, DARKORANGE], }; export function frameTypeToRGB(frameType: FrameType, x: number): number { From 211d7d326c169a5ec59166a6ea5af63046c63c7d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20R=C3=BChsen?= Date: Sat, 22 Mar 2025 10:29:33 +0100 Subject: [PATCH 2/2] Slightly lighter orange --- .../observability/plugins/profiling/common/frame_type_colors.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/solutions/observability/plugins/profiling/common/frame_type_colors.ts b/x-pack/solutions/observability/plugins/profiling/common/frame_type_colors.ts index cdef000e828be..0e8d43886af16 100644 --- a/x-pack/solutions/observability/plugins/profiling/common/frame_type_colors.ts +++ b/x-pack/solutions/observability/plugins/profiling/common/frame_type_colors.ts @@ -30,7 +30,7 @@ import { FrameType, normalizeFrameType } from '@kbn/profiling-utils'; */ const RED = 0xfd8484; const ORANGE = 0xffaa00; -const DARKORANGE = 0xff7700; +const DARKORANGE = 0xff8800; const YELLOW = 0xe1e100; export const FRAME_TYPE_COLOR_MAP = {