Skip to content

[ES 9.0] Remove body workaround (@elastic/kibana-security) #217222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
afharo merged 3 commits into from
Apr 7, 2025
Merged

[ES 9.0] Remove body workaround (@elastic/kibana-security) #217222

afharo merged 3 commits into from
Apr 7, 2025

Conversation

@afharo
Copy link
Member

@afharo afharo commented Apr 4, 2025 •
edited
Loading

Summary

Follow up to #213375: The latest version of the ES client fixed the issue elastic/elasticsearch-js#2584.

We should be able to remove all usages of // @ts-expect-error [email protected] https://github.com/elastic/elasticsearch-js/issues/2584.

Checklist

@afharo afharo self-assigned this Apr 4, 2025
@afharo afharo added Feature:elasticsearch Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting elasticsearch-js-9 labels Apr 4, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 4, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #17 / API Keys grantAsInternalUser() calls grantApiKey with proper parameters for the Basic scheme
  • [job] [logs] Jest Tests #17 / API Keys grantAsInternalUser() calls grantApiKey with proper parameters for the Basic scheme
  • [job] [logs] Jest Tests #17 / API Keys grantAsInternalUser() calls grantApiKey with proper parameters for the Bearer scheme
  • [job] [logs] Jest Tests #17 / API Keys grantAsInternalUser() calls grantApiKey with proper parameters for the Bearer scheme
  • [job] [logs] Jest Tests #17 / API Keys grantAsInternalUser() calls grantApiKey with proper parameters for the Bearer scheme with client authentication
  • [job] [logs] Jest Tests #17 / API Keys grantAsInternalUser() calls grantApiKey with proper parameters for the Bearer scheme with client authentication
  • [job] [logs] Jest Tests #17 / API Keys with kibana privileges creates api key with application privileges as internal user
  • [job] [logs] Jest Tests #17 / API Keys with kibana privileges creates api key with application privileges as internal user
  • [job] [logs] FTR Configs #101 / saved objects tagging - functional tests feature controls tag management write privileges can bulk delete tags
  • [job] [logs] Jest Tests #17 / Session index #initialize updates mappings for existing index if version in meta is lower than the current version
  • [job] [logs] Jest Tests #17 / Session index #initialize updates mappings for existing index if version in meta is lower than the current version
  • [job] [logs] Jest Tests #17 / Session index #initialize updates mappings for existing index without version in the meta
  • [job] [logs] Jest Tests #17 / Session index #initialize updates mappings for existing index without version in the meta

Metrics [docs]

✅ unchanged

History

cc @afharo

@afharo afharo marked this pull request as ready for review April 7, 2025 15:59
@afharo afharo requested a review from a team as a code owner April 7, 2025 15:59
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 7, 2025

Pinging @elastic/kibana-security (Team:Security)

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 7, 2025

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @afharo

@afharo afharo merged commit 1bd3385 into elastic:main Apr 7, 2025
10 checks passed
@afharo afharo deleted the es-9.0/remove-body-workaround/elastic/kibana-security branch April 7, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elena-shostak elena-shostak elena-shostak approved these changes

Assignees

@afharo afharo

Labels

backport:skip This PR does not require backporting elasticsearch-js-9 Feature:elasticsearch release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@afharo @elasticmachine @elena-shostak @kibanamachine