-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Vega] remove VEGA_DEBUG #234477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vega] remove VEGA_DEBUG #234477
Conversation
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Manually checked the presence of VEGA_DEBUG on main and verified it's gone in this branch.
|
Starting backport for target branches: 8.18, 8.19, 9.0, 9.1 |
This commit removes the VEGA_DEBUG variable from window object. (cherry picked from commit 03f47de)
This commit removes the VEGA_DEBUG variable from window object. (cherry picked from commit 03f47de)
This commit removes the VEGA_DEBUG variable from window object. (cherry picked from commit 03f47de)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Remove this docs after the removal of the VEGA_DEBUG functionality. See elastic/kibana#234477 or ask the Visualization team for more info.
# Backport This will backport the following commits from `main` to `9.1`: - [[Vega] remove VEGA_DEBUG (#234477)](#234477) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-09-17T11:51:01Z","message":"[Vega] remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG variable from window object.","sha":"03f47de4412ec686ef5a09e035949639776c6489","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Vega","Team:Visualizations","release_note:skip","backport:all-open","v9.2.0"],"title":"[Vega] remove VEGA_DEBUG","number":234477,"url":"https://github.com/elastic/kibana/pull/234477","mergeCommit":{"message":"[Vega] remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG variable from window object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/234477","number":234477,"mergeCommit":{"message":"[Vega] remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG variable from window object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}}]}] BACKPORT--> Co-authored-by: Marco Vettorello <[email protected]>
# Backport This will backport the following commits from `main` to `9.0`: - [[Vega] remove VEGA_DEBUG (#234477)](#234477) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-09-17T11:51:01Z","message":"[Vega] remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG variable from window object.","sha":"03f47de4412ec686ef5a09e035949639776c6489","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Vega","Team:Visualizations","release_note:skip","backport:all-open","v9.2.0"],"title":"[Vega] remove VEGA_DEBUG","number":234477,"url":"https://github.com/elastic/kibana/pull/234477","mergeCommit":{"message":"[Vega] remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG variable from window object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/234477","number":234477,"mergeCommit":{"message":"[Vega] remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG variable from window object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}}]}] BACKPORT--> Co-authored-by: Marco Vettorello <[email protected]>
# Backport This will backport the following commits from `main` to `8.19`: - [[Vega] remove VEGA_DEBUG (#234477)](#234477) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-09-17T11:51:01Z","message":"[Vega] remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG variable from window object.","sha":"03f47de4412ec686ef5a09e035949639776c6489","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Vega","Team:Visualizations","release_note:skip","backport:all-open","v9.2.0"],"title":"[Vega] remove VEGA_DEBUG","number":234477,"url":"https://github.com/elastic/kibana/pull/234477","mergeCommit":{"message":"[Vega] remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG variable from window object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/234477","number":234477,"mergeCommit":{"message":"[Vega] remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG variable from window object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}}]}] BACKPORT--> Co-authored-by: Marco Vettorello <[email protected]>
This commit removes the VEGA_DEBUG variable from window object.
This commit removes the VEGA_DEBUG variable from window object. (cherry picked from commit 03f47de) # Conflicts: # src/platform/plugins/private/vis_types/vega/public/vega_view/vega_base_view.js
This commit removes the VEGA_DEBUG variable from window object. (cherry picked from commit 03f47de) # Conflicts: # src/plugins/vis_types/vega/public/vega_view/vega_base_view.js # src/plugins/vis_types/vega/public/vega_visualization.test.js
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.18`: - [[Vega] remove VEGA_DEBUG (#234477)](#234477) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-09-17T11:51:01Z","message":"[Vega] remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG variable from window object.","sha":"03f47de4412ec686ef5a09e035949639776c6489","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Vega","Team:Visualizations","release_note:skip","backport:all-open","v9.2.0","v9.1.4","v9.0.7","v8.19.4"],"title":"[Vega] remove VEGA_DEBUG","number":234477,"url":"https://github.com/elastic/kibana/pull/234477","mergeCommit":{"message":"[Vega] remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG variable from window object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/234477","number":234477,"mergeCommit":{"message":"[Vega] remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG variable from window object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}},{"branch":"9.1","label":"v9.1.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/235353","number":235353,"state":"MERGED","mergeCommit":{"sha":"3f77c7e51c9910198d2041c2b655ec7db96c33e4","message":"[9.1] [Vega] remove VEGA_DEBUG (#234477) (#235353)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.1`:\n- [[Vega] remove VEGA_DEBUG\n(#234477)](https://github.com/elastic/kibana/pull/234477)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Marco Vettorello <[email protected]>"}},{"branch":"9.0","label":"v9.0.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/235352","number":235352,"state":"MERGED","mergeCommit":{"sha":"d940f7267527ae279e00154f35f427d1c30d9526","message":"[9.0] [Vega] remove VEGA_DEBUG (#234477) (#235352)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Vega] remove VEGA_DEBUG\n(#234477)](https://github.com/elastic/kibana/pull/234477)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Marco Vettorello <[email protected]>"}},{"branch":"8.19","label":"v8.19.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/235351","number":235351,"state":"MERGED","mergeCommit":{"sha":"48e544d25bc6a940f17ff321cd4601e86bb9f180","message":"[8.19] [Vega] remove VEGA_DEBUG (#234477) (#235351)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.19`:\n- [[Vega] remove VEGA_DEBUG\n(#234477)](https://github.com/elastic/kibana/pull/234477)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Marco Vettorello <[email protected]>"}}]}] BACKPORT-->
# Backport This will backport the following commits from `main` to `7.17`: - [[Vega] remove VEGA_DEBUG (#234477)](#234477) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-09-17T11:51:01Z","message":"[Vega] remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG variable from window object.","sha":"03f47de4412ec686ef5a09e035949639776c6489","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Vega","Team:Visualizations","release_note:skip","backport:all-open","v9.2.0","v9.1.4","v9.0.7","v8.19.4"],"title":"[Vega] remove VEGA_DEBUG","number":234477,"url":"https://github.com/elastic/kibana/pull/234477","mergeCommit":{"message":"[Vega] remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG variable from window object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/234477","number":234477,"mergeCommit":{"message":"[Vega] remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG variable from window object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}},{"branch":"9.1","label":"v9.1.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/235353","number":235353,"state":"MERGED","mergeCommit":{"sha":"3f77c7e51c9910198d2041c2b655ec7db96c33e4","message":"[9.1] [Vega] remove VEGA_DEBUG (#234477) (#235353)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.1`:\n- [[Vega] remove VEGA_DEBUG\n(#234477)](https://github.com/elastic/kibana/pull/234477)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Marco Vettorello <[email protected]>"}},{"branch":"9.0","label":"v9.0.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/235352","number":235352,"state":"MERGED","mergeCommit":{"sha":"d940f7267527ae279e00154f35f427d1c30d9526","message":"[9.0] [Vega] remove VEGA_DEBUG (#234477) (#235352)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Vega] remove VEGA_DEBUG\n(#234477)](https://github.com/elastic/kibana/pull/234477)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Marco Vettorello <[email protected]>"}},{"branch":"8.19","label":"v8.19.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/235351","number":235351,"state":"MERGED","mergeCommit":{"sha":"48e544d25bc6a940f17ff321cd4601e86bb9f180","message":"[8.19] [Vega] remove VEGA_DEBUG (#234477) (#235351)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.19`:\n- [[Vega] remove VEGA_DEBUG\n(#234477)](https://github.com/elastic/kibana/pull/234477)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Marco Vettorello <[email protected]>"}}]}] BACKPORT-->
This commit removes the VEGA_DEBUG variable from window object.
This commit removes the VEGA_DEBUG variable from window object.
Summary
This PR removes the VEGA_DEBUG variable from window object.
Docs removal PR here elastic/docs-content#2957