Skip to content

Conversation

@markov00
Copy link
Member

@markov00 markov00 commented Sep 9, 2025

Summary

This PR removes the VEGA_DEBUG variable from window object.

Docs removal PR here elastic/docs-content#2957

@markov00 markov00 added Feature:Vega Vega visualizations Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes labels Sep 15, 2025
@markov00 markov00 marked this pull request as ready for review September 15, 2025 16:03
@markov00 markov00 requested a review from a team as a code owner September 15, 2025 16:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeVega 2.1MB 2.1MB -293.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeVega 34.2KB 34.2KB +3.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
visTypeVega 7 6 -1

Total ESLint disabled count

id before after diff
visTypeVega 7 6 -1

History

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Manually checked the presence of VEGA_DEBUG on main and verified it's gone in this branch.

@markov00 markov00 merged commit 03f47de into elastic:main Sep 17, 2025
13 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.18, 8.19, 9.0, 9.1

https://github.com/elastic/kibana/actions/runs/17796636206

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 17, 2025
This commit removes the VEGA_DEBUG variable from window object.

(cherry picked from commit 03f47de)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 17, 2025
This commit removes the VEGA_DEBUG variable from window object.

(cherry picked from commit 03f47de)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 17, 2025
This commit removes the VEGA_DEBUG variable from window object.

(cherry picked from commit 03f47de)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.18 Backport failed because of merge conflicts
8.19
9.0
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 234477

Questions ?

Please refer to the Backport tool documentation

markov00 added a commit to elastic/docs-content that referenced this pull request Sep 17, 2025
Remove this docs after the removal of the VEGA_DEBUG functionality.

See elastic/kibana#234477 or ask the Visualization team for more info.
kibanamachine added a commit that referenced this pull request Sep 17, 2025
# Backport

This will backport the following commits from `main` to `9.1`:
- [[Vega] remove VEGA_DEBUG
(#234477)](#234477)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Marco
Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-09-17T11:51:01Z","message":"[Vega]
remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG
variable from window
object.","sha":"03f47de4412ec686ef5a09e035949639776c6489","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Vega","Team:Visualizations","release_note:skip","backport:all-open","v9.2.0"],"title":"[Vega]
remove
VEGA_DEBUG","number":234477,"url":"https://github.com/elastic/kibana/pull/234477","mergeCommit":{"message":"[Vega]
remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG
variable from window
object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/234477","number":234477,"mergeCommit":{"message":"[Vega]
remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG
variable from window
object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}}]}]
BACKPORT-->

Co-authored-by: Marco Vettorello <[email protected]>
kibanamachine added a commit that referenced this pull request Sep 17, 2025
# Backport

This will backport the following commits from `main` to `9.0`:
- [[Vega] remove VEGA_DEBUG
(#234477)](#234477)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Marco
Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-09-17T11:51:01Z","message":"[Vega]
remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG
variable from window
object.","sha":"03f47de4412ec686ef5a09e035949639776c6489","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Vega","Team:Visualizations","release_note:skip","backport:all-open","v9.2.0"],"title":"[Vega]
remove
VEGA_DEBUG","number":234477,"url":"https://github.com/elastic/kibana/pull/234477","mergeCommit":{"message":"[Vega]
remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG
variable from window
object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/234477","number":234477,"mergeCommit":{"message":"[Vega]
remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG
variable from window
object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}}]}]
BACKPORT-->

Co-authored-by: Marco Vettorello <[email protected]>
kibanamachine added a commit that referenced this pull request Sep 17, 2025
# Backport

This will backport the following commits from `main` to `8.19`:
- [[Vega] remove VEGA_DEBUG
(#234477)](#234477)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Marco
Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-09-17T11:51:01Z","message":"[Vega]
remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG
variable from window
object.","sha":"03f47de4412ec686ef5a09e035949639776c6489","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Vega","Team:Visualizations","release_note:skip","backport:all-open","v9.2.0"],"title":"[Vega]
remove
VEGA_DEBUG","number":234477,"url":"https://github.com/elastic/kibana/pull/234477","mergeCommit":{"message":"[Vega]
remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG
variable from window
object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/234477","number":234477,"mergeCommit":{"message":"[Vega]
remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG
variable from window
object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}}]}]
BACKPORT-->

Co-authored-by: Marco Vettorello <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Sep 24, 2025
This commit removes the VEGA_DEBUG variable from window object.
markov00 added a commit to markov00/kibana that referenced this pull request Sep 25, 2025
This commit removes the VEGA_DEBUG variable from window object.

(cherry picked from commit 03f47de)

# Conflicts:
#	src/platform/plugins/private/vis_types/vega/public/vega_view/vega_base_view.js
markov00 added a commit to markov00/kibana that referenced this pull request Sep 25, 2025
This commit removes the VEGA_DEBUG variable from window object.

(cherry picked from commit 03f47de)

# Conflicts:
#	src/plugins/vis_types/vega/public/vega_view/vega_base_view.js
#	src/plugins/vis_types/vega/public/vega_visualization.test.js
@markov00
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.18
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

markov00 added a commit that referenced this pull request Sep 25, 2025
# Backport

This will backport the following commits from `main` to `8.18`:
- [[Vega] remove VEGA_DEBUG
(#234477)](#234477)

<!--- Backport version: 10.0.2 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Marco
Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-09-17T11:51:01Z","message":"[Vega]
remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG
variable from window
object.","sha":"03f47de4412ec686ef5a09e035949639776c6489","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Vega","Team:Visualizations","release_note:skip","backport:all-open","v9.2.0","v9.1.4","v9.0.7","v8.19.4"],"title":"[Vega]
remove
VEGA_DEBUG","number":234477,"url":"https://github.com/elastic/kibana/pull/234477","mergeCommit":{"message":"[Vega]
remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG
variable from window
object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/234477","number":234477,"mergeCommit":{"message":"[Vega]
remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG
variable from window
object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}},{"branch":"9.1","label":"v9.1.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/235353","number":235353,"state":"MERGED","mergeCommit":{"sha":"3f77c7e51c9910198d2041c2b655ec7db96c33e4","message":"[9.1]
[Vega] remove VEGA_DEBUG (#234477) (#235353)\n\n# Backport\n\nThis will
backport the following commits from `main` to `9.1`:\n- [[Vega] remove
VEGA_DEBUG\n(#234477)](https://github.com/elastic/kibana/pull/234477)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Marco Vettorello
<[email protected]>"}},{"branch":"9.0","label":"v9.0.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/235352","number":235352,"state":"MERGED","mergeCommit":{"sha":"d940f7267527ae279e00154f35f427d1c30d9526","message":"[9.0]
[Vega] remove VEGA_DEBUG (#234477) (#235352)\n\n# Backport\n\nThis will
backport the following commits from `main` to `9.0`:\n- [[Vega] remove
VEGA_DEBUG\n(#234477)](https://github.com/elastic/kibana/pull/234477)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Marco Vettorello
<[email protected]>"}},{"branch":"8.19","label":"v8.19.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/235351","number":235351,"state":"MERGED","mergeCommit":{"sha":"48e544d25bc6a940f17ff321cd4601e86bb9f180","message":"[8.19]
[Vega] remove VEGA_DEBUG (#234477) (#235351)\n\n# Backport\n\nThis will
backport the following commits from `main` to `8.19`:\n- [[Vega] remove
VEGA_DEBUG\n(#234477)](https://github.com/elastic/kibana/pull/234477)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Marco Vettorello <[email protected]>"}}]}] BACKPORT-->
markov00 added a commit that referenced this pull request Sep 25, 2025
# Backport

This will backport the following commits from `main` to `7.17`:
- [[Vega] remove VEGA_DEBUG
(#234477)](#234477)

<!--- Backport version: 10.0.2 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Marco
Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-09-17T11:51:01Z","message":"[Vega]
remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG
variable from window
object.","sha":"03f47de4412ec686ef5a09e035949639776c6489","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Vega","Team:Visualizations","release_note:skip","backport:all-open","v9.2.0","v9.1.4","v9.0.7","v8.19.4"],"title":"[Vega]
remove
VEGA_DEBUG","number":234477,"url":"https://github.com/elastic/kibana/pull/234477","mergeCommit":{"message":"[Vega]
remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG
variable from window
object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/234477","number":234477,"mergeCommit":{"message":"[Vega]
remove VEGA_DEBUG (#234477)\n\nThis commit removes the VEGA_DEBUG
variable from window
object.","sha":"03f47de4412ec686ef5a09e035949639776c6489"}},{"branch":"9.1","label":"v9.1.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/235353","number":235353,"state":"MERGED","mergeCommit":{"sha":"3f77c7e51c9910198d2041c2b655ec7db96c33e4","message":"[9.1]
[Vega] remove VEGA_DEBUG (#234477) (#235353)\n\n# Backport\n\nThis will
backport the following commits from `main` to `9.1`:\n- [[Vega] remove
VEGA_DEBUG\n(#234477)](https://github.com/elastic/kibana/pull/234477)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Marco Vettorello
<[email protected]>"}},{"branch":"9.0","label":"v9.0.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/235352","number":235352,"state":"MERGED","mergeCommit":{"sha":"d940f7267527ae279e00154f35f427d1c30d9526","message":"[9.0]
[Vega] remove VEGA_DEBUG (#234477) (#235352)\n\n# Backport\n\nThis will
backport the following commits from `main` to `9.0`:\n- [[Vega] remove
VEGA_DEBUG\n(#234477)](https://github.com/elastic/kibana/pull/234477)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Marco Vettorello
<[email protected]>"}},{"branch":"8.19","label":"v8.19.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/235351","number":235351,"state":"MERGED","mergeCommit":{"sha":"48e544d25bc6a940f17ff321cd4601e86bb9f180","message":"[8.19]
[Vega] remove VEGA_DEBUG (#234477) (#235351)\n\n# Backport\n\nThis will
backport the following commits from `main` to `8.19`:\n- [[Vega] remove
VEGA_DEBUG\n(#234477)](https://github.com/elastic/kibana/pull/234477)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Marco Vettorello <[email protected]>"}}]}] BACKPORT-->
niros1 pushed a commit that referenced this pull request Sep 30, 2025
This commit removes the VEGA_DEBUG variable from window object.
rylnd pushed a commit to rylnd/kibana that referenced this pull request Oct 17, 2025
This commit removes the VEGA_DEBUG variable from window object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:all-open Backport to all branches that could still receive a release Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.17.30 v8.18.8 v8.19.4 v9.0.7 v9.1.4 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants