Unboomify SOR space-auth errors #241391
Open
Unboomify SOR space-auth errors #241391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
release_note:skip
TinaHeiligers
commented
Oct 31, 2025
| return Boolean(doc && 'found' in doc); | ||
| } | ||
|
|
||
| export function isForbiddenSpacesError(error: unknown): boolean { |
There was a problem hiding this comment.
@jeramysoucy FYI
There was a problem hiding this comment.
Errors are usually defined in src/core/packages/saved-objects/server/src/saved_objects_error_helpers.ts and then given a code like CODE_BAD_REQUEST so that we can accurately test against them.
If we only test against the status code I'm afraid that not all errors that pass isForbiddenSpacesError are actually because of a spaces forbidden error.
This might be harder because it's coming from the spacesExtension but I think we should try to move towards errors that communicate the problem in domain language instead of generic 403 status codes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point, depending directly on
Boomfor error handling snuck into the SOR APIs, which leaves the SOR and API consumers vulnerable to breaking changes from@hapiupgrades.This PR introduces an error helper in much the same way as other errors are handled in the SOR to minimise direct imports from framework packages.