[Streams] Refine Suggestions Before Save #241439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamedhamed-ahmed
added
release_note:skip
Contributor
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
Contributor
|
Pinging @elastic/streams-program-team (Team:streams-program) |
…-refine-suggestions-before-saving
…thub.com/mohamedhamed-ahmed/kibana into streams-refine-suggestions-before-saving
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
thomheymann
approved these changes
Nov 6, 2025
Contributor
thomheymann
left a comment
thomheymann
left a comment
There was a problem hiding this comment.
LGTM! ✨
Only issue I noticed is that the update & accept button does not seem to have a check icon. Is that intentional?
Contributor
Author
Yeah true, just noticed as well 😅 the old figma design does have a check. while the last image from @patpascal misses it. I can add it with my next PR for the Partitioning Tab Tests, let me know @patpascal wdyt.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/elastic/streams-program/issues/527
Summary
This PR allows user to edit a given partition suggestion before saving it.
Cell actions can also be used when editing an AI suggestions same as for the manually created ones.
🎥 Demo
Screen.Recording.2025-11-04.at.13.14.06.mov