Skip to content

Conversation

@angeles-mb
Copy link
Contributor

Closes #237856

Summary

  • Added differentiated error messages for the TagSelector for the following use cases:
    • Tag doesn't exist:
      • If user has permissions, prompt to create it
      • If they don't, prompt to select one from the list
    • Tag exists, prompt to select it
    • Tag exists and it is already selected
  • This change should fix all occurrences of the missing error message for the TagSelector.
  • For the Settings flyout, instead of directly using the TagSelector we are now using the wrapper containing this validation logic, there should be no other changes.

Testing

Flyout Settings:

Screen.Recording.2025-10-31.at.12.03.03.mov

Dashboard Details:

Screen.Recording.2025-10-31.at.12.03.52.mov

Error announcement on VO:

Screenshot 2025-10-31 at 12 04 46

@angeles-mb angeles-mb self-assigned this Oct 31, 2025
@angeles-mb angeles-mb added backport:version Backport to applied version labels v9.2.1 release_note:skip Skip the PR/issue when compiling release notes labels Oct 31, 2025
@angeles-mb angeles-mb marked this pull request as ready for review October 31, 2025 12:36
@angeles-mb angeles-mb requested review from a team as code owners October 31, 2025 12:36
@nickpeihl nickpeihl self-requested a review October 31, 2025 12:46
@angeles-mb
Copy link
Contributor Author

angeles-mb commented Oct 31, 2025

@elasticmachine run docs-build-pr

Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! code review and tested roles with and without tag create capability.

@bhavyarm bhavyarm added the ci:cloud-deploy Create or update a Cloud deployment label Oct 31, 2025
@bhavyarm
Copy link
Contributor

/ci

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 31, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #20 / discover/esql Index editor allows creation by manually adding data

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 661.5KB 661.4KB -129.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
savedObjectsTagging 20.7KB 21.7KB +1.0KB

History

cc @angeles-mb

Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on cloud and with voiceover. So happy to see a11y fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes v9.2.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Platform:Dashboards]Tags field missing error text

4 participants