Skip to content

Commit d02c7ff

Browse files
committed
Remove set_security_user processor configs to make all unsupported processors same behavior.
1 parent afc0621 commit d02c7ff

File tree

3 files changed

+57
-50
lines changed

3 files changed

+57
-50
lines changed

spec/integration/elastic_integration_spec.rb

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1481,4 +1481,61 @@ def path; @path; end
14811481
end
14821482
end
14831483

1484+
context '#unsupported processors' do
1485+
let(:settings) {
1486+
super().merge(
1487+
"ssl_certificate_authorities" => "spec/fixtures/test_certs/root.crt"
1488+
)
1489+
}
1490+
1491+
unsupported_processors = {
1492+
'set_security_user' =>
1493+
'{
1494+
"set_security_user": {
1495+
"field": "user"
1496+
}
1497+
}',
1498+
'inference' =>
1499+
'{
1500+
"inference": {
1501+
"model_id": "model_deployment_for_inference",
1502+
"input_output": [{"input_field": "content", "output_field": "content_embedding"}]
1503+
}
1504+
}',
1505+
'enrich' =>
1506+
'{
1507+
"enrich": {
1508+
"policy_name": "enrich_policy_name",
1509+
"field": "source_field",
1510+
"target_field": "target_field"
1511+
}
1512+
}'
1513+
}
1514+
1515+
before(:each) do
1516+
subject.register
1517+
end
1518+
1519+
shared_examples 'processor failure' do
1520+
it 'adds failure tag to metadata' do
1521+
events = [LogStash::Event.new(
1522+
"message" => "55.3.244.1 GET /index.html 15824 0.043",
1523+
"data_stream" => data_stream
1524+
)]
1525+
1526+
subject.multi_filter(events).each do |event|
1527+
failure_reason = event.get("[@metadata][_ingest_pipeline_failure]")
1528+
expect(failure_reason).to be_truthy
1529+
end
1530+
end
1531+
end
1532+
1533+
unsupported_processors.each do |name, config|
1534+
describe "with #{name} processor" do
1535+
let(:pipeline_processor) { config }
1536+
include_examples 'processor failure'
1537+
end
1538+
end
1539+
end
1540+
14841541
end

src/main/java/co/elastic/logstash/filters/elasticintegration/EventProcessorBuilder.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import co.elastic.logstash.api.Event;
1010
import co.elastic.logstash.api.FilterMatchListener;
1111
import co.elastic.logstash.filters.elasticintegration.ingest.RedactPlugin;
12-
import co.elastic.logstash.filters.elasticintegration.ingest.SetSecurityUserProcessor;
1312
import co.elastic.logstash.filters.elasticintegration.ingest.SingleProcessorIngestPlugin;
1413
import co.elastic.logstash.filters.elasticintegration.resolver.CacheReloadService;
1514
import co.elastic.logstash.filters.elasticintegration.resolver.CachingResolver;
@@ -33,7 +32,6 @@
3332
import org.elasticsearch.painless.PainlessPlugin;
3433
import org.elasticsearch.painless.PainlessScriptEngine;
3534
import org.elasticsearch.painless.spi.PainlessExtension;
36-
import org.elasticsearch.painless.spi.Whitelist;
3735
import org.elasticsearch.plugins.ExtensiblePlugin;
3836
import org.elasticsearch.plugins.IngestPlugin;
3937
import org.elasticsearch.script.IngestConditionalScript;
@@ -128,7 +126,6 @@ public EventProcessorBuilder() {
128126
org.elasticsearch.ingest.common.UriPartsProcessor.TYPE));
129127
this.addProcessorsFromPlugin(IngestUserAgentPlugin::new);
130128
this.addProcessorsFromPlugin(RedactPlugin::new);
131-
this.addProcessor(SetSecurityUserProcessor.TYPE, SetSecurityUserProcessor.Factory::new);
132129
}
133130

134131
// event -> pipeline name

src/main/java/co/elastic/logstash/filters/elasticintegration/ingest/SetSecurityUserProcessor.java

Lines changed: 0 additions & 47 deletions
This file was deleted.

0 commit comments

Comments
 (0)